diff --git a/CHANGELOG.md b/CHANGELOG.md index 71e4a8c45..3873d8446 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -45,6 +45,8 @@ _Breaking developer changes, which may affect downstream projects or sites that * Drop legacy support for Internet Explorer 11 ([#8811]) #### :white_check_mark: Validation * Handle indoor features like buildings when checking for crossing ways ([#8944]) +#### :bug: Bugfixes +* Fix rendering of KeepRight issues ([#8963]) #### :rocket: Presets * Optimize order of values in dropdowns of `access` fields ([#8945]) * Use value of `vehicle` tag as placeholder value of `access` fields for `motor_vehicle` and `bicycle` @@ -57,13 +59,14 @@ _Breaking developer changes, which may affect downstream projects or sites that [#8927]: https://github.com/openstreetmap/iD/issues/8927 [#8944]: https://github.com/openstreetmap/iD/issues/8944 [#8945]: https://github.com/openstreetmap/iD/issues/8945 +[#8963]: https://github.com/openstreetmap/iD/issues/8963 # 2.20.4 ##### 2022-Feb-03 #### :bug: Bugfixes -* Fix rendering of HTML content in KeepRight and ImproveOSM issues ([#8928]) +* Fix rendering of HTML content in ~~KeepRight and~~ ImproveOSM issues ([#8928]) * Fix "local storage is exceeded" error message showing up multiple times ([#8930]) [#8928]: https://github.com/openstreetmap/iD/pull/8928 diff --git a/modules/ui/keepRight_header.js b/modules/ui/keepRight_header.js index 91230849c..3931b61b7 100644 --- a/modules/ui/keepRight_header.js +++ b/modules/ui/keepRight_header.js @@ -12,12 +12,11 @@ export function uiKeepRightHeader() { let replacements = d.replacements || {}; replacements.default = { html: unknown }; // special key `default` works as a fallback string - const title = t.html(`QA.keepRight.errorTypes.${itemType}.title`, replacements); - if (title !== unknown) { - return t.apply(`QA.keepRight.errorTypes.${itemType}.title`, replacements); - } else { - return t.apply(`QA.keepRight.errorTypes.${parentIssueType}.title`, replacements); + let title = t.html(`QA.keepRight.errorTypes.${itemType}.title`, replacements); + if (title === unknown) { + title = t.html(`QA.keepRight.errorTypes.${parentIssueType}.title`, replacements); } + return title; }