From ff506fc3320de5aa78fdb3730b978352367cad99 Mon Sep 17 00:00:00 2001
From: Quincy Morgan <quincy.morgan@icloud.com>
Date: Thu, 12 Dec 2019 17:50:48 -0500
Subject: [PATCH] Prevent partial rendering of selection style when showing
 only selected features at low zooms

---
 modules/behavior/breathe.js |  6 ++++++
 modules/modes/select.js     | 41 ++++++++++++++++++++++++-------------
 2 files changed, 33 insertions(+), 14 deletions(-)

diff --git a/modules/behavior/breathe.js b/modules/behavior/breathe.js
index 74bc0aa72..b3ebaf0ec 100644
--- a/modules/behavior/breathe.js
+++ b/modules/behavior/breathe.js
@@ -142,6 +142,7 @@ export function behaviorBreathe() {
             });
     }
 
+    var _isInstalled = false;
 
     function behavior(surface) {
         _done = false;
@@ -155,8 +156,12 @@ export function behaviorBreathe() {
             _timer.stop();
             return true;
         }, 20);
+        _isInstalled = true;
     }
 
+    behavior.isInstalled = function() {
+        return _isInstalled;
+    };
 
     behavior.off = function() {
         _done = true;
@@ -166,6 +171,7 @@ export function behaviorBreathe() {
         _selected
             .interrupt()
             .call(reset);
+        _isInstalled = false;
     };
 
 
diff --git a/modules/modes/select.js b/modules/modes/select.js
index 201f078db..1efb45e65 100644
--- a/modules/modes/select.js
+++ b/modules/modes/select.js
@@ -40,10 +40,11 @@ export function modeSelect(context, selectedIDs) {
     };
 
     var keybinding = utilKeybinding('select');
+    var breatheBehavior = behaviorBreathe(context);
     var behaviors = [
         behaviorCopy(context),
         behaviorPaste(context),
-        behaviorBreathe(context),
+        breatheBehavior,
         behaviorHover(context),
         behaviorSelect(context),
         behaviorLasso(context),
@@ -403,25 +404,37 @@ export function modeSelect(context, selectedIDs) {
 
             // Don't highlight selected features past the editable zoom
             if (!context.map().withinEditableZoom()) {
+
+                if (breatheBehavior.isInstalled()) {
+                    context.uninstall(breatheBehavior);
+                }
+
                 surface.selectAll('.selected').classed('selected', false);
                 surface.selectAll('.selected-member').classed('selected-member', false);
-                return;
-            }
 
-            var selection = context.surface()
-                .selectAll(utilEntityOrMemberSelector(selectedIDs, context.graph()));
+            } else if (context.map().withinEditableZoom()) {
 
-            if (selection.empty()) {
-                // Return to browse mode if selected DOM elements have
-                // disappeared because the user moved them out of view..
-                var source = d3_event && d3_event.type === 'zoom' && d3_event.sourceEvent;
-                if (drawn && source && (source.type === 'mousemove' || source.type === 'touchmove')) {
-                    context.enter(modeBrowse(context));
+                var selection = context.surface()
+                    .selectAll(utilEntityOrMemberSelector(selectedIDs, context.graph()));
+
+                if (selection.empty()) {
+                    // Return to browse mode if selected DOM elements have
+                    // disappeared because the user moved them out of view..
+                    var source = d3_event && d3_event.type === 'zoom' && d3_event.sourceEvent;
+                    if (drawn && source && (source.type === 'mousemove' || source.type === 'touchmove')) {
+                        context.enter(modeBrowse(context));
+                    }
+                } else {
+                    selection
+                        .classed('selected', true);
                 }
-            } else {
-                selection
-                    .classed('selected', true);
+
+                if (!breatheBehavior.isInstalled()) {
+                    context.install(breatheBehavior);
+                }
+
             }
+
         }