225 Commits

Author SHA1 Message Date
Martin Raifer 9b7a98862d Merge remote-tracking branch 'origin/housenumber-labels' into develop 2025-05-12 18:02:47 +02:00
McLaynV 61670beb1d remove empty line from drag_note.js (#11015) 2025-05-06 09:19:00 +02:00
Martin Raifer bcdf6b9e71 add some additional tag keys to list of not-interesting tags 2025-04-23 11:55:13 +02:00
Martin Raifer aa96a67c65 use lodash-es everywhere, replace custom clamp methods with lodash 2025-04-21 14:43:35 +02:00
Chaitanya Kadu 552c6b6148 preserve step_count/… while joining ways (#10926)
* preserve the sum of certain tags (`step_count`, `parking:*:capacity`) during _join_ operation
* preserve total value of `parking:*:capacity` tags during _split_ operation by distributing it proportionally to the resulting ways
* the abstract osm entity now accepts a list of tags to override during the merging, but otherwise is agnostic about how tags can be merged: the concrete merging resolution might depend on the concrete action that was performed
2025-04-17 14:13:53 +02:00
Martin Raifer 28d1a4c66d osm entities always have an id property 2025-03-10 11:17:56 +01:00
Kyℓe Hensel 9d16588f19 move deprecatedTags logic out of osmEntity and into a helper function (#10842) 2025-03-07 18:29:25 +01:00
Kyℓe Hensel 16f1187c04 fix some direction cones not appearing on railway tracks (#10843)
also refactored the logic for readability
2025-03-07 18:22:51 +01:00
Kyℓe Hensel 38d2ccd866 isHighwayIntersection only applies to nodes, so remove from osmEntity (#10831) 2025-03-04 11:29:29 +01:00
Kyℓe Hensel 147c785594 fix the turn restriction editor not supporting bidirectional roads (#10800) 2025-02-22 10:01:26 +01:00
Kyℓe Hensel ef88e1c7ca fix destination_sign relations not updated when splitting a way (#10646) 2025-02-17 11:46:42 +01:00
Kyℓe Hensel f513ccd03d enable intellisense for the main classes (#10618) 2025-02-17 11:35:50 +01:00
Kyℓe Hensel 4747ae253c refactor isOneWay to properly support bidirectional ways (#10730) 2025-02-12 14:22:09 +01:00
Kyle Hensel f244e63661 validate crossing aeroways (#9315) 2025-02-05 14:42:32 +01:00
Kyℓe Hensel a2e347ac97 prevent degenerate ways caused by deleting a corner of a triangle (#10003) 2025-02-05 14:38:03 +01:00
Martin Raifer 3be7eb6fca restrict direction cones to matching parent ways, fixes #9013
for certain vertex features, only look at matching parent ways when determining where to draw direction cones:

* highway related points (e.g. highway=stop/yield/etc., traffic calming, cycleway=asl, traffic signs, barriers): only look at parent ways with highway=*
* railway related points (e.g. railway=milestone): only look at parent ways with railway=*
* waterway related points (e.g. waterway=milestone): only look at parent ways with waterway=*

see also #5634
2024-12-11 12:04:41 +01:00
Dimitar 42ea2b9dee Added railway=ventilation_shaft as area key (#10278)
fixes https://github.com/openstreetmap/id-tagging-schema/issues/1263
2024-07-22 15:28:28 +02:00
Waldir Pimenta 95ce7de78b Add waterway=flowline to waterway tags representing directional water flows (#10283) 2024-07-17 10:11:22 +02:00
Martin Raifer 94a55434bb Merge remote-tracking branch 'k-yle/conveying' into develop 2024-06-05 13:02:37 +02:00
Martin Raifer 99d7a85ab4 Merge remote-tracking branch 'k-yle/highway-ladder' into develop 2024-06-05 12:58:56 +02:00
Martin Raifer 82d3c6d22a fix small typos 2024-05-27 12:54:36 +02:00
Kyle Hensel c7731f5499 support highway=ladder 2024-05-25 16:25:59 +10:00
Kyle Hensel 180a2bbd50 render oneway arrows for the conveying tag 2024-05-25 16:01:04 +10:00
Martin Raifer ee56b9c8ae render closed amenity=bicycle_parking ways as areas by default
fixes https://github.com/openstreetmap/id-tagging-schema/issues/1114#issuecomment-2018057194
2024-03-26 15:19:35 +01:00
Martin Raifer 97442403cf drop validator which checks for old style multipolygons
these have long been [fixed](https://blog.jochentopf.com/2017-08-28-polygon-fixing-effort-concluded.html) in OSM

see wiki: https://wiki.openstreetmap.org/wiki/Old_style_multipolygons
2024-02-29 13:28:22 +01:00
marc tobias 277b5d4f45 new validator: mutually exclusive tags 2024-02-25 18:40:10 +01:00
Martin Raifer b00a7e31ec don't consider traffic_calming features as areas
prerequisite for https://github.com/openstreetmap/id-tagging-schema/pull/1076
2024-01-24 13:48:29 +01:00
Martin Raifer 20b72a2b68 only render route colours if the value is a valid color
addresses https://github.com/openstreetmap/iD/pull/9424#discussion_r1046495633
2023-11-17 13:47:16 +01:00
Kyℓe Hensel 3b24932bda fix highway=busway not supported in the turn restriction editor (#9633) 2023-11-14 09:53:23 +01:00
Martin Raifer 9779f320a8 Properly handle case sensitive tags in taginfo suggestion in raw tag editor, fixes #9640 2023-05-16 17:06:39 +02:00
Biswajit Kaushik 25cf4366d1 Fix wrongly flagged "incorrect geometry type" for features with lifecycle-prefixed tags (#9483) 2023-05-10 12:02:37 +02:00
Martin Raifer 0334533aee render sidedness markers for man_made=quay
see https://github.com/openstreetmap/id-tagging-schema/pull/810#issuecomment-1464181204
2023-03-13 15:14:27 +01:00
Kyℓe Hensel 43b4b4f02b render right-sided arrows for features with lifecycle prefixes (#9493) 2023-03-03 18:53:10 +01:00
Kyℓe Hensel d6b869fe7a add 4 tags which imply oneway=yes (#9492) 2023-03-03 18:48:22 +01:00
Martin Raifer dc9b6a3acb only treat traffic_calming=island as an area tag
this is required for a proper fix of https://github.com/openstreetmap/id-tagging-schema/issues/733
2023-01-18 19:15:16 +01:00
Martin Raifer 5091966056 [WIP] add string length indicator and max-length message 2022-11-25 17:48:33 +01:00
Martin Raifer 56e92e661c split function branches to reduce complexity 2022-11-08 13:55:28 +01:00
Martin Raifer 5f1360ed0f don't suggest to "connect the ends" if a feature with area tags matches a line preset
For example, when a feature tagged as `highway=primary` (line preset) and `man_made=bridge` (area preset) is mapped as an unclosed way, converting it to an area (by closing the way by connecting the endpoints) does not improve the situation, as then the other tag doesn't fit to the geometry anymore.

closes #7037
2022-11-04 12:23:15 +01:00
Martin Raifer 097c6bd774 skip unsupported/invalid restrictions instead of fallback to "no_*"
closes #9337 (at least kind of… for a proper solution see #6460)
2022-10-27 18:36:05 +02:00
Kyℓe Hensel 81f3b0666c support incrementing cardinal directions with the 🔼/🔽 buttons (#9141) 2022-07-15 16:48:47 +02:00
Kyℓe Hensel e9759bd425 treat chipseal as a paved surface (#9139) 2022-06-09 18:20:08 +02:00
Kyℓe Hensel 724462ec47 consider lifecycle prefixes in osmTagSuggestingArea (#8881) 2022-06-06 15:56:31 +02:00
Martin Raifer 04a07092d2 Handle more "hybrid" area+line tags as area-by-default, fixes #8985 2022-02-16 15:56:28 +01:00
Kyle Hensel 35e528946d seamark:type=separation_lane implies oneway 2022-01-07 18:05:26 +13:00
Thomas Petillon 7a1d08f80e Return the empty string when calling toOSM() on entities with test IDs 2021-12-06 21:25:22 +01:00
John Firebaugh 1457759994 Add support for connectivity relations 2021-09-08 20:30:38 -07:00
Milos Brzakovic 3d24736b8f trailing spaces 2021-08-05 17:36:48 +02:00
Milos Brzakovic 750b4e023f crossing_ways fixing - specially handle crossing nodes 2021-08-05 14:50:38 +02:00
Bryan Housel 3665f80d46 Also include operator:wikidata as a wikidata tag
osmEntity#hasWikipedia was only used by the suspicious_name validator
2021-01-29 11:11:59 -05:00
Quincy Morgan ba48a861bc Enable curly and block-spacing eslint rules 2020-11-10 14:19:11 -05:00