19 Commits

Author SHA1 Message Date
Martin Raifer 97442403cf drop validator which checks for old style multipolygons
these have long been [fixed](https://blog.jochentopf.com/2017-08-28-polygon-fixing-effort-concluded.html) in OSM

see wiki: https://wiki.openstreetmap.org/wiki/Old_style_multipolygons
2024-02-29 13:28:22 +01:00
Quincy Morgan ba48a861bc Enable curly and block-spacing eslint rules 2020-11-10 14:19:11 -05:00
Quincy Morgan b42dec741b Followup to #8083 2020-10-21 09:51:36 -04:00
teymour-aldridge 90d3f59aa6 Remove some unneeded variables.
These should theoretically actually slow down the JIT (if very marginally) so performance-wise it's better not to have them.
2020-10-14 19:00:10 +01:00
Quincy Morgan a4e0bcb29c Make misplaced multipolygon tags check more consistent 2019-02-26 08:53:00 -05:00
Quincy Morgan 9785021f44 Rename simpleMultipolygon functions to oldMultipolygon
Return old_multipolygon validation issues for the relations as well as the outer ways
Remove console logging
Don't run missing_tag validation for relations with old_multipolygon issues
2019-02-01 15:19:28 -05:00
Bryan Housel 90876f6fec but actually link to the correct issue 2018-04-18 23:48:54 -04:00
Bryan Housel 42472b129a Link to relevant issues in comment 2018-04-18 23:46:39 -04:00
Bryan Housel 00e5e8efa0 Avoid reversing osmWays in order to "prefer a forward path"
(closes #4872, related #4859)
2018-04-18 23:43:19 -04:00
Bryan Housel be46e85ec0 Move insert way pairing code from osmJoinWays to actionAddMember
(tests for actionAddMember now passing!)
2018-01-16 17:41:14 -05:00
Bryan Housel 221158e918 WIP: Add insertHint to actionAddMember, actionSplit 2018-01-15 23:13:59 -05:00
Bryan Housel 03fa6e7be9 Add tryInsert option to osmJoinWays 2018-01-15 22:02:43 -05:00
Bryan Housel 0382ce7d4b Updated function doc 2018-01-14 21:45:25 -05:00
Bryan Housel 8dbb6eb20c Return reversal actions performed by osmJoinWays
(see #4688)
2018-01-13 01:45:46 -05:00
Bryan Housel 0fd801d750 Prefer to join member ways in a way that preserves their order
(re #4589)

Strongly prefer to generate a forward path that preserves the order
of the members array. For multipolygons and most relations, member
order does not matter - but for routes, it does. If we started this
sequence backwards (i.e. next member way attaches to the start node
and not the end node), reverse the initial way before continuing.
2018-01-12 17:23:56 -05:00
Bryan Housel 855c112ae0 Convert lodah-es and d3 to named imports for osm 2017-09-25 14:14:49 -04:00
Bryan Housel 89013627fb Don't consider untagged multipolygons as old multipolygons
Also add a lot of old-style multipolygon tests
(closes #4009)
2017-05-04 12:16:04 -04:00
Bryan Housel f92320c166 Ignore uninteresting tags in old-style multipolygon code 2017-04-21 09:40:05 -04:00
Bryan Housel f50e80d0b5 Refactor Intersection, Multipolygon from geo to osm 2016-10-11 23:09:27 -04:00