734 Commits

Author SHA1 Message Date
Martin Raifer
2dc64f0fef cache panoramax sequence data (prev/next links)
to allow more snappy scrolling through the photos of a sequence using the prev/next buttons
the cache is primed with information for "most of" the selected sequence, see also https://gitlab.com/panoramax/server/api/-/issues/268
2025-05-21 16:56:57 +02:00
Martin Raifer
3c9d232d41 make sure pannellum viewer is ready to load new photo, fixes #11054
while loading a "scene", pannellum cannot load a new panorama scene. This means we have to wait while the viewer is busy loading an existing panorama until we can load a new one.
2025-05-21 16:38:31 +02:00
Martin Raifer
5fb540b551 cache userid to username data for panoramax service 2025-05-21 14:18:14 +02:00
Martin Raifer
9b7a98862d Merge remote-tracking branch 'origin/housenumber-labels' into develop 2025-05-12 18:02:47 +02:00
Martin Raifer
5c721808c6 change variables for better readability, closes #11022 2025-05-06 11:25:32 +02:00
Martin Raifer
d5118b0fd6 make sure photos is properly highlighted when switching providers
previously, when the photo was already loaded in the mapillary viewer, then another photo from a different provider was displayed and the previous mapillary photo selected again, the "highlighted photo" marker was not drawn correctly, and the "set mapillary id from photo" button not properly updated
2025-04-29 17:19:55 +02:00
Martin Raifer
ab7df6e040 disable keyboard controls for pannellum viewer, fixes #11001
this makes it similar to how the non 360° viewer and mapillary's 360° viewer work, allowing regular iD keyboard shortcuts to be used even when the focus is on the photo viewer
2025-04-29 13:52:59 +02:00
Martin Raifer
0e6ca91727 fix initial loading of pannellum viewer for vegbilder photos 2025-04-29 12:54:59 +02:00
Martin Raifer
81d94a138b fix mapillary's panorama viewer from loading properly
this was a regression from the previous commit (19957d0e3)

also, harmonize code slightly between different services
2025-04-29 11:50:37 +02:00
Martin Raifer
19957d0e39 keep photo viewer state on reset, properly clean up active marker
when switching between photos from different providers

fixes #10987
2025-04-29 09:38:18 +02:00
Martin Raifer
fa91fe7c0d fix zoom resetting wrongly when switching background mid-transition
see https://github.com/openstreetmap/iD/issues/10700#issuecomment-2832010049
2025-04-26 21:10:16 +02:00
Martin Raifer
aa96a67c65 use lodash-es everywhere, replace custom clamp methods with lodash 2025-04-21 14:43:35 +02:00
Martin Raifer
f5eb4d2a51 don't de-select map feature when clicking on a street level photo 2025-04-15 18:14:59 +02:00
Martin Raifer
ade83ba6e0 extend kartaview's domain hotpatching, use full resolution images, fixes #10927 2025-04-04 13:57:20 +02:00
MOHAMED ALI FAWZI
9590c88646 Panoramax: Adopt "copy id" feature from mapillary (#10856) 2025-03-19 20:13:46 +01:00
Mattia Pezzotti
d1e5c2910c add date slider for street level photos, and more (#10394)
full list of enhancements:

* year slider to filter photos by freshness
* toggle active streetlevel layers with shortcut `shift+P`
* hfov, pitch and direction is now held between sequences and images as asked in #10392
* fix for #10361 (only panoramax)
* added tests and jsdoc
* add ticks for existing photos on slider
* general bug fixes
* rudimentary support for toDate in date slider (only when iD is started with a "to" date in the hash parameter: show a second slider to visualize and set the "to" date)

---------

Co-authored-by: Martin Raifer <martin@raifer.tech>
2025-03-18 21:09:37 +01:00
Martin Raifer
6bae24fa94 hotpath URL for kartaview photos ¯_(ツ)_/¯ 2025-03-18 20:47:00 +01:00
Martin Raifer
b2e4d81767 fix infoboxes for NSI presets, fixes #10885
(which had regressed in c1ca888)
2025-03-17 12:11:51 +01:00
Martin Raifer
49e895e2ed log failed API requests in console
to more easily debug API issues in the future
2025-03-11 15:49:56 +01:00
Martin Raifer
91aa85a1c0 better handling of rate limited API map calls and other API errors
* retry all unsuccessful map calls after waiting 8 seconds (spinner continues to indicate loading state)
* also logged-in users can be rate limited: add dedicated error message
* don't log users out when requests return 401/403 (except on the _get own user data_ request, which would indicate that the oauth token was revoked): it's better to show the error message if a legitimate api call was actually unauthorized

closes #10299
2025-03-11 15:40:05 +01:00
Kyℓe Hensel
7beace6698 add a changeset tag if a merge conflict occurred (#9636) 2025-03-05 12:38:32 +01:00
Martin Raifer
2b8ea8fc6a de-duplicate mapilio sequence linestrings
fixes poor performance
closes #10532
2025-02-22 10:53:36 +01:00
Martin Raifer
f2615f8a70 replace https workaround with uriScheme API param
See https://learn.microsoft.com/en-us/bingmaps/rest-services/imagery/get-imagery-metadata#template-parameters

Addendum to #10798
2025-02-22 09:51:16 +01:00
Kyℓe Hensel
fb1bce5a8a Always use HTTPS to load Bing Streetside images (#10798) 2025-02-22 09:42:04 +01:00
Martin Raifer
31345c073a correctly detect Locale:* results when there are more than one langCodes
fixes a false positive console warning, e.g. reported in #9045

> Occasionally, it also gives a message which is not an error: "Unexpected title Locale:nl"
2025-02-17 21:17:59 +01:00
Kyℓe Hensel
c1ca888b72 linkify keys & tags in the preset docs from the wiki (#10763) 2025-02-12 15:42:29 +01:00
Martin Raifer
121f3e2fb8 don't reauthenticate on HTTP 400 errors
since these are likely unrelated to authentication issues, but rather have to do with generic API errors or outages
2025-02-11 16:29:01 +01:00
Kyℓe Hensel
add513f39e fix confusing behaviour after logging out in the standalone build of iD (#10683)
when user logs out of osm.org via the logout button: the popup continues to the login screen, which if completed now logs the user back into iD with the new credentials
2025-01-22 17:25:56 +01:00
Chaitanya Kadu
25421ba31f remove unused import utilArrayUnion from kartaview.js (#10668) 2025-01-10 16:16:24 +01:00
Martin Raifer
f38bc5fc78 harmonize how Kartaview layer is highlighting marker on hover, fixes #10531
also closes #10565
2024-12-04 10:31:04 +01:00
Dimitar
b3579d6c7c Preserve 'opening_hours' when matching with NSI
re: https://github.com/osmlab/name-suggestion-index/issues/10170#issuecomment-2508129832
re: b1f2c3f4d0

These are tags that we want to leave alone (i.e. not offer an "upgrade")
if they already have a value. We assume the mapper knows best.
2024-11-29 20:28:31 +02:00
Kyle Hensel
7afecd39ec minor tweaks to make some tests pass 2024-09-03 19:23:21 +10:00
Martin Raifer
b0e47ca93c make sure viewer is visible before selecting photo
otherwise the newly selected photo is not displayed correctly when switching between regular and 360 photos

see #10362
2024-08-08 14:55:46 +02:00
Martin Raifer
9e239df569 fix intermittent issues with Bing Streetside API
sometimes the API returns data in a format not matching the documented format (see https://learn.microsoft.com/en-us/bingmaps/articles/getting-streetside-tiles-from-imagery-metadata).

see https://github.com/openstreetmap/iD/issues/10341#issuecomment-2275724738

closes #10341
2024-08-08 14:44:50 +02:00
Martin Raifer
f570d9bfa3 increase max zoom for panellum viewer, closes #10391 2024-08-08 13:07:35 +02:00
Martin Raifer
a8e438c58d sort markers by date (newest on top) 2024-08-07 10:00:59 +02:00
Martin Raifer
136308821a make sure the active image is rendered above other photo markers 2024-08-07 09:54:54 +02:00
Martin Raifer
7e111944db try to equally space to be rendered markers in mid zoom levels
closes #10378
2024-08-07 09:30:46 +02:00
Mattia Pezzotti
309735c25e Fix panoramax blur when switching imagery (#10385)
fixes #10362
2024-08-07 09:03:20 +02:00
Mattia Pezzotti
ebb68d610e Fix panoramax non existing inaccurate sequence (#10375)
fixes #10365
2024-08-03 21:08:57 +02:00
Mattia Pezzotti
dd7de08a35 Fix panoramax highlight selected sequence (#10374)
closes #10366
2024-08-03 21:03:58 +02:00
Mattia Pezzotti
e9095eb1bf Fix panoramax errors when image not in cache (#10376) 2024-08-03 20:45:38 +02:00
Martin Raifer
0ea3afa9f7 make sure map is not panned on arrow key input on 360° photo viewer
if the pannellum viewer is active, the arrow keys should rotate the view, and not also pan the map.

fixes #10360
2024-07-31 18:09:06 +02:00
Martin Raifer
b4eaeb3088 lint: remove unused code, code style and early update cached username 2024-07-29 16:29:39 +02:00
Martin Raifer
f25e94c71b update username filter on input change; fix multiple names/ids
in panoramax a username can resolve to multiple ids (when the same name is used on multiple servers).
further, the username filter input field can contain more than one username
2024-07-29 16:15:34 +02:00
Martin Raifer
df3b5a4440 make "captured by …" translatable; single line if possible 2024-07-29 15:36:59 +02:00
Martin Raifer
b492627689 switch link to panoramax.xyz viewer 2024-07-29 15:36:26 +02:00
Martin Raifer
9407f309a7 Merge branch 'develop' into panoramax 2024-07-29 15:13:38 +02:00
Martin Raifer
984f25adbb Merge pull request #10046 from laigyu/add-button-to-mapillary
Add a button in the mapillary image photo viewer to "add the current image id as field to feature"
2024-07-16 22:14:21 +02:00
Martin Raifer
175eea340b Merge remote-tracking branch 'origin/dependabot/npm_and_yarn/mapbox/vector-tile-2.0.2' into develop 2024-07-16 16:53:25 +02:00