2499 Commits

Author SHA1 Message Date
Bryan Housel c0090929e0 Remove no longer needed substring - see dc7fba4bf 2020-02-21 10:32:27 -05:00
Quincy Morgan b16f37499a Add terms and use direction_vertex field for spike strip preset (re: #7347) 2020-02-18 08:41:23 -08:00
SilentSpike 18287284c6 Remove translations link from Osmose UI
- Not useful to majority of users and clutters the UI
- Anyone interested in translation will already be looking at the iD
project and we can direct them from there
2020-02-16 12:47:38 +00:00
SilentSpike af0e37f7c5 Add "view on osmose" link to UI footer 2020-02-15 11:48:01 +00:00
Bryan Housel 086cade061 Restore Maxar imagery layers using masked urls
(cherry pick of #7356)
2020-02-14 14:51:03 -05:00
Quincy Morgan 3cff395972 Add YYYY-MM-DD placeholder to date fields (close #7270) 2020-02-13 10:30:06 -08:00
Bryan Housel 204cb2300a Squashed commit of the following:
commit 82e230007fca02d486c3b2fa135d76bca8593d21
Merge: 2ed4acaf2 1cc6237c7
Author: Bryan Housel <bryan@mapbox.com>
Date:   Thu Feb 13 10:30:56 2020 -0500

    Merge branch '7347_new' of https://github.com/animesh-007/iD into animesh-007-7347_new

commit 1cc6237c78d5a582417eae700767d6605fbc7e27
Author: animesh-007 <animeshagarwal7@gmail.com>
Date:   Thu Feb 13 20:47:57 2020 +0530

    deleted spike.json

commit 5bba63c36ad040ea8eaf4f139bbc99cb8b941e54
Author: animesh-007 <animeshagarwal7@gmail.com>
Date:   Thu Feb 13 20:45:01 2020 +0530

    named properly

commit 96426f3efdf65c9eee2125fd036c077cd4d0a35d
Author: animesh-007 <animeshagarwal7@gmail.com>
Date:   Thu Feb 13 01:25:23 2020 +0530

    modified spike.json

commit 40c092c1ea1bc56e078cbf94f2d9e69b5bc4e40f
Author: animesh-007 <animeshagarwal7@gmail.com>
Date:   Thu Feb 13 01:22:53 2020 +0530

    deleted spike_strip.json

commit 679a409aacd0320b6cbbb470065c6efd7c9e0429
Author: animesh-007 <animeshagarwal7@gmail.com>
Date:   Thu Feb 13 00:55:38 2020 +0530

    renamed to spike strip

commit e484aea0ec4bdf456a697ed9bf170076e12486b4
Author: animesh-007 <animeshagarwal7@gmail.com>
Date:   Thu Feb 13 00:52:50 2020 +0530

    removed spike.json

commit 60ea432a5e3a4aeba8063232fbf1497305be90a2
Author: animesh-007 <animeshagarwal7@gmail.com>
Date:   Wed Feb 12 19:08:08 2020 +0530

    spike preset
2020-02-13 10:33:05 -05:00
Quincy Morgan 7364cb38fe Add "Cycle & Foot Crossing" preset (close #7321) 2020-02-10 13:04:46 -05:00
Bryan Housel 0ffc7ca19a Merge branch '7313' of https://github.com/animesh-007/iD into animesh-007-7313 2020-02-06 11:17:03 -05:00
animesh-007 76033a77a2 changed file name 2020-02-06 13:42:13 +05:30
animesh-007 9ab525f198 added new preset 2020-02-05 21:15:43 +05:30
Quincy Morgan 4ff634b90f Enable the circularize operation for multiple selected features (close #7326) 2020-02-05 09:57:33 -05:00
Quincy Morgan f2638c0c1e Merge pull request #7290 from openstreetmap/error-button-strings
Update QA button strings
2020-02-04 17:01:42 -05:00
SilentSpike 4c843f60db Merge pull request #7095 from openstreetmap/osmose
Add Osmose Q/A layer
2020-02-04 21:47:28 +00:00
SilentSpike 02f088e5a9 Update some QA translation strings 2020-02-04 21:03:34 +00:00
Quincy Morgan 7dce4409ee Update to temaki 3.15.0 (re: #7068)
Add terms for static caravan and notice board presets
2020-02-04 11:06:20 -05:00
SilentSpike 377e99240f Add Osmose translations link to details footer
Improves structure of the details UI and introduces the use of flexboxes
for this. Does not break UI for other error services with shared classes.
2020-02-03 23:20:45 +00:00
SilentSpike 06ac02f89f Use Osmose dynamic subtitile string
Providing a `langs` param that's currently not implemented so these will
all be English until that is done.
2020-02-03 23:20:45 +00:00
SilentSpike 010ca30999 Show more Osmose strings in the UI
Also only add sections where appropriate
2020-02-03 23:20:44 +00:00
SilentSpike 5d93d3cace Prepare to use Osmose issue detail strings
- Remove translation description strings, will be using supplied
translations once the API is updated
- Change the way elements and details are presented since they can't be
easily integrated into the 3rd party description strings
2020-02-03 23:20:44 +00:00
SilentSpike 7d76950d55 Use Osmose translation strings for issue titles
This is just step one in the process while we wait for the API to supply
further strings and filtering to reduce the amount of string data
requested (since we don't need it all).

Strings are requested when the layer is first enabled and cached for the
current language (plus English as a backup).
2020-02-03 23:20:43 +00:00
SilentSpike 9fca611ec1 Add support for even more Osmose error types
- Conflicting tags
- Orthographic errors (excess whitespace and all capital names)
- Deprecated tagging
- Bad use of the "area" tag
2020-02-03 23:20:43 +00:00
SilentSpike a53f1c0f67 Add support for Osmose unnecessary tag error type 2020-02-03 23:20:42 +00:00
SilentSpike c13eb15691 Add support for more Osmose error types
- Unconnected level crossings
- Unconnected highway features/barries
- Unexpected punctuation/symbols in tag values
- Unbalanced parentheses/quotes in name values
- Invalid date formats
- Access tagging that permits all transport modes
- Elements with a "name" tag and no main tagging
- Relations missing a "type" value
2020-02-03 23:20:42 +00:00
SilentSpike cc3039033f Support more subtypes of osmose error type 8300 2020-02-03 23:20:41 +00:00
SilentSpike 896ed762e0 Fix silent failure for some Osmose error types
When I added special handling for mapillary errors the code was trying
to access translation strings nested under the error category (which
doesn't exist for all error types). This code is now moved into it's own
function so that variable hoisting doesn't run it for non-applicable
error types and prevent them from working.

- Also adds support for error type 3040 (bad tag value)
- Updated the Osmose sidebar UI title
2020-02-03 23:20:41 +00:00
SilentSpike d4723ec9e2 Read icons from qa_errors.json when building data
Also adds support for the following error types:
- Objects mapped as both node/area or way/area
- Power lines that lead to nowhere
- Extra nodes in power lines (which should only go from support to
support to endpoint)
- Power line supports with no power lines
2020-02-03 23:20:30 +00:00
SilentSpike 5afdfc527b Add support for more Osmose error types
- Missing parking access
- Malformed opening hours tagging
- Objects detected by Mapillary that aren't mapped
- Traffic sign information detected by Mapillary that isn't mapped

Mapillary errors add example code for special error type handling as
they don't need to request further details and can use piecewise
translation strings
2020-02-03 23:01:03 +00:00
SilentSpike b24b041335 Add Osmose issue detail fetching for UI
Must fetch details per-issue to get the associated OSM elements for
highlighting and use in the error description.

Also fixes URL for error closure.
2020-02-03 23:01:03 +00:00
SilentSpike 680fdb6b54 Allow Osmose errors to use category for UI strings
Some error types don't require unique strings and can share common
strings among the category. This makes that possible as well as adding
support for some other types of error for demonstrative purposes.
2020-02-03 23:01:02 +00:00
SilentSpike 09e7b23665 Add Osmose issues UI and filtering
Filters out errors not present in the data .json file to enable
selective support since Osmose has a wide variety of errors which may be
too advanced for iD.

Also added processing for the elements associated with an error for
forced visibility and highlighting.
2020-02-03 23:01:01 +00:00
SilentSpike e11d97b38c Add Osmose QA layer and service
Initial implementation - need to add UI for the errors and correctly set
up support for the desired error types provided by osmose.
2020-02-03 23:01:01 +00:00
Quincy Morgan 3370bea588 Add derived data for #7289 2020-02-03 13:58:12 -05:00
Quincy Morgan 4627a158f8 Merge pull request #7323 from animesh-007/7296
added new preset, fixes #7296
2020-02-03 08:57:02 -05:00
animesh-007 54fa13be7e added new preset 2020-02-03 17:43:52 +05:30
Bryan Housel ab3b731d66 Merge pull request #7310 from animesh-007/7274-new
Added new preset, fixes #7274
2020-01-31 15:21:01 -05:00
Quincy Morgan 208f3d5d1c Add Incline field to rail presets
Use field inheritance for rail presets
2020-01-31 14:58:12 -05:00
animesh-007 813afc073e added new feature 2020-02-01 01:11:57 +05:30
Quincy Morgan 04bd811fde Merge pull request #7306 from openstreetmap/multiselection-field-editing
Enable field editing in multiselection
2020-01-31 14:36:42 -05:00
animesh-007 fb52e2d5b5 added new feature 2020-02-01 00:58:50 +05:30
Quincy Morgan 2783408fc3 Add tooltips to mixed values in semicombo, multicombo, and radio fields 2020-01-31 14:07:16 -05:00
Quincy Morgan 5cd65efd6e Update generic aerialway and aeroway preset names to include "Feature"
Add icon to generic power preset
2020-01-31 10:07:55 -05:00
Bryan Housel 6e5cb45c17 Don't bundle the imagery anymore, fetch from dist/data at runtime
(re: #4994)
2020-01-30 17:10:41 -05:00
Bryan Housel e19bcb77d5 Require init() call before coreContext starts doing things
(closes #7304)
2020-01-29 19:27:12 -05:00
Bryan Housel 567eeac587 Make several data external instead of bundled:
Also dist/data/* contains minified files now

These are now external and will fetch as needed:
-export { dataAddressFormats } from './address-formats.json';
-export { dataDeprecated } from './deprecated.json';
-export { dataDiscarded } from './discarded.json';
-export { dataLanguages } from './languages.json';
-export { dataPhoneFormats } from './phone-formats.json';
-export { dataShortcuts } from './shortcuts.json';
-export { dataTerritoryLanguages } from './territory-languages.json';
2020-01-28 22:21:31 -05:00
Bryan Housel 31e007fc83 Create a data loader and move the intro graph into dist/data
(re: #3403)
2020-01-27 17:15:00 -05:00
SilentSpike ee520b756c Update QA button strings
See https://github.com/openstreetmap/iD/pull/7095#issuecomment-570066602
for motivation
2020-01-25 22:22:48 +00:00
Quincy Morgan 5640f37bb6 Add terms to car repair shop 2020-01-24 09:22:57 -05:00
Quincy Morgan 69df630f21 Support multiple values in the beauty field (close #7215) 2020-01-24 09:20:23 -05:00
Quincy Morgan 046fb1d0bf Add derived data for prior merge (re: #7284) 2020-01-23 08:59:42 -05:00