Quincy Morgan
d3946894e8
Standardize deprecated_tag and missing_tag rule type ids
...
Run crossing_ways before disconnected_way
Break out crossing_ways issue creation into a separate function
2019-02-04 16:29:29 -05:00
Quincy Morgan
bfb5285dc9
Fix tests and lint warnings
2019-02-04 13:34:27 -05:00
Quincy Morgan
2677a88df4
Zoom to ways and relations upon clicking on their issues in the issues pane
2019-02-04 10:27:35 -05:00
Quincy Morgan
9785021f44
Rename simpleMultipolygon functions to oldMultipolygon
...
Return old_multipolygon validation issues for the relations as well as the outer ways
Remove console logging
Don't run missing_tag validation for relations with old_multipolygon issues
2019-02-01 15:19:28 -05:00
Quincy Morgan
973697b8ba
Run all validators in the validations folder if not manually run
...
Remove ValidationIssueType and ValidationIssueSeverity objects
2019-02-01 13:38:17 -05:00
Quincy Morgan
46f3cea33a
Reorganize validation code
...
Rename IssueManager to coreValidator
Rename disconnected highway to disconnected way
Rename highway almost junction to almost junction
Rename mapcss checks to maprules
Rename deprecated tags to deprecated tag
2019-02-01 11:20:51 -05:00
Quincy Morgan
09bc2a6e6c
Merge branch 'master' into validation
2019-01-30 16:44:14 -05:00
Quincy Morgan
77c4d41855
Restore many deletions warning with tooltip and nicer message
...
Add tooltips back to issues pane list
Fix crash when restoring without having loaded the edited area
2019-01-30 15:48:06 -05:00
Bryan Housel
7138acc652
Properly export areaKeys, fix preset and maprules tests
2019-01-30 15:29:37 -05:00
Quincy Morgan
5b93ee0f7a
Run validation upon data restore after page reload
2019-01-30 13:40:02 -05:00
Quincy Morgan
226c4f88e1
Re-run validation automatically upon merging fetched remote data into the history
2019-01-29 11:10:12 -05:00
Quincy Morgan
0866110d77
Merge branch 'master' into validation
2019-01-29 09:16:06 -05:00
Quincy Morgan
02ccd7cfd6
v2.13.1
2019-01-28 17:38:05 -05:00
Quincy Morgan
ffe4aa09f4
Pass entity array into validators instead of changes object
2019-01-24 15:26:19 -05:00
Quincy Morgan
e69f2a0389
Merge branch 'master' into validation
2019-01-23 13:15:33 -05:00
Quincy Morgan
24b6e9aeec
v2.13.0
2019-01-23 11:33:23 -05:00
Bryan Housel
a873c0f2ca
Remove unused, add maprules documentation
2019-01-23 11:08:19 -05:00
Quincy Morgan
0499a76443
Fixed an entity not found error when restoring new ways that reference unloaded nodes ( closed #4108 , closed #5194 )
2019-01-22 12:56:37 -05:00
Quincy Morgan
536ee2e786
Validations now update instantly upon an annotated graph change
2019-01-14 15:19:00 -05:00
Quincy Morgan
11b2102761
Merge branch 'master' into validation
...
# Conflicts:
# data/core.yaml
# dist/locales/en.json
# modules/ui/commit_warnings.js
# modules/ui/entity_editor.js
# modules/util/index.js
# modules/util/util.js
# modules/validations/index.js
# modules/validations/many_deletions.js
# modules/validations/missing_tag.js
2019-01-14 10:13:56 -05:00
Bryan Housel
9c190e83e9
Add quickLinks to preset editor, zoom to selected feature
2019-01-09 21:56:08 -05:00
Bryan Housel
528cbb29e1
Store the transform and selectedIDs with the rest of the history
...
(closes #5664 )
2019-01-08 00:36:41 -05:00
Andrew Wong
5971bbebb7
Added more validation tests
2018-12-20 15:39:26 -05:00
Xiaoming Gao
a4e1012c91
add crossing_way validation
...
Tests are also added and passed.
One thing to note: I had to add the tree() function to history so that I can
use the tree in the test; hope that's fine.
2018-12-19 19:23:35 -05:00
Andrew Wong
6e749c70ef
listening to user generated history changes for validation
2018-12-19 17:28:34 -05:00
Thomas Hervey
31f35b0389
added basics to sidebar
2018-12-19 13:35:26 -05:00
Xiaoming Gao
c1e3a7396f
filter validations early in history
...
Follow @wonga00's comment in https://github.com/openstreetmap/iD/pull/5627
2018-12-19 12:05:06 -05:00
Xiaoming Gao
07a53fe6ea
Extend data model for validation issues
...
Add the Issues pane
1. Add a class to represent the validation issue
2. Extend the data model for an validation issue to
(1) add a severity level field (useful for identify save-blocking issues later)
(2) replace single entity with an array of entities (useful for issues involving multiple entities)
(3) add a coordinates field for highlighting the location of the issue on the map
(4) add a fixes field for possible automatic fixes
3. Update existing validation modules to use the new data model
2018-12-19 10:37:32 -05:00
Quincy Morgan
161311faa5
Merge pull request #5626 from wonga00/wonga_issue_manager
...
added IssueManager
2018-12-18 18:05:40 -05:00
Quincy Morgan
858a9606d5
Added entity display name or preset name to the disconnected highway message
2018-12-18 18:05:27 -05:00
Andrew Wong
30f25c6e8d
added IssueManager
...
- IssueManager performs validation on the current graph and also
stores the issues and notifies listeners when the issues changed
2018-12-18 17:52:23 -05:00
Bryan Housel
5a2049b421
Drop extra whitespace, make sure service exists before using it
2018-12-18 15:38:53 -05:00
Max Grossman
8f33a85a12
make collection.index function to handle failing tests
2018-12-17 17:16:10 -05:00
Max Grossman
e0e6f5b918
remove non-used util class
2018-12-17 12:52:21 -05:00
Max Grossman
d87b1822f7
add/make visible weakly matched presets
2018-12-14 15:42:25 -05:00
Max Grossman
1b51b8bc57
adding tests and updating/fixing external presets logic
2018-12-14 13:23:58 -05:00
Max Grossman
c897331cd1
presets test w/build
2018-12-13 13:30:38 -05:00
Max Grossman
96e44be69c
merge 2.12.2
2018-12-13 11:22:32 -05:00
Bryan Housel
eb14a9ed53
v2.12.2
2018-12-13 10:28:31 -05:00
Bryan Housel
13b1a9a629
If imagery becomes invalid, remove it from imagery_used
...
(closes #4827 )
2018-12-11 17:49:15 -05:00
Bryan Housel
b494684e4f
v2.12.1
2018-12-05 01:58:18 -05:00
Bryan Housel
5451d0f3fe
v2.12.0
2018-12-03 22:14:05 -05:00
Bryan Housel
152022aec4
Use context.keybinding for keybindings that don't change
...
(closes #5487 )
2018-11-13 20:57:21 -05:00
Max Grossman
622b7b9e0c
move validations to its own class
...
ref #remote-presets
2018-10-01 21:45:21 -04:00
Max Grossman
0a31137c78
move maprules/mapcss to a service class
...
ref #remote-presets
2018-09-23 18:38:01 -04:00
Max Grossman
155983197f
small variable change
2018-09-23 12:26:14 -04:00
Bryan Housel
ad289e0565
v2.11.1
2018-08-29 00:55:36 -04:00
Bryan Housel
2cee31d611
v2.11.0
2018-08-26 02:18:05 -04:00
Max Grossman
8f9a281825
additional test tweaks
...
ref #remote-presets
2018-08-14 12:49:41 -04:00
Bryan Housel
930e865b42
Attempt to prevent users from uploading duplicate changes
...
(closes #5200 )
This removes a users changes stored in localStorage if they try to close
iD while an upload is in progress. It prevents the possiblity that the
changeset is eventually accepted and closed, but the user can be prompted
to restore those changes the next time they start iD.
2018-08-11 19:15:18 -04:00