10 Commits

Author SHA1 Message Date
Quincy Morgan
f2ef27f78c Enable no-implicit-coercion eslint rule for strings 2020-10-23 14:03:50 -04:00
Bryan Housel
7a6c63fcc5 Remove lodash extend (re: #6087) 2019-03-23 00:38:39 -04:00
Bryan Housel
89ad643977 Let new note generate its own id, instead of using -1
Also stringify the note id (because existing notes from OSM are this way)
Also make sure comments is initialized as an Array not an Object
Also clarify some of the tests
2018-07-24 14:11:08 -04:00
Thomas Hervey
e23ef4ba4a redraw on note drag. TODO: change dispatch call 2018-07-23 15:09:25 -04:00
Thomas Hervey
bf9b19359a WIP drag note 2018-07-20 21:41:44 -04:00
Bryan Housel
1a106f5253 Make uiViewOnOSM work for notes too, add it to note_editor footer 2018-07-13 15:55:58 -04:00
Bryan Housel
ede561080d Add update method, remove getters..
This makes the osmNote work a bit more like other osm objects in iD.

- When working with the osm objects, we'll treat them as immutable.
  So all modifications will be through the update method:

  e.g. can do this in a repl, like chrome devtools console:
  >  n = iD.osmNote()
  osmNote { id: -1 }
  > n = n.update({ foo: 'bar' });
  osmNote { foo: "bar", id: -1, v: 1 }

- none of the other osm objects have getters, and in JavaScript all the
  properties are public anyway
2018-06-29 22:47:14 -04:00
Bryan Housel
fd1d2f006b Fix the osmNote initializer 2018-06-29 22:39:40 -04:00
Thomas Hervey
737ccfcfba updated: siebar displays note details on hover (via svg) 2018-06-29 14:43:01 -04:00
Thomas Hervey
3df01e27c0 added: svg notes, TODO: add icon, test 2018-06-20 17:38:45 -04:00