Quincy Morgan
d247ec3aed
Enable brace-style eslint rule
2020-11-10 13:49:48 -05:00
Quincy Morgan
15c8e060f8
Fix tests
2020-10-23 15:49:30 -04:00
Quincy Morgan
f2ef27f78c
Enable no-implicit-coercion eslint rule for strings
2020-10-23 14:03:50 -04:00
Quincy Morgan
3f9ac9105b
Enable no-undef-init eslint rule
2020-10-23 11:33:47 -04:00
Quincy Morgan
f8e4e43fab
Enable additional eslint rules, including no-constructor-return
2020-10-23 11:11:32 -04:00
Quincy Morgan
7ab7e4ffe0
Don't warn about deprecated tags that would overwrite existing data when upgraded ( close #7843 )
2020-10-21 11:58:00 -04:00
Quincy Morgan
b42dec741b
Followup to #8083
2020-10-21 09:51:36 -04:00
teymour-aldridge
90d3f59aa6
Remove some unneeded variables.
...
These should theoretically actually slow down the JIT (if very marginally) so performance-wise it's better not to have them.
2020-10-14 19:00:10 +01:00
Quincy Morgan
4ddd4a358b
Deprecate vending=parcel_mail_in;parcel_pickup -> vending=parcel_pickup;parcel_mail_in ( close #7988 )
...
Enable upgrading of entire semicolon-delimited values
2020-09-28 16:07:11 -04:00
Quincy Morgan
c940d827e6
Enable the Split operation for multiple selected nodes ( close #7990 )
2020-09-24 15:13:05 -04:00
Quincy Morgan
5ddcfb0ced
Add parameter to specify which way should keep the history when splitting ways (re: #7795 )
...
Fix code tests
2020-09-14 11:27:20 -04:00
Peter Newman
4205ca1d07
Fix the seemingly safe spellings found by codespell
...
Untested, only checked by inspection.
(cherry picked from commit 2c47a11008 )
2020-08-10 17:32:37 +01:00
Quincy Morgan
d179f791a9
Significantly improve the performance of the crossing_ways validation in areas with long ways ( close #7656 )
2020-06-22 16:49:32 -04:00
Quincy Morgan
fd180ff60c
Improve performance somewhat in some scenarios (re: #7656 )
2020-06-22 13:35:51 -04:00
Quincy Morgan
05d357159d
Add implied oneway logic info for man_made=goods_conveyor
2020-06-09 17:55:17 -04:00
Quincy Morgan
762307bd7d
Restrict key, value, and role character limits based on unicode characters, not UTF-16 code units (re: #6817 )
2020-06-09 15:41:15 -04:00
Quincy Morgan
85ce071704
Render "semi-paved" roads like cobblestone, paving stones, and wood with a solider line than unpaved roads ( close #7466 )
2020-03-26 19:26:29 -07:00
Quincy Morgan
5125c04a58
Fix issue where merging a point matching a fallback preset into an area could discard tag values ( close #7446 )
2020-03-23 12:47:14 -07:00
SilentSpike
3ee32776a7
Fix QA error icons
...
Pass service itself in to QAItem constructor for purpose of fetching
data. Store string as `title` property on the service.
2020-02-12 21:27:38 +00:00
Bryan Housel
a9a1f945f8
Move the qa_data external
...
- this means that QAItem now asks the service for the icon rather than knowing it directly
2020-02-07 10:06:47 -05:00
SilentSpike
51efd5b714
Update and standardise QA implementations
...
- ES6ify (now using class syntax to define QAItem objects)
- Fix bug with KeepRight marker rendering not updating properly
- Use `qa-` prefix for the UI element classes to differentiate from iD
validation error related UI element classes
- Move away from "error" where possible in source
- Move away from snake_case naming where possible
Note that some function/method names have been untouched to make life
easier for v3 development. Have added note comments where appropriate.
2020-02-06 23:07:50 +00:00
SilentSpike
406264c37e
Simplify structure of QA error data
2020-02-03 23:20:42 +00:00
Bryan Housel
567eeac587
Make several data external instead of bundled:
...
Also dist/data/* contains minified files now
These are now external and will fetch as needed:
-export { dataAddressFormats } from './address-formats.json';
-export { dataDeprecated } from './deprecated.json';
-export { dataDiscarded } from './discarded.json';
-export { dataLanguages } from './languages.json';
-export { dataPhoneFormats } from './phone-formats.json';
-export { dataShortcuts } from './shortcuts.json';
-export { dataTerritoryLanguages } from './territory-languages.json';
2020-01-28 22:21:31 -05:00
Quincy Morgan
17ae12b3d7
Address most common places where tag keys or values could exceed the 255 character API limit ( close #6817 )
2020-01-27 15:57:55 -05:00
Quincy Morgan
45d22261fc
Don't leave an extra junction segment when the end node of the crossing edge is only the endpoint of two lines (re: #7202 )
...
Make the length of added crossing structures much closer to the intended spherical length
2020-01-16 17:55:13 -05:00
Quincy Morgan
5011039087
Clarify some variable names in osmEntity.deprecatedTags and add more code tests
2020-01-09 09:49:31 -05:00
Quincy Morgan
09ad21a26f
Improve "add a bridge/tunnel" fixes by basing the structure length on the crossed feature type, not a fixed constant (re: #7202 )
2020-01-08 12:03:30 -05:00
Quincy Morgan
1049c338c6
Add waterway=tidal_channel preset ( close #7232 )
2020-01-07 10:14:43 -05:00
Quincy Morgan
31941e9389
Fix JavaScript error that could cause validation warnings to appear unexpectedly ( close #7166 )
...
Add code test to account for deprecated tags with no replacement
2019-12-31 12:03:57 -05:00
Quincy Morgan
93ff34dc39
Add preset for waterway=fish_pass
2019-12-17 13:22:05 -05:00
Quincy Morgan
81b561fffc
Don't close unclosed multipolygon parts with fewer than three nodes when generating geojson
...
Update multipolygon geojson code tests
2019-11-22 17:01:51 -05:00
Quincy Morgan
d0c5add378
Update some variable names to not be misleading
2019-11-22 14:43:16 -05:00
Quincy Morgan
4b9b0860bf
Fix incomplete rendering of unclosed multipolygon rings ( close #2945 )
2019-11-22 13:09:46 -05:00
Quincy Morgan
1f5cce9bdd
Don't treat source_ref subtags as descriptive tags
2019-11-18 15:49:32 -05:00
Quincy Morgan
b2611a941c
Don't treat various source tags as descriptive tags
2019-11-18 15:43:46 -05:00
Quincy Morgan
3d9bcc8234
Add directional arrows to waterway=weir rendered as lines ( close #6615 )
2019-07-03 15:46:23 -04:00
Bryan Housel
2f0e0dffdb
Merge pull request #6389 from openstreetmap/wikidata-style
...
Support special styling for Wikidata-tagged features
2019-05-20 18:05:29 -04:00
Quincy Morgan
e599488121
Lower the very close nodes warning threshold for buildings, building parts, and paths (re: #6374 )
...
Flag very close nodes in indoor features but with an extremely small threshold
2019-05-20 11:21:50 -04:00
Bryan Housel
344aec206c
Support special styling for wikidata-tagged features
2019-05-18 23:57:23 -04:00
Quincy Morgan
936822849a
Don't consider "highway=raceway" as routable ( #6385 )
...
Update the icon for the raceway preset
2019-05-18 11:49:25 -04:00
Quincy Morgan
409968dfc2
Add index of tags that positively identify points or vertices, derived from the presets
...
Delete nodes that can only be vertices when deleting parent ways (close #6230 )
Allow snapping ways to nodes that cannot be positively identified as vertex-only
2019-05-14 12:09:44 -04:00
Bryan Housel
2b46440429
Add Relation#hasFromViaTo method and tests
2019-04-29 21:39:40 -04:00
Quincy Morgan
228af9a000
Move areaKeys and setAreaKeys to modules/osm/tags
2019-04-26 12:53:05 -07:00
Quincy Morgan
ecc217f5d8
Add validation rule to flag impossible oneway highways and waterways ( close #6216 )
2019-04-26 12:04:43 -07:00
Quincy Morgan
d01bb78707
Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys ( close #6237 )
2019-04-24 13:45:59 -07:00
Bryan Housel
0a77a494aa
Merge branch 'master' into validation_and_change_perf
2019-04-10 14:22:20 -04:00
Quincy Morgan
17f2c5c0f4
Add Zip Line preset
2019-04-05 09:40:35 -07:00
Bryan Housel
765d765477
Pick a fake loc value where equality tests actually work
2019-04-03 17:25:10 -04:00
Bryan Housel
167824a530
Make sure all nodes have an actual loc property
...
- This is to make difference comparisons easier
- The only nodes that didn't have a `loc` were fake nodes we made for testing
- So this commit also fixes the `osmIntersection` code and tests.
2019-04-03 16:20:45 -04:00
Bryan Housel
d5abe468b9
Remove rest of the lodash iterators: map, reduce, forEach
...
(re: #6087 )
2019-03-29 15:14:21 -04:00