198 Commits

Author SHA1 Message Date
Quincy Morgan
baabd81987 Unbundle id-tagging-schema data and translations
Update for id-tagging-schema 2.0.0
2020-12-01 11:14:14 -05:00
Quincy Morgan
dc8fd13586 Enable array-callback-return eslint rule 2020-10-23 13:47:09 -04:00
Quincy Morgan
cb6ab1405b Enable additional eslint rules, including no-unreachable-loop 2020-10-23 10:54:28 -04:00
Quincy Morgan
2769ac87f1 Support territories in preset and field country limiters (re: #8102) 2020-10-21 18:21:17 -04:00
Quincy Morgan
47ae71ce16 Revert "Support territories in preset and field country limiters (re: #8102)"
This reverts commit a3a9259859.
2020-10-21 18:17:52 -04:00
Quincy Morgan
a3a9259859 Support territories in preset and field country limiters (re: #8102) 2020-10-19 13:12:05 -04:00
Quincy Morgan
c214a6c6e2 Add increment property for numeric fields (close #7867) 2020-10-13 12:00:01 -04:00
Quincy Morgan
4d51713253 Add lang attribute to more display text (re: #7963) 2020-09-24 11:34:33 -04:00
Quincy Morgan
f163722c9a Create a new manyCombo field type for the public transport vehicles field instead of using multiCombo in a new way (re: #6142) 2020-09-24 09:21:59 -04:00
Quincy Morgan
93cf717110 Include lang attribute in field labels 2020-09-22 13:33:52 -04:00
Quincy Morgan
5435082d9c Revert t function to returning the plain string by default
Add `t.html` function for getting the string with the `lang` attribute
2020-09-22 12:03:29 -04:00
Quincy Morgan
32f8274929 Make t function return a span element with a lang attribute unless html: false is specified in the options (re: #7963)
Update `text` functions to `html` to support inserting the `span` elements
Specify `html: false` for various instances where a `span` is not desired, e.g. `placeholder` and `title` attributes
2020-09-15 21:56:22 -04:00
Quincy Morgan
8708c13f87 Followup changes to #7932 2020-09-03 14:00:30 -04:00
Peter Newman
4205ca1d07 Fix the seemingly safe spellings found by codespell
Untested, only checked by inspection.

(cherry picked from commit 2c47a11008)
2020-08-10 17:32:37 +01:00
Quincy Morgan
49526a7a67 Fix JS error upon changing addablePresetIDs after initial load
Accept addablePresetIDs as an array
Add code tests for invalid preset IDs in addablePresetIDs
2020-06-02 11:19:30 -04:00
Quincy Morgan
78a4b75e55 Fix regression where explicit addable presets were not populating the default preset list 2020-05-28 16:16:35 -04:00
Quincy Morgan
90b1395df4 Fix code tests 2020-04-01 13:27:30 -07:00
Quincy Morgan
60f7dc7c0b Replace presets property of context with singleton
Remove utilPreset
2020-04-01 13:08:45 -07:00
Quincy Morgan
527faa7b42 Remove need for coreContext in presetIndex 2020-04-01 11:25:45 -07:00
Quincy Morgan
a58abe3c6f Move localStorage interface from a property of coreContext to a corePreferences function 2020-04-01 11:00:48 -07:00
Quincy Morgan
a950b193d1 Fix preset categories 2020-03-31 16:41:46 -07:00
Quincy Morgan
a1af118f0e Ensure locales and presets are loaded before the UI loads (close #7406)
Consolidate localization behavior and init to a coreLocalizer function and singleton
Explicitly support `en-US` locale
Rename coreData to coreFileFetcher and export a singleton rather than using a property of coreContext
Add `apiConnections` property of coreContext to simplify adding a source switcher
Replace some init functions with re-callable, promise-supporting `ensureLoaded` functions
Make coreContext itself load the UI if a container has been specified at init time
Fix code tests
2020-03-31 12:23:31 -07:00
Quincy Morgan
a7e639d514 Make the field geometry property accept multiple types
Make the Elevation field only universal for nodes (re: #5719)
Remove the elevation field from route presets (close #7479)
2020-03-28 13:57:06 -07:00
Bryan Housel
3608659d21 Restore field inheritance 2020-02-10 16:22:13 -05:00
Bryan Housel
0357c2b80c Rework presets.js file - WIP to fix resolving field inheritance 2020-02-07 14:17:19 -05:00
Bryan Housel
2149692bee Make sure the addablePresetIDs can be reset back to null too 2020-02-07 12:55:16 -05:00
Bryan Housel
1155498766 Restore the addablePresetID feature 2020-02-07 12:06:59 -05:00
Bryan Housel
9faf8c0fe5 Test that fallback presets are there before data is loaded
Also, we don't actually need a vertex preset anymore, it was removed a while ago
2020-02-06 17:04:11 -05:00
Bryan Housel
3c6ba9703a presetIndex.build -> presetIndex.merge, and make it merge data 2020-02-05 21:13:15 -05:00
Bryan Housel
147af19626 Seed presetIndex collection with fallback presets
- amazingly, this passes all tests, but iD ends up pretty non-functional
2020-02-05 12:21:33 -05:00
Bryan Housel
e3e7cd3003 Memoize presetCollection.item (it's an Array.find)
Also add tests for `matchAllGeometry`
2020-02-05 10:32:20 -05:00
Bryan Housel
0fe766d9a4 WIP on external presets
- preset data is no longer bundled into iD.js
- some code pathways commented out re: external presets
- many changes so that tests can run without presets at start, or async
- still need to make sure fallbacks are always there (point, line, area, etc)
2020-02-05 09:38:26 -05:00
Quincy Morgan
1b331bb678 Add mechanism for fields to support editing during multiselection (re: #7276)
Add `utilCombinedTags` method and use it for the raw tag editor as well as fields
Pass `entityIDs` array into fields instead of single `entity` object
Give field revertion its own path separate from `change`
Add multiselection editing to fields in files: access, address, check, combo, cycleway, input, maxspeed, textarea, and wikidata
2020-01-30 13:53:29 -05:00
Quincy Morgan
6bb2997306 Enable changing the preset of multiple selected features (re: #7276)
Fix issue where preset tag reference wouldn't load
Change "Change feature" tooltip to more accurate "Change feature type"
2020-01-21 15:19:51 -05:00
Quincy Morgan
41355bf2a0 Rename "visible" property of presets to "addable" (re: a06ec59514b30a52601e3614ef69006d2dc1bc91) 2020-01-15 14:29:45 -05:00
Quincy Morgan
11dfe7e571 Add util function for generating classes/ids from any string 2019-12-20 12:37:53 -05:00
Quincy Morgan
f6769238ed Revert references to the v3 UI in the Keyboard Shortcuts menu
Remove unused preset favoriting functionality
2019-12-20 12:05:04 -05:00
Bryan Housel
6dfdec06ad Ignore junction in areaKeys code and remove the unsearchable presets
(closes #6933)

We should not be adding unsearchable junction presets for every kind of
junction as a hacky workaround to let `junction=yes` be an area.

This should remove the special treatment of junction tag.
* `junction=*` will not be treated as an area by default
* `junction=*` will not trigger validator warnings that they should be closed
* `junction=yes` mapped as an area _will_ need an `area=yes` now, which iD will add
(afaik this is the only junction tag that should be treated as an area)
2019-11-04 10:53:36 -05:00
Quincy Morgan
b1eaa2c29d Allow values in addTags to blacklist tags from implying a way should be an area (close #6800) 2019-09-19 09:06:42 -04:00
Quincy Morgan
8b1c9fe323 Add notCountryCodes presets property to blacklist certain presets from certain countries
Show "Cycle & Foot Path" preset in all countries except France (re: #6836)
2019-09-17 13:54:59 -04:00
Bryan Housel
2fd6359505 Boost matchScore if additional matches occur in addTags
(closes #6802)
2019-08-26 12:53:03 -04:00
Quincy Morgan
67afa20dc0 Let comboboxes filter against terms, not just values
Add terms property to fields
Make terms translatable for searchable fields
Account for fields' terms and keys when filtering with the Add field menu (close #5763)
2019-08-09 11:12:40 -05:00
Quincy Morgan
3bf3ecf560 Populate the default preset list with the presets parameter values, if any (close #6703) 2019-07-31 16:18:10 -04:00
Quincy Morgan
2ad2bac931 Limit addable presets via comma-separated IDs in the presets URL parameter (close #6553) 2019-06-24 12:38:32 -04:00
Bryan Housel
b09b43f6d3 Trim the user's string when preset searching
(closes #6383)
2019-05-19 21:37:09 -04:00
Quincy Morgan
409968dfc2 Add index of tags that positively identify points or vertices, derived from the presets
Delete nodes that can only be vertices when deleting parent ways (close #6230)
Allow snapping ways to nodes that cannot be positively identified as vertex-only
2019-05-14 12:09:44 -04:00
Tobias Zwick
f1d9b82831 inherit preset.removeTags from preset.addTags if not defined 2019-04-30 09:50:47 +02:00
Bryan Housel
fceb1a86f7 Merge pull request #6245 from openstreetmap/d3-v5
d3 v5
2019-04-29 15:46:08 -04:00
Quincy Morgan
228af9a000 Move areaKeys and setAreaKeys to modules/osm/tags 2019-04-26 12:53:05 -07:00
Quincy Morgan
d01bb78707 Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys (close #6237) 2019-04-24 13:45:59 -07:00