94 Commits

Author SHA1 Message Date
Martin Raifer
81d94a138b fix mapillary's panorama viewer from loading properly
this was a regression from the previous commit (19957d0e3)

also, harmonize code slightly between different services
2025-04-29 11:50:37 +02:00
Martin Raifer
19957d0e39 keep photo viewer state on reset, properly clean up active marker
when switching between photos from different providers

fixes #10987
2025-04-29 09:38:18 +02:00
Martin Raifer
fa91fe7c0d fix zoom resetting wrongly when switching background mid-transition
see https://github.com/openstreetmap/iD/issues/10700#issuecomment-2832010049
2025-04-26 21:10:16 +02:00
Martin Raifer
f5eb4d2a51 don't de-select map feature when clicking on a street level photo 2025-04-15 18:14:59 +02:00
Martin Raifer
f2615f8a70 replace https workaround with uriScheme API param
See https://learn.microsoft.com/en-us/bingmaps/rest-services/imagery/get-imagery-metadata#template-parameters

Addendum to #10798
2025-02-22 09:51:16 +01:00
Kyℓe Hensel
fb1bce5a8a Always use HTTPS to load Bing Streetside images (#10798) 2025-02-22 09:42:04 +01:00
Martin Raifer
9e239df569 fix intermittent issues with Bing Streetside API
sometimes the API returns data in a format not matching the documented format (see https://learn.microsoft.com/en-us/bingmaps/articles/getting-streetside-tiles-from-imagery-metadata).

see https://github.com/openstreetmap/iD/issues/10341#issuecomment-2275724738

closes #10341
2024-08-08 14:44:50 +02:00
Martin Raifer
17d1c27bec use https for Bing Maps API 2024-02-16 23:19:30 +01:00
Martin Raifer
83754e4a4a switch to Bing Maps API for Bing Streetside layer, fixes #10074
replaces the use of undocumented APIs for Microsoft's street level imagery service and gets rid of hardcoded values, e.g. for the `g` ("generation") parameter

see https://learn.microsoft.com/en-us/bingmaps/rest-services/imagery/get-imagery-metadata#get-streetside-metadata-centered-at-a-point for API docs

see also #10100
2024-02-16 18:29:23 +01:00
Martin Raifer
7b622e040b Merge branch 'develop' into vegbilder 2023-07-20 17:21:45 +02:00
Martin Raifer
026737909f implement special address field for addr:street/addr:place 2023-04-28 16:36:05 +02:00
Martin Raifer
406c1a0690 bump streetview generation id to work around #9230
this is not a permanent fix; as explained in https://github.com/openstreetmap/iD/issues/8747#issuecomment-945669204 we should upgrade to Bing streetview's v8 API calls. Unfortunately, our API key is not enabled for that API, though.

closes #9230
2023-04-04 12:59:58 +02:00
Noenandre
5522338716 Rename pannellum-streetside dist folder to pannellum, since Pannellum isn't used by just Bing Streetside anymore.
TODO: Pannellum is loaded twice.
2023-02-14 12:25:43 +01:00
Martin Raifer
9f3f8e1366 rename method 2021-11-29 19:26:18 +01:00
Martin Raifer
d78c357588 replace raw html injection of localized texts
by using d3 to insert the localized text spans directly into the DOM
2021-11-26 18:51:45 +01:00
Martin Raifer
040257fd44 replace unnecessary setting of raw "html" with "text" 2021-11-18 18:53:33 +01:00
Nikola Pleša
7a0d8adb7b Switch to Mapillary API v4 2021-06-15 10:13:07 +02:00
Quincy Morgan
792a4e8594 Fix background tile issues caused by the cache not properly updating upon load/error with D3 v6 2020-10-26 14:52:58 -04:00
Quincy Morgan
f2ef27f78c Enable no-implicit-coercion eslint rule for strings 2020-10-23 14:03:50 -04:00
Quincy Morgan
9464ec5d87 Enable arrow-spacing eslint rule 2020-10-23 12:05:52 -04:00
Quincy Morgan
a48c69331f Merge branch 'develop' into photo-filter-temp 2020-10-15 13:38:15 -04:00
Quincy Morgan
a33ab44e81 Merge branch 'develop' into photo-filter-temp
# Conflicts:
#	css/80_app.css
#	modules/services/mapillary.js
2020-10-12 16:16:32 -04:00
Quincy Morgan
21a49bbec8 Initial support for D3 v6.2.0 2020-10-06 15:08:39 -04:00
Quincy Morgan
2fa64e7445 Switch from hyphen to slash for photo parameter separator (re: #6398) 2020-10-04 20:17:44 -04:00
Quincy Morgan
ad54a6e140 Support opening iD with a Streetside or OpenStreetCam photo specified as a URL parameter (close #6398)
Bring the APIs for the three street level services closer in sync
2020-10-02 13:30:36 -04:00
Quincy Morgan
5435082d9c Revert t function to returning the plain string by default
Add `t.html` function for getting the string with the `lang` attribute
2020-09-22 12:03:29 -04:00
Quincy Morgan
32f8274929 Make t function return a span element with a lang attribute unless html: false is specified in the options (re: #7963)
Update `text` functions to `html` to support inserting the `span` elements
Specify `html: false` for various instances where a `span` is not desired, e.g. `placeholder` and `title` attributes
2020-09-15 21:56:22 -04:00
Quincy Morgan
4050940268 Lazy load photo overlay resources (close #7982) 2020-09-13 11:52:37 -04:00
Nikola Plesa
23bce42618 feat: filter sequences from openstreetcam and streetside 2020-07-27 09:42:59 +02:00
Quincy Morgan
09a20bc809 Fix issue where panning the bing streetside photo viewer wouldn't update the bubble cone in the map 2020-07-07 13:52:55 -04:00
Quincy Morgan
95dc16b7a6 Update more mouse events to use pointer events if available (re: #5505) 2020-05-08 16:10:15 -07:00
Quincy Morgan
a1af118f0e Ensure locales and presets are loaded before the UI loads (close #7406)
Consolidate localization behavior and init to a coreLocalizer function and singleton
Explicitly support `en-US` locale
Rename coreData to coreFileFetcher and export a singleton rather than using a property of coreContext
Add `apiConnections` property of coreContext to simplify adding a source switcher
Replace some init functions with re-callable, promise-supporting `ensureLoaded` functions
Make coreContext itself load the UI if a container has been specified at init time
Fix code tests
2020-03-31 12:23:31 -07:00
Quincy Morgan
a7ce956e1f Don't use global selectors in street-level photo services (re: #7445) 2020-03-29 11:04:38 -07:00
Quincy Morgan
7e1cf64d0e Namespace DOM ids used in photo viewer (re: #7445) 2020-03-24 13:43:54 -07:00
Quincy Morgan
eed7944a1a Replace various uses of d3_select and d3_selectAll with selection on the container 2020-03-22 12:34:06 -07:00
Quincy Morgan
371bac0aa2 Convert photoviewer from id to class 2020-03-20 14:07:09 -07:00
Bryan Housel
d986d1b68d Use native Promises and drop "q" dependency, update streetside.js to es6 2019-11-08 16:24:41 -05:00
Quincy Morgan
271a4cbac7 Update rbush to 3.0.1 (close #6359) 2019-11-08 18:17:17 +01:00
Quincy Morgan
7d9f732753 Fix issue where Mapillary and Streetside viewers would not receive resize events (close #6286) 2019-08-22 10:19:46 -05:00
Bryan Housel
4a8c20c56e Remove lodash forEach
(re: 6087)
2019-03-28 19:50:20 -04:00
Bryan Housel
5e1ff74199 Replace lodash difference, intersects, union
(re: 6087)
2019-03-27 01:22:11 -04:00
Bryan Housel
7a6c63fcc5 Remove lodash extend (re: #6087) 2019-03-23 00:38:39 -04:00
Bryan Housel
ff4f8f005f Remove lodash find and findIndex
(re: #6087)
2019-03-22 17:31:41 -04:00
SilentSpike
129c28fb25 Fix street imagery selection highlight persistence
Root cause was the `select` mode removing the "selected" class from all
elements upon `exit()`. Easy fix is to use a different class (here
"currentView") for street imagery elements.
2019-01-29 13:26:53 +00:00
SilentSpike
99f7a90387 Fix imagery layers resetting eachother's classes
Fixes:
- Selecting a bubble then enabling a second imagery layer removes the hovered and selected highlighting
- If multiple imagery layers are enabled and you select a bubble it only temporarily becomes highlighted
- If multiple imagery layers are enabled and a bubble is highlighted, hovering over another imagery layer's bubble will remove the selected and hovered highlighting

Basically these all came down to style updates resetting all layers for
cases other than when the viewport was changed (where doing so makes
sense because the selected bubble/sequence needs to update as a result).

See #5494
2019-01-29 13:25:47 +00:00
Bryan Housel
1731ce4651 Partition viewport by tiles, not by pixels
(closes #4297)

The previous approach split the viewport up by pixels, but each time the view
moved, the pixels would change, so it was not a stable selection of the
streetview data, and the markers would fight for position as the user moved
around.

This approach uses utilTiler to partition the view into stable tiles.
2018-11-14 14:48:42 -05:00
Bryan Housel
08e9476f3e Fix photoviewer resize event 2018-11-06 13:09:04 -05:00
Bryan Housel
2fa593421f Rename scaleExtent to zoomExtent, slightly simplify getTiles() 2018-07-22 01:15:44 -04:00
Bryan Housel
7be9439c35 Use geoScaleToZoom to calculate zoom in Mapillary, OpenStreetCam 2018-07-21 21:59:35 -04:00
Bryan Housel
c0b77d8226 remove unneeded dimensions argument (projection clipExtent has it) 2018-07-21 21:44:14 -04:00