734 Commits

Author SHA1 Message Date
Nikola Plesa
944953dbf2 Update Mapillary map_features URL and remove request_data button 2020-07-01 16:50:30 +02:00
Quincy Morgan
8b258d2cbd Load the maximum nodes per way value from the OSM API and add a getter to the service object
Disable the Merge operation if the resultant way would have more than the maximum number of nodes (close #6030)
Simplify some code in operationMerge
2020-06-08 14:38:49 -04:00
Quincy Morgan
bf7b30ace9 Fix unreleased regression where OSM notes were being parsed as JSON and thus not loading (re: #7188) 2020-06-08 13:19:46 -04:00
Quincy Morgan
cee4b0a4da Give several functions more descriptive names 2020-06-08 09:50:13 -04:00
Quincy Morgan
41418e57a5 Fix issues with wikidata field searching and label updating 2020-05-20 11:23:01 -04:00
SilentSpike
24d83926e2 Fix white Osmose icons after changes upload
Prevent those elements of the Osmose service cache from being purged on
reset.

Fixes #7609
2020-05-17 17:41:44 +01:00
Quincy Morgan
95dc16b7a6 Update more mouse events to use pointer events if available (re: #5505) 2020-05-08 16:10:15 -07:00
SilentSpike
cf67684ed5 Fix Osmose details not always showing at first
Issues without a `subtitle` value would silently error when trying to
access the `auto` key of a null value which meant the elements weren't
showing up in the UI straight away.
2020-04-13 16:38:20 +01:00
Quincy Morgan
84a55606ad Show wikidata field search results in the user's language when possible 2020-03-31 13:00:52 -07:00
Quincy Morgan
a1af118f0e Ensure locales and presets are loaded before the UI loads (close #7406)
Consolidate localization behavior and init to a coreLocalizer function and singleton
Explicitly support `en-US` locale
Rename coreData to coreFileFetcher and export a singleton rather than using a property of coreContext
Add `apiConnections` property of coreContext to simplify adding a source switcher
Replace some init functions with re-callable, promise-supporting `ensureLoaded` functions
Make coreContext itself load the UI if a container has been specified at init time
Fix code tests
2020-03-31 12:23:31 -07:00
Quincy Morgan
a792334c8a Don't fetch taginfo values for more name keys (close #7485) 2020-03-29 11:29:29 -07:00
Quincy Morgan
a7ce956e1f Don't use global selectors in street-level photo services (re: #7445) 2020-03-29 11:04:38 -07:00
Quincy Morgan
7e1cf64d0e Namespace DOM ids used in photo viewer (re: #7445) 2020-03-24 13:43:54 -07:00
Quincy Morgan
eed7944a1a Replace various uses of d3_select and d3_selectAll with selection on the container 2020-03-22 12:34:06 -07:00
Quincy Morgan
371bac0aa2 Convert photoviewer from id to class 2020-03-20 14:07:09 -07:00
SilentSpike
6a58dabf42 Update Osmose API path
Should only change one more time after this (coming out of beta).
2020-03-19 21:05:44 +00:00
SilentSpike
81b2a2cd2a Update Osmose detail string access
Now supports localisation, which returns slightly different structure.
2020-03-17 12:40:38 +00:00
Quincy Morgan
207badb1a0 Read object visible state when parsing JSON API response (re: #7188) 2020-03-10 09:35:33 -07:00
Quincy Morgan
52222df75f Switch to JSON endpoints of OSM API for fetching entities (re: #3765) 2020-03-02 15:54:46 -08:00
Quincy Morgan
bf42bce3be Update martinez-polygon-clipping to v0.6.2 (close #7370) 2020-02-26 15:18:16 -08:00
SilentSpike
753ae3bdd2 Use marked for Osmose strings markdown
- More reliable method of handling markdown
- Change external links in the strings within the details code
2020-02-16 22:38:34 +00:00
SilentSpike
05996892df Parse markdown formatting of Osmose subtitles too 2020-02-15 13:04:47 +00:00
SilentSpike
af0e37f7c5 Add "view on osmose" link to UI footer 2020-02-15 11:48:01 +00:00
SilentSpike
d200d0fce2 Use Promise for improveOSM comments 2020-02-14 17:31:10 +00:00
SilentSpike
3ee32776a7 Fix QA error icons
Pass service itself in to QAItem constructor for purpose of fetching
data. Store string as `title` property on the service.
2020-02-12 21:27:38 +00:00
Bryan Housel
a9a1f945f8 Move the qa_data external
- this means that QAItem now asks the service for the icon rather than knowing it directly
2020-02-07 10:06:47 -05:00
Bryan Housel
fe00a40e9a Move the keepRight data extrnal 2020-02-07 09:16:34 -05:00
SilentSpike
f8a4a0b3ad Use d3_json Promise directly for Osmose requests 2020-02-07 11:29:48 +00:00
SilentSpike
8bb2dc7fa6 Return Promise for Osmose string requests 2020-02-07 11:21:33 +00:00
SilentSpike
f86837d637 Fix use of double quotes 2020-02-06 23:12:18 +00:00
SilentSpike
51efd5b714 Update and standardise QA implementations
- ES6ify (now using class syntax to define QAItem objects)
- Fix bug with KeepRight marker rendering not updating properly
- Use `qa-` prefix for the UI element classes to differentiate from iD
validation error related UI element classes
- Move away from "error" where possible in source
- Move away from snake_case naming where possible

Note that some function/method names have been untouched to make life
easier for v3 development. Have added note comments where appropriate.
2020-02-06 23:07:50 +00:00
SilentSpike
087867d5c8 Use Promises for Osmose issue detail requests
Also ES6ify the details script
2020-02-04 21:08:02 +00:00
SilentSpike
e6cf53dfe8 Fix use of test() method on color string 2020-02-04 12:05:36 +00:00
SilentSpike
ecadafb3e4 Use Osmose supplied hex colors 2020-02-03 23:20:45 +00:00
SilentSpike
cf878ca410 Use Object.keys() not Python {}.keys() 🤦‍♂️ 2020-02-03 23:20:45 +00:00
SilentSpike
2d2fa440c1 Use multiple specific Osmose string requests
- Only requesting the data we need (Osmose has many more issue types
than iD will ever display)
2020-02-03 23:20:45 +00:00
SilentSpike
06ac02f89f Use Osmose dynamic subtitile string
Providing a `langs` param that's currently not implemented so these will
all be English until that is done.
2020-02-03 23:20:45 +00:00
SilentSpike
e3c6f58624 Format markdown in Osmose strings appropriately 2020-02-03 23:20:44 +00:00
SilentSpike
010ca30999 Show more Osmose strings in the UI
Also only add sections where appropriate
2020-02-03 23:20:44 +00:00
SilentSpike
7a00c0a974 Use Osmose locale filter and detail strings 2020-02-03 23:20:44 +00:00
SilentSpike
5d93d3cace Prepare to use Osmose issue detail strings
- Remove translation description strings, will be using supplied
translations once the API is updated
- Change the way elements and details are presented since they can't be
easily integrated into the 3rd party description strings
2020-02-03 23:20:44 +00:00
SilentSpike
7d76950d55 Use Osmose translation strings for issue titles
This is just step one in the process while we wait for the API to supply
further strings and filtering to reduce the amount of string data
requested (since we don't need it all).

Strings are requested when the layer is first enabled and cached for the
current language (plus English as a backup).
2020-02-03 23:20:43 +00:00
SilentSpike
6310349a5a Use latest Osmose API tiles endpoint 2020-02-03 23:20:43 +00:00
SilentSpike
d2f9278fe2 Port changeset tag improvement to ImproveOSM QA
Also marked the `closed:` tags as readonly since these are filled in
automatically.

- Gives a count of each error type closed instead of making a list of
joined coordinates which quickly fills the maximum value length.
- This is more useful since a changeset already gives the area worked
on while these counts give insight into the type of changes made.
- Similar to iD own validation tags
2020-02-03 23:20:43 +00:00
SilentSpike
9fca611ec1 Add support for even more Osmose error types
- Conflicting tags
- Orthographic errors (excess whitespace and all capital names)
- Deprecated tagging
- Bad use of the "area" tag
2020-02-03 23:20:43 +00:00
SilentSpike
406264c37e Simplify structure of QA error data 2020-02-03 23:20:42 +00:00
SilentSpike
a53f1c0f67 Add support for Osmose unnecessary tag error type 2020-02-03 23:20:42 +00:00
SilentSpike
c13eb15691 Add support for more Osmose error types
- Unconnected level crossings
- Unconnected highway features/barries
- Unexpected punctuation/symbols in tag values
- Unbalanced parentheses/quotes in name values
- Invalid date formats
- Access tagging that permits all transport modes
- Elements with a "name" tag and no main tagging
- Relations missing a "type" value
2020-02-03 23:20:42 +00:00
SilentSpike
cc3039033f Support more subtypes of osmose error type 8300 2020-02-03 23:20:41 +00:00
SilentSpike
12206c68e6 Convert Osmsoe service to ES6 syntax 2020-02-03 23:20:41 +00:00