41 Commits

Author SHA1 Message Date
Martin Raifer
04f77be5bc fix KeepRight warnings showing up as "Unknown" issues (close #8925) 2022-02-07 10:42:36 +01:00
Martin Raifer
f990d5ac87 fix rendering of html of keepright issues 2022-02-02 18:55:33 +01:00
Martin Raifer
9f3f8e1366 rename method 2021-11-29 19:26:18 +01:00
Martin Raifer
d78c357588 replace raw html injection of localized texts
by using d3 to insert the localized text spans directly into the DOM
2021-11-26 18:51:45 +01:00
Quincy Morgan
481b80e5cb Fetch the parent relations when downloading a single entity, e.g. when launching iD with a feature selected (close #6731) 2020-11-10 10:00:44 -05:00
Quincy Morgan
21a49bbec8 Initial support for D3 v6.2.0 2020-10-06 15:08:39 -04:00
Quincy Morgan
118a91ea33 Make Q/A issue links focusable (re: #8004) 2020-10-01 11:36:46 -04:00
Quincy Morgan
df0b826386 Add lang attributes to some Q/A elements 2020-09-22 12:28:15 -04:00
Quincy Morgan
5435082d9c Revert t function to returning the plain string by default
Add `t.html` function for getting the string with the `lang` attribute
2020-09-22 12:03:29 -04:00
Quincy Morgan
32f8274929 Make t function return a span element with a lang attribute unless html: false is specified in the options (re: #7963)
Update `text` functions to `html` to support inserting the `span` elements
Specify `html: false` for various instances where a `span` is not desired, e.g. `placeholder` and `title` attributes
2020-09-15 21:56:22 -04:00
Quincy Morgan
60f7dc7c0b Replace presets property of context with singleton
Remove utilPreset
2020-04-01 13:08:45 -07:00
Quincy Morgan
a1af118f0e Ensure locales and presets are loaded before the UI loads (close #7406)
Consolidate localization behavior and init to a coreLocalizer function and singleton
Explicitly support `en-US` locale
Rename coreData to coreFileFetcher and export a singleton rather than using a property of coreContext
Add `apiConnections` property of coreContext to simplify adding a source switcher
Replace some init functions with re-callable, promise-supporting `ensureLoaded` functions
Make coreContext itself load the UI if a container has been specified at init time
Fix code tests
2020-03-31 12:23:31 -07:00
Bryan Housel
61c86a3527 Don't rely on the dataEn export for checking if a string exists
Instead use the special `default` key for supplying a fallback string
2020-02-20 17:11:47 -05:00
Quincy Morgan
614ee3f68e Use standard hover-highlighting mechanism for feature links in Q/A inspectors 2020-02-13 10:07:18 -08:00
Quincy Morgan
32d773caa7 Standardize some Q/A CSS 2020-02-12 16:00:29 -08:00
SilentSpike
51efd5b714 Update and standardise QA implementations
- ES6ify (now using class syntax to define QAItem objects)
- Fix bug with KeepRight marker rendering not updating properly
- Use `qa-` prefix for the UI element classes to differentiate from iD
validation error related UI element classes
- Move away from "error" where possible in source
- Move away from snake_case naming where possible

Note that some function/method names have been untouched to make life
easier for v3 development. Have added note comments where appropriate.
2020-02-06 23:07:50 +00:00
SilentSpike
947f9657db Port minor QoL tweaks to other QA services
Use of MouseEnter and MouseLeave is nicer for SVGs since it won't fire
multiple times (shouldn't happen hear anyway as only one element).

Triggering redraw after forcing related elements visible causes them to
render without having to pan manually.
2020-02-03 23:01:01 +00:00
Quincy Morgan
d01bb78707 Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys (close #6237) 2019-04-24 13:45:59 -07:00
Bryan Housel
ba44c80076 Force visible any entities related to a selected error
(closes #5880)
2019-02-10 23:29:49 -05:00
Bryan Housel
bb0a47b255 Remove kr and keepRight for styles used generically
(it was weird to see these classes in improveOSM components)
2019-02-07 10:35:50 -05:00
Bryan Housel
3fe6c0dbe7 Support more eased transitions, cleanup code
(re: #3967, #5169, #5407)
2019-01-16 13:42:32 -05:00
Bryan Housel
7f321abbaf Add links to the main error object in KeepRight error messages
re: https://github.com/openstreetmap/iD/issues/5679#issuecomment-452281850
2019-01-10 17:38:09 -05:00
Bryan Housel
d9015baa47 Improve links in KeepRight error messages
(re: #5679)

Also move the localizeable string dictionary to data/keepRight.json
2019-01-07 16:10:44 -05:00
Minh Nguyễn
3c82174f03 Capitalize first letter of KeepRight error detail 2019-01-05 00:32:45 -08:00
Bryan Housel
46ebce2d6f Fix error reporting urls and make sure sidebar not showing stale data 2019-01-03 11:37:14 -05:00
Bryan Housel
4494c3ab9c Fix comment box style, remove unused vars for eslint 2019-01-02 15:46:25 -05:00
Bryan Housel
9557c0204a Relax some more regex for tag parsing, (to support 'key=*')
Also implement parsing error 231 - layer conflict
2019-01-02 13:39:21 -05:00
Bryan Housel
d54d5bfd89 Move title into keepright error header 2018-12-29 17:55:40 -05:00
Bryan Housel
192b4da9e6 Fix the strings I broke in 3785ffb15 2018-12-29 17:30:35 -05:00
Bryan Housel
3785ffb154 Simplify translation strings 2018-12-22 12:12:28 -05:00
Bryan Housel
f7150004c0 Refactor things out of util with limited use, move more to service 2018-12-21 11:56:55 -05:00
Bryan Housel
2deadd5d6c Fix merge issues 2018-12-19 17:12:06 -05:00
Thomas Hervey
fbe3c94b01 updated: punctuation, some specialized QA error parsing 2018-12-19 13:45:14 -05:00
Thomas Hervey
d125c62c78 updated: variable and function names, html regex 2018-12-19 13:43:48 -05:00
Thomas Hervey
e0d5391f1b added: entity links within descriptions 2018-12-19 13:43:48 -05:00
Thomas Hervey
d095de08fe updated comment UI, added stub for POST; TODO: finish links & POST 2018-12-19 13:43:48 -05:00
Thomas Hervey
b5a316df48 fixed: svg icon placement 2018-12-19 13:43:08 -05:00
Thomas Hervey
1335549ad3 cleaned map data UI; commented sub-layer filtering 2018-12-19 13:43:08 -05:00
Thomas Hervey
805dd394c9 added link for object in header 2018-12-19 13:40:56 -05:00
Thomas Hervey
3e7146c63f WIP: menu with sub-layer buttons; TODO: bug fixes, ui updates, wiring buttons 2018-12-19 13:40:56 -05:00
Thomas Hervey
18278371aa WIP: identifying variables in errors 2018-12-19 13:38:40 -05:00