185 Commits

Author SHA1 Message Date
Martin Raifer
ac59197632 simplify raw tag editor ui and logic (#10889)
* always show empty line at bottom of the tag list to allow adding more tags (replaces `+` button and tab logic)
* disable delete and info buttons on empty tag
* replace deferring of tag change events and re-rendering with a simpler logic (to fix issues like #10871):
  only set input field values if the rendering event was triggered by an external event, or by a change of the respective field in the raw tag editor itself
* skip delete and tag info buttons while navigating using tab: makes it more quick to get to where one typically needs to, deleting a key using the keyboard only is possible by emptying the tag's key, and advanced users are not typically using the `i` button anyway
2025-05-12 18:21:55 +02:00
Martin Raifer
9b7a98862d Merge remote-tracking branch 'origin/housenumber-labels' into develop 2025-05-12 18:02:47 +02:00
Martin Raifer
39d2201e6e fix hover-highlight of changed features in upload dialog
fixes #10030
2025-05-06 11:17:53 +02:00
Martin Raifer
aa96a67c65 use lodash-es everywhere, replace custom clamp methods with lodash 2025-04-21 14:43:35 +02:00
Martin Raifer
666583d516 add hover text for relation labels in membership editor (#10942)
* append relation id as hovertext in membership editor as last-resort disambiguation in case multiple relations have otherwise the exact same label (and type)
* show regular relation label also as hover text, which is useful to see the full name in case it is cut off with an ellipisis (…) for long-ish labels
2025-04-17 12:52:32 +02:00
Mattia Pezzotti
d1e5c2910c add date slider for street level photos, and more (#10394)
full list of enhancements:

* year slider to filter photos by freshness
* toggle active streetlevel layers with shortcut `shift+P`
* hfov, pitch and direction is now held between sequences and images as asked in #10392
* fix for #10361 (only panoramax)
* added tests and jsdoc
* add ticks for existing photos on slider
* general bug fixes
* rudimentary support for toDate in date slider (only when iD is started with a "to" date in the hash parameter: show a second slider to visualize and set the "to" date)

---------

Co-authored-by: Martin Raifer <martin@raifer.tech>
2025-03-18 21:09:37 +01:00
Martin Raifer
68eb90f665 allow setting background adjustment sliders in 1% increments
closes #10289
2025-03-11 11:29:21 +01:00
Kyℓe Hensel
38d2ccd866 isHighwayIntersection only applies to nodes, so remove from osmEntity (#10831) 2025-03-04 11:29:29 +01:00
Kyℓe Hensel
bd85d31b73 fix relation membership list using a non-deterministic order (#10648) 2025-02-12 15:16:54 +01:00
Martin Raifer
51ee85f6f5 refresh text-mode raw tag editor also when no tags are changed
e.g. when duplicate tag keys are entered or the text input contained empty or invalid lines that need to be cleaned up
2025-01-31 17:34:42 +01:00
Deeptanshu Sankhwar
e48aa3c2c4 Ensure correct this context for addMembership function to call the blur method correctly. Fixes #10555 (#10560)
* Pass the  reference explicitly to the  function to ensure the correct context is available.

* refactor: handle blur() in a closure to separate UI logic from addMembership

* spacing

* Fixed typo

---------

Co-authored-by: Deeptanshu Sankhwar <deeptanshu@walletsocket.com>
Co-authored-by: Minh Nguyễn <mxn@1ec5.org>
2024-11-30 22:43:54 -08:00
Minh Nguyễn
6cfd1cf6fc Include route number in label of named route relations (#10478)
* iD#8707 Show ref in the name of route relations

* Avoid combining PTv2-formatted name with ref

* Pair name with other tags when labeling routes

---------

Co-authored-by: Kyle Hensel <k.y.l.e@outlook.co.nz>
2024-11-03 16:38:00 -08:00
Martin Raifer
945fea1dc0 allow to enter strings with quote marks in raw tag editor's text mode (#10371)
and use fully quoted strings for cases which have characters that need to be encoded

old: tag=foo\"bar\" -> new: tag=foo"bar" or tag="foo\"bar\""
old: tag=foo\nbar   -> new: tag="foo\nbar"

falls back to raw tag values if a quoted string cannot be parsed
2024-08-01 15:19:33 +02:00
Martin Raifer
e89121b550 fix vegbilder overlay from being overwritten by panoramax layer 2024-07-31 17:53:33 +02:00
arch0345
14794ee992 Remove references to ImproveOSM 2024-07-08 17:15:38 -07:00
Asif Sheriff
1683313621 preserve rows with empty tag values in raw tag editor (#10151) 2024-03-15 01:13:07 +01:00
Martin Raifer
d7111e20f5 add button to load a feature's relations fully (if incomplete), fixes #5420 2024-03-05 14:25:16 +01:00
Martin Raifer
0d69c3c9e8 style "(empty)" option differently to distinguish from regular tag values 2023-12-06 13:56:45 +01:00
Kyle Hensel
a876aa010c show empty tag values in multi-selections 2023-11-25 21:54:08 +13:00
Martin Raifer
ac172a2b0e Don't autocomplete tags like name_1 in raw tag editor, closes #9422 2023-11-17 14:04:24 +01:00
Martin Raifer
20b72a2b68 only render route colours if the value is a valid color
addresses https://github.com/openstreetmap/iD/pull/9424#discussion_r1046495633
2023-11-17 13:47:16 +01:00
Martin Raifer
beea585251 Merge branch 'develop' into relation-colours 2023-11-14 10:02:55 +01:00
Martin Raifer
c297d9bc18 fix name clash which was overriding an existing event handler
fixes #9829

fixes regression from d7902e1388
2023-08-11 15:11:25 +02:00
Martin Raifer
cf2e4c990e lint 2023-08-09 18:24:16 +02:00
Martin Raifer
471354af4f add list of loaded local photos 2023-08-08 17:12:35 +02:00
Martin Raifer
634ce10d24 add proper local photo strings, enable layer switcher checkbox 2023-08-07 16:14:32 +02:00
Martin Raifer
1572835a48 move local photos to "Photo Overlays" section 2023-08-07 11:52:33 +02:00
Martin Raifer
884874dedc Merge branch 'develop' into gsoc_2022/explore_iD 2023-08-07 10:38:10 +02:00
Martin Raifer
e8703e6bb6 Merge remote-tracking branch 'noenandre/vegbilder' into develop 2023-08-07 10:31:07 +02:00
Kyle Hensel
d01112372b don't suggest discardable tags in the raw tag editor 2023-08-06 15:07:35 +12:00
Martin Raifer
d7902e1388 only show regional street-level photo providers in the available region
and disable selection checkbox if not zoomed in enough to load the photos
2023-08-02 16:35:56 +02:00
Martin Raifer
43784e2eff take entity loc into account when resolving fields via parent preset, fixes #9524
this necessary when a regional preset (e.g. from NSI) is supposed to inherit fields from a parent preset, but the direct parent does NOT apply at the location of the entity to be added/edited. In that case we need to search for a potential regional variant of the parent preset.
2023-05-25 19:19:09 +02:00
Martin Raifer
bd98ff904b restrict taginfo suggestions in raw tag editor to ones which match the input string
this additinoal filtering is needed because of the caching performed by the services/taginfo.js module.
2023-05-16 17:10:30 +02:00
Martin Raifer
9779f320a8 Properly handle case sensitive tags in taginfo suggestion in raw tag editor, fixes #9640 2023-05-16 17:06:39 +02:00
Martin Raifer
4e3e942127 show (route) relation colours in lists and comboboxes 2022-12-12 22:49:50 +01:00
Martin Raifer
41aa127d23 reduce use of parseFloat
as it silently strips non-numeric suffixes (e.g. a value of "123 foo" is transformed into a numeric value of 123 by `parseFloat`, which is typically not what we desire)
2022-11-24 19:39:15 +01:00
Martin Raifer
a6be05966b improve comboboxes: (#9344)
* pressing return/enter doesn't deselect the entity anymore
* predefined ("static") field options are always listed in the combobox dropdown, even if taginfo doesn't include them (because of low usage)
* (raw) tag values can also be entered for localized strings
* static localized strings can be used before taginfo response is received (useful when taginfo is slow or unavailable)
* fixes some bugs which can be triggered when taginfo is slow
* fixes a bug where the autocomplete dropdown doesn't work properly when tags have "few" values
* multiCombo fields can be case-sensitive now
2022-11-08 12:09:06 +01:00
Martin Raifer
df1f755150 don't show empty tooltips in backgrounds list 2022-09-27 14:00:28 +02:00
Mukesh Jaiswal
1a3d8a6304 Refactor: removed console log 2022-09-12 16:41:30 +02:00
Mukesh Jaiswal
3ccc434c83 Refactor: working prototype, needs some error handling and translation 2022-09-12 13:41:19 +02:00
Mukesh Jaiswal
448c8b914c plop 2022-08-23 19:37:54 +02:00
mukesh
7a2ab8aeaa Draft: still in progress 2022-08-03 15:37:09 +02:00
mukesh
16280638b5 plop 2022-06-29 18:51:33 +02:00
Martin Raifer
7d546a8f60 refactor further modules to not rely on html injection 2022-06-24 19:31:41 +02:00
Martin Raifer
209cc23d92 don't inject html code in preset names 2022-06-24 19:11:00 +02:00
Martin Raifer
8bb1d39431 refactor validation modules to not inject html 2022-06-24 13:25:56 +02:00
Martin Raifer
28eae9ed87 refactor uiSections to not inject html 2022-06-24 11:45:54 +02:00
Martin Raifer
ac77289b4d refactor localized text rendering in tooltips, flash messages 2022-06-23 18:55:57 +02:00
Martin Raifer
422861dbc7 render background source labels as text, not html 2022-06-23 10:56:17 +02:00
Martin Raifer
9576e95d83 change label of ui fields from raw html to a callback function
fixes #9159
2022-06-23 10:49:38 +02:00