Bryan Housel
a873c0f2ca
Remove unused, add maprules documentation
2019-01-23 11:08:19 -05:00
Bryan Housel
2df39c1dc7
Escape all .s in imagery identifiers, not just the first one
...
(closes #5737 )
2019-01-19 10:53:09 -05:00
Quincy Morgan
11b2102761
Merge branch 'master' into validation
...
# Conflicts:
# data/core.yaml
# dist/locales/en.json
# modules/ui/commit_warnings.js
# modules/ui/entity_editor.js
# modules/util/index.js
# modules/util/util.js
# modules/validations/index.js
# modules/validations/many_deletions.js
# modules/validations/missing_tag.js
2019-01-14 10:13:56 -05:00
Bryan Housel
d9015baa47
Improve links in KeepRight error messages
...
(re: #5679 )
Also move the localizeable string dictionary to data/keepRight.json
2019-01-07 16:10:44 -05:00
Bryan Housel
826f66a91b
Unique values for key codes moved to utilKeybinding, uiShortcuts
...
This lets us supply lists of keys which might contain duplicates, but will be
made unique. For example: [t('sidebar.key'), '`', '²']
'sidebar.key' may be one of the other choices, but will be deduplicated.
2019-01-07 11:12:24 -05:00
Bryan Housel
7986fcbfbf
Merge branch 'keep-right_QA'
2019-01-04 21:37:19 -05:00
Tobias
5009edee4b
Move variable to the top of the file and reuse
...
As suggested in https://github.com/openstreetmap/iD/pull/5650#issuecomment-449589375
2018-12-23 07:38:00 +01:00
Tobias Jordans
c97b659a34
Allow locale and language being set via URL param
...
With the hash-url `locale=en-US` or `locale=de-DE` one can force a locale and language regardless of the given language from the osm-website-settings.
2018-12-22 19:10:50 +01:00
Bryan Housel
f7150004c0
Refactor things out of util with limited use, move more to service
2018-12-21 11:56:55 -05:00
Quincy Morgan
d58867df7c
Add entity display label util function
...
Condense message and tooltip text for for the untagged feature issue
Use lighter border color for error issues
2018-12-20 14:04:15 -05:00
Bryan Housel
2deadd5d6c
Fix merge issues
2018-12-19 17:12:06 -05:00
Thomas Hervey
ee00635cc4
updated: some error colors; fixed: error 320, 220
2018-12-19 13:45:15 -05:00
SilentSpike
1f7455fdad
Add missing error types 73, 74 and 75
2018-12-19 13:45:15 -05:00
SilentSpike
9bd772748a
Convert warnings to regex
...
These aren't shown in the layer currently, but for future use this
should work
2018-12-19 13:45:15 -05:00
SilentSpike
da23bf79a8
Fix parsing of error type 294
2018-12-19 13:45:15 -05:00
SilentSpike
005927dae3
Fix parsing of error type 211
2018-12-19 13:45:15 -05:00
SilentSpike
2b1e37ab78
Handle simple error descriptions explicitly
...
This adds a flag to the error schema to explicitly say whether to parse
the description with regex or not. Prevents us from having to escape
special characters in fixed strings and is a minor optimisation.
2018-12-19 13:45:15 -05:00
SilentSpike
e77d779173
Adhere to style guide for variables
2018-12-19 13:45:15 -05:00
SilentSpike
e0e48b7505
Fix parsing of error type 231
2018-12-19 13:45:15 -05:00
SilentSpike
a2fe431637
Add support for arbitrary number of details
2018-12-19 13:45:15 -05:00
SilentSpike
d054e9cf6b
Convert all error message schema to regex
2018-12-19 13:45:15 -05:00
SilentSpike
1527bbb043
Fix missing and unnecessary semicolons
2018-12-19 13:45:15 -05:00
SilentSpike
424bebf099
Convert preliminary amount of errors to regex
...
This focuses on converting error types I found on the map for testing
(can confirm the code is working!) as well as the more problematic cases
from the old code to show that this approach can handle them easily.
2018-12-19 13:45:15 -05:00
SilentSpike
bb89827ee7
Use regex group capture to extract error details
2018-12-19 13:45:15 -05:00
Thomas Hervey
fbe3c94b01
updated: punctuation, some specialized QA error parsing
2018-12-19 13:45:14 -05:00
Thomas Hervey
84895834f7
updated: punctuation and missing descriptions
2018-12-19 13:45:14 -05:00
Thomas Hervey
d125c62c78
updated: variable and function names, html regex
2018-12-19 13:43:48 -05:00
Thomas Hervey
ed34d522ff
updated: check entity type from second word as well
2018-12-19 13:43:48 -05:00
Thomas Hervey
e0d5391f1b
added: entity links within descriptions
2018-12-19 13:43:48 -05:00
Thomas Hervey
d095de08fe
updated comment UI, added stub for POST; TODO: finish links & POST
2018-12-19 13:43:48 -05:00
Thomas Hervey
1335549ad3
cleaned map data UI; commented sub-layer filtering
2018-12-19 13:43:08 -05:00
Thomas Hervey
805dd394c9
added link for object in header
2018-12-19 13:40:56 -05:00
Thomas Hervey
3e7146c63f
WIP: menu with sub-layer buttons; TODO: bug fixes, ui updates, wiring buttons
2018-12-19 13:40:56 -05:00
Thomas Hervey
18278371aa
WIP: identifying variables in errors
2018-12-19 13:38:40 -05:00
Max Grossman
e0e6f5b918
remove non-used util class
2018-12-17 12:52:21 -05:00
Max Grossman
c897331cd1
presets test w/build
2018-12-13 13:30:38 -05:00
Max Grossman
96e44be69c
merge 2.12.2
2018-12-13 11:22:32 -05:00
Bryan Housel
bee01d8497
Destroy all old background layer tooltips before making new ones
...
(closes #5551 )
2018-12-05 00:35:45 -05:00
Bryan Housel
c1b19e7c9e
Generate unique _id for each tooltip
...
This lets allows multiple tooltips around nested elements.
The previous code did a bunch of .selectAll('.tooltip') that would
break if it matched multiple tooltips.
2018-11-26 14:14:19 -05:00
Bryan Housel
e3f5aecda9
Remove dataSuggestions and utilSuggestNames
...
- dataSuggestions was just a reexport of the name-suggestion-index
- utilSuggestNames was a combobox fetcher function used only once by uiFieldLocalized
Doesn't need to be a util if it's only used once in the code
and the tests for it were not really that interesting
2018-11-20 21:27:32 -05:00
Bryan Housel
317a3be93b
Add tiler.getGeoJSON, useful for debugging tile settings
2018-11-14 14:22:10 -05:00
Bryan Housel
152022aec4
Use context.keybinding for keybindings that don't change
...
(closes #5487 )
2018-11-13 20:57:21 -05:00
Bryan Housel
bb30cbf555
Move lib/d3.keybinding.js -> util/keybinding.js
...
almost none of the original d3 "plugin" code remains
2018-11-13 13:42:09 -05:00
Bryan Housel
cef64b0751
Avoid requesting tiles from wrapped world
...
(closes #5485 )
2018-11-12 15:50:11 -05:00
Quincy Morgan
1161767932
Moves the entity highlighting function to util/util.js
...
Breaks out the code for getting a selector for entities and all their descendants into a generic function
Accounts for circular relations when recursively getting all relation member IDs
2018-10-26 18:39:01 -07:00
Max Grossman
0a31137c78
move maprules/mapcss to a service class
...
ref #remote-presets
2018-09-23 18:38:01 -04:00
Bryan Housel
80b583a6f0
WIP on feature deduplication across tile boundaries
...
It seems like the ids stored in the features are not reliable, so I'm trying
to generate ids
2018-08-22 23:16:31 -04:00
Max Grossman
8f9a281825
additional test tweaks
...
ref #remote-presets
2018-08-14 12:49:41 -04:00
Max Grossman
f168f85496
passing mapcss test w/out parser, use that on sever
...
ref #remote-presets
2018-08-10 09:16:59 -04:00
Max Grossman
3a0f8ddd09
infer geometries
...
ref #remote-presets
2018-08-08 13:21:35 -04:00
