Kyle Hensel
90c4241723
fix dependency cycle caused by utilDisplayLabel importing presetManager
2024-08-24 11:34:46 +10:00
Martin Raifer
8bb1d39431
refactor validation modules to not inject html
2022-06-24 13:25:56 +02:00
paulklie
ab96c3576f
#8419 memorial stolperstein are ignored for close node check ( #9089 )
2022-06-06 16:50:45 +02:00
Quincy Morgan
7b5df1bc40
Add lang attribute to issue fix labels (re: #7963 )
2020-09-22 17:48:35 -04:00
Quincy Morgan
aa9b44a0bf
Add the lang attribute to issue messages (re: #7963 )
2020-09-22 17:25:18 -04:00
Quincy Morgan
32f8274929
Make t function return a span element with a lang attribute unless html: false is specified in the options (re: #7963 )
...
Update `text` functions to `html` to support inserting the `span` elements
Specify `html: false` for various instances where a `span` is not desired, e.g. `placeholder` and `title` attributes
2020-09-15 21:56:22 -04:00
Quincy Morgan
0120b009fa
Take a graph parameter in utilDisplayLabel instead of the context
2020-04-01 13:29:17 -07:00
Quincy Morgan
a1af118f0e
Ensure locales and presets are loaded before the UI loads ( close #7406 )
...
Consolidate localization behavior and init to a coreLocalizer function and singleton
Explicitly support `en-US` locale
Rename coreData to coreFileFetcher and export a singleton rather than using a property of coreContext
Add `apiConnections` property of coreContext to simplify adding a source switcher
Replace some init functions with re-callable, promise-supporting `ensureLoaded` functions
Make coreContext itself load the UI if a container has been specified at init time
Fix code tests
2020-03-31 12:23:31 -07:00
Quincy Morgan
3e7ac18701
Use the lowest closeness threshold when flagging shared very close points ( close #7379 )
2020-02-24 11:53:16 -08:00
Quincy Morgan
d2c73f8a86
Restore fixes for very close vertices issues
2019-11-18 12:07:48 -05:00
Quincy Morgan
24c72b64d1
Load issue fixes dynamically instead of cacheing them ( close #7037 )
2019-11-13 14:35:01 -05:00
Quincy Morgan
c32cca2a71
Add additional comment to close nodes validation
2019-11-11 15:34:55 +01:00
Quincy Morgan
40edee1275
Don't flag very close nodes with different house or unit numbers ( close #6998 )
2019-11-11 13:40:37 +01:00
Quincy Morgan
d57807478e
Start validation documentation (re: #6100 )
...
Add subtypes to close_nodes and unsquare_way validations
2019-10-09 12:43:38 +02:00
Quincy Morgan
8003e7b3d3
Allow the layer and level tag to differentiate very close points ( close #6612 )
2019-07-05 10:17:15 -04:00
Quincy Morgan
1ed73b6531
Convert validation rules to validate against a specific graph, not always the current graph (re: #6459 )
2019-06-06 16:27:31 -04:00
Quincy Morgan
28db4df86b
Flag detached points that are very close together ( close #6394 )
...
Fix lint error
2019-05-22 15:50:20 -04:00
Quincy Morgan
e599488121
Lower the very close nodes warning threshold for buildings, building parts, and paths (re: #6374 )
...
Flag very close nodes in indoor features but with an extremely small threshold
2019-05-20 11:21:50 -04:00
Quincy Morgan
36a564f453
Add explicit check for very close nodes with an identical location
2019-05-10 12:14:29 -04:00
Quincy Morgan
8de10def2a
Use actionMergeNodes instead of operationMerge for the very close nodes issue fix ( close #6343 )
2019-05-10 09:12:11 -04:00
Quincy Morgan
58e6afd3ea
Don't flag very close nodes in boundaries
2019-05-09 17:50:22 -04:00
Quincy Morgan
399b9be006
Don't flag very close nodes in ways with too few nodes, indoor ways, and very small ways
2019-05-08 17:15:18 -04:00
Quincy Morgan
97cb90b562
Make issue messages dynamic ( close #6331 )
2019-05-07 14:48:30 -04:00
Quincy Morgan
fd35e10aa7
Make the very close nodes validation work for any way ( close #6326 )
2019-05-07 12:28:59 -04:00
Bryan Housel
59c34e2537
Perform orthagonalization fixes without a transition
...
We can just set `action.transitionable = false` to make the action instant.
Also removes the `onCompletion` handlers. They shouldn't really be needed,
because the validator will run after the fix is applied (and at other times).
2019-05-06 10:23:30 -04:00
Quincy Morgan
dbc3978d71
Add non-actionable fix recommendation to move very close points apart
2019-05-03 12:15:26 -07:00
Quincy Morgan
b1d00db874
Show very close node issues on the parent way as well as on the points themselves ( close #6304 )
2019-05-03 10:40:12 -07:00
Quincy Morgan
bfc944e30a
Fix two potential exceptions and one lint warning
2019-05-02 16:26:33 -07:00
Quincy Morgan
752bc72e7c
Fix issue where close nodes validation may not detect issues in some cases
2019-05-02 12:03:09 -07:00
Quincy Morgan
b4dacdad2a
Reduce very close nodes validation threshold ( close #6292 )
...
Use spherical distances for very close nodes validation
Don't flag very close nodes from different ways
Don't flag very close nodes if both have interesting tags
Update very close nodes validation reference string
2019-05-02 11:39:12 -07:00
Quincy Morgan
26f1e29072
Merge branch 'master' into ignoring-issues
...
# Conflicts:
# data/core.yaml
# dist/locales/en.json
2019-04-30 13:05:07 -07:00
Quincy Morgan
942d55a4bf
Update strings for duplicate node validation
...
Use routable highway tags for duplicate node validation instead of any highway tag
2019-04-30 10:18:22 -07:00
