CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-14 01:33:03 +00:00
Code Issues Packages Projects Releases Wiki Activity
16,273 Commits 2 Branches 0 Tags
develop
Commit Graph

53 Commits

Author SHA1 Message Date
Kyle Hensel
90c4241723 fix dependency cycle caused by utilDisplayLabel importing presetManager 2024-08-24 11:34:46 +10:00
Martin Raifer
8bb1d39431 refactor validation modules to not inject html 2022-06-24 13:25:56 +02:00
Martin Raifer
9f3f8e1366 rename method 2021-11-29 19:26:18 +01:00
Martin Raifer
d78c357588 replace raw html injection of localized texts 
by using d3 to insert the localized text spans directly into the DOM
 2021-11-26 18:51:45 +01:00
Quincy Morgan
dc8fd13586 Enable array-callback-return eslint rule 2020-10-23 13:47:09 -04:00
Quincy Morgan
7b5df1bc40 Add lang attribute to issue fix labels (re: #7963) 2020-09-22 17:48:35 -04:00
Quincy Morgan
aa9b44a0bf Add the lang attribute to issue messages (re: #7963) 2020-09-22 17:25:18 -04:00
Quincy Morgan
5435082d9c Revert t function to returning the plain string by default 
Add `t.html` function for getting the string with the `lang` attribute
 2020-09-22 12:03:29 -04:00
Quincy Morgan
32f8274929 Make t function return a span element with a lang attribute unless html: false is specified in the options (re: #7963) 
Update `text` functions to `html` to support inserting the `span` elements
Specify `html: false` for various instances where a `span` is not desired, e.g. `placeholder` and `title` attributes
 2020-09-15 21:56:22 -04:00
Quincy Morgan
a1c2b7f73d Support language-specific pluralization (re: #597, #4964) 2020-09-14 17:21:00 -04:00
Quincy Morgan
db9eed2434 Move the edit menu logic to uiInit 
Make context the first argument of operation objects
Add Paste operation to edit menu when opening the context menu on a blank area of the map (close #2508)
 2020-05-14 15:49:35 -04:00
Quincy Morgan
0120b009fa Take a graph parameter in utilDisplayLabel instead of the context 2020-04-01 13:29:17 -07:00
Quincy Morgan
a1af118f0e Ensure locales and presets are loaded before the UI loads (close #7406) 
Consolidate localization behavior and init to a coreLocalizer function and singleton
Explicitly support `en-US` locale
Rename coreData to coreFileFetcher and export a singleton rather than using a property of coreContext
Add `apiConnections` property of coreContext to simplify adding a source switcher
Replace some init functions with re-callable, promise-supporting `ensureLoaded` functions
Make coreContext itself load the UI if a container has been specified at init time
Fix code tests
 2020-03-31 12:23:31 -07:00
Quincy Morgan
1041f89716 Fix line continuing 2020-03-16 13:43:24 -07:00
Quincy Morgan
9d936b4aea Rename rendererMap.editable function to more precise rendererMap.editableDataEnabled 
Make coreContext.editable function also account for whether user is in modeSave
 2019-12-12 16:06:28 -05:00
Quincy Morgan
e791b7514c Use existing vertices for "add a bridge/tunnel" endpoints if the edge is too short to add a new vertex (re: #7055) 
Avoid creating very short edges from splitting too close to another node when adding a bridge or tunnel via fix
Fix possible "entity not found" error
 2019-11-20 15:44:14 -05:00
Quincy Morgan
24c72b64d1 Load issue fixes dynamically instead of cacheing them (close #7037) 2019-11-13 14:35:01 -05:00
Quincy Morgan
abd94a940f Show non-actionable "Connect this feature" fix for disconnected roads and paths with both ends as noexits 
Correctly reverse the "continue" fix icons for the right-to-left layout
 2019-10-11 17:04:45 +02:00
Quincy Morgan
a3d6097d40 Rename "Fix Me" Requests validation rule to more general Help Requests 
Add subtypes to almost_junction and disconnected_way validation rules
Add additional validation documentation (re: #6100)
 2019-10-09 15:00:28 +02:00
Quincy Morgan
1abcc7fccf Show warning for elevator nodes that are disconnected from the highway network (close #6812) 
Simplify disconnected way validation code
 2019-09-13 15:17:48 -04:00
Quincy Morgan
1ed73b6531 Convert validation rules to validate against a specific graph, not always the current graph (re: #6459) 2019-06-06 16:27:31 -04:00
Quincy Morgan
e697bdbeb1 Flag disconnected ferry routes 
Flag disconnected highway multipolygon outer member ways
Let routing islands cross ferry routes
 2019-05-17 00:15:53 -04:00
Quincy Morgan
07bc2821cd Flag entire routing islands as single issues 2019-05-16 22:40:25 -04:00
Quincy Morgan
73467d53b4 Don't flag highways connected to amenity=parking_entrance nodes as disconnected 
Don't flag oneways with entrance endpoints as impossible
 2019-05-07 14:55:57 -04:00
Quincy Morgan
97cb90b562 Make issue messages dynamic (close #6331) 2019-05-07 14:48:30 -04:00
Bryan Housel
59c34e2537 Perform orthagonalization fixes without a transition 
We can just set `action.transitionable = false` to make the action instant.
Also removes the `onCompletion` handlers. They shouldn't really be needed,
because the validator will run after the fix is applied (and at other times).
 2019-05-06 10:23:30 -04:00
Bryan Housel
77801a3ecd Merge pull request #6284 from Bonkles/id-5869 
Improve validation for disconnected highways #5869
 2019-05-05 22:17:12 -04:00
Quincy Morgan
4afd071a00 Add "Connect this feature" fix to disconnected ways if continuing drawing isn't possible 2019-05-03 12:59:18 -07:00
Quincy Morgan
bfc944e30a Fix two potential exceptions and one lint warning 2019-05-02 16:26:33 -07:00
Quincy Morgan
ba9fd58fa9 Don't flag roads connected only to ferry routes as disconnected (close #6287) 
Use common routable highway tag list for disconnected way check
 2019-05-02 14:49:27 -07:00
Benjamin Clark
ec01933d84 Disconnected highways will now be warning flagged only if unattached to existing highways. 2019-05-01 17:42:23 -04:00
Quincy Morgan
375779882d Add ability to ignore warnings 
Replace issue's array of entities with array of entity IDs
Improve issue ID hashing
 2019-04-29 17:52:32 -07:00
Quincy Morgan
59bd6194e0 Add "autofix" for the unsquare building validation 2019-04-26 14:56:39 -07:00
Quincy Morgan
d01bb78707 Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys (close #6237) 2019-04-24 13:45:59 -07:00
Bryan Housel
61da61d7fd Add missing button arg to modeDrawLine, ensure using current entities 2019-04-22 20:00:53 -04:00
Bryan Housel
2ebbb68604 Restore tooltips on rule checkboxes, separate 'tip' and 'reference' 
Reference will show on clicking info button, and can contain more
useful information than a tooltip can.
 2019-04-19 13:24:55 -04:00
Bryan Housel
01d2e3eaf3 Replace validator tooltip with reference function, add tag diff 2019-04-16 17:07:53 -04:00
Bryan Housel
9100ce3ee4 Don't validate vertices which extend beyond the downloaded map 
(closes #5938)
 2019-04-10 13:40:06 -04:00
Bryan Housel
6508edf820 Avoid anonymous functions as validators 
Givnig them names makes it easier to understand in the profiler
 2019-04-05 09:50:22 -04:00
Quincy Morgan
f114945628 Flag disconnected highway areas and multipolygons (close #6075) 
Don't flag highways connected only to highway multipolygons
 2019-03-21 10:13:59 -04:00
Quincy Morgan
fc7cc3177d Make conditions for being able to delete features via quick fixes the same as for the delete operation (close #6062) 
Simplify some validation code
 2019-03-19 12:39:41 -04:00
Quincy Morgan
2d6c49b92b Ignore proposed features for crossings ways, almost junction, and disconnected way validations (close #5922) 2019-02-21 10:14:25 -05:00
Quincy Morgan
708c5e8155 Fix crash when undoing an added line past the first node 2019-02-19 12:10:05 -05:00
Quincy Morgan
794e953d43 Don't suggest continuing a disconnected highway from endpoints that have noexit=yes 2019-02-19 08:40:49 -05:00
Quincy Morgan
1821c3e955 Update fixes UI for icons, link styling, and non-actionable fixes 
Fix several bugs
 2019-02-14 15:56:04 -05:00
Bryan Housel
c86f11c359 Don't suggest extending disconnected line if it is closed 
Extend at start/end doesn't make sense in this situation
 2019-02-14 14:09:44 -05:00
Bryan Housel
14896b0ce5 Documentation, and move validation type up to top of each file 2019-02-12 16:07:08 -05:00
Bryan Housel
251a83ff7a Nitpicky code formatting stuff 
- no multiline var declaration
- squish together and alphabatize imports
- linebreaks for readability
 2019-02-11 13:55:58 -05:00
Quincy Morgan
47ec58e5fc Don't zoom to the end vertex when continuing a disconnected highway if it is already visible 
Add separate fixes for continuing a disconnected highway from the start and end vertices
Highlight the vertex that will be continued
 2019-02-11 11:29:34 -05:00
Quincy Morgan
d3946894e8 Standardize deprecated_tag and missing_tag rule type ids 
Run crossing_ways before disconnected_way
Break out crossing_ways issue creation into a separate function
 2019-02-04 16:29:29 -05:00