Martin Raifer
bd71ccba17
fix false positive "unreachable oneway" validation cased by oneway=-1
...
fixes #11068
2025-05-27 14:44:51 +02:00
Kyℓe Hensel
4747ae253c
refactor isOneWay to properly support bidirectional ways ( #10730 )
2025-02-12 14:22:09 +01:00
Kyle Hensel
90c4241723
fix dependency cycle caused by utilDisplayLabel importing presetManager
2024-08-24 11:34:46 +10:00
Martin Raifer
8bb1d39431
refactor validation modules to not inject html
2022-06-24 13:25:56 +02:00
Martin Raifer
9f3f8e1366
rename method
2021-11-29 19:26:18 +01:00
Martin Raifer
d78c357588
replace raw html injection of localized texts
...
by using d3 to insert the localized text spans directly into the DOM
2021-11-26 18:51:45 +01:00
Quincy Morgan
380473033b
Enable no-duplicate-imports eslint rule
2020-10-23 12:02:37 -04:00
Quincy Morgan
80eb197212
Merge pull request #7752 from peternewman/patch-6
...
Fix a lot of typos and initial codespell action run
2020-10-05 14:02:19 -04:00
Quincy Morgan
7b5df1bc40
Add lang attribute to issue fix labels (re: #7963 )
2020-09-22 17:48:35 -04:00
Quincy Morgan
aa9b44a0bf
Add the lang attribute to issue messages (re: #7963 )
2020-09-22 17:25:18 -04:00
Quincy Morgan
5435082d9c
Revert t function to returning the plain string by default
...
Add `t.html` function for getting the string with the `lang` attribute
2020-09-22 12:03:29 -04:00
Quincy Morgan
a3549f9a76
Merge branch 'develop' into lang-attributes
...
# Conflicts:
# modules/ui/commit_warnings.js
# modules/ui/field.js
# modules/ui/fields/wikidata.js
# modules/ui/fields/wikipedia.js
# modules/ui/full_screen.js
# modules/ui/panels/history.js
# modules/ui/sections/entity_issues.js
# modules/ui/sections/map_features.js
# modules/ui/sections/raw_member_editor.js
# modules/ui/sections/validation_rules.js
# modules/ui/tag_reference.js
2020-09-22 10:55:07 -04:00
Quincy Morgan
79688ce2d9
Show count and use plural forms for more operation strings (re: #8014 )
2020-09-22 09:10:49 -04:00
Quincy Morgan
32f8274929
Make t function return a span element with a lang attribute unless html: false is specified in the options (re: #7963 )
...
Update `text` functions to `html` to support inserting the `span` elements
Specify `html: false` for various instances where a `span` is not desired, e.g. `placeholder` and `title` attributes
2020-09-15 21:56:22 -04:00
Peter Newman
2c47a11008
Fix the seemingly safe spellings found by codespell
...
Untested, only checked by inspection.
2020-06-28 23:06:44 +01:00
Quincy Morgan
0120b009fa
Take a graph parameter in utilDisplayLabel instead of the context
2020-04-01 13:29:17 -07:00
Quincy Morgan
a1af118f0e
Ensure locales and presets are loaded before the UI loads ( close #7406 )
...
Consolidate localization behavior and init to a coreLocalizer function and singleton
Explicitly support `en-US` locale
Rename coreData to coreFileFetcher and export a singleton rather than using a property of coreContext
Add `apiConnections` property of coreContext to simplify adding a source switcher
Replace some init functions with re-callable, promise-supporting `ensureLoaded` functions
Make coreContext itself load the UI if a container has been specified at init time
Fix code tests
2020-03-31 12:23:31 -07:00
Quincy Morgan
1041f89716
Fix line continuing
2020-03-16 13:43:24 -07:00
Quincy Morgan
9d936b4aea
Rename rendererMap.editable function to more precise rendererMap.editableDataEnabled
...
Make coreContext.editable function also account for whether user is in modeSave
2019-12-12 16:06:28 -05:00
Quincy Morgan
24c72b64d1
Load issue fixes dynamically instead of cacheing them ( close #7037 )
2019-11-13 14:35:01 -05:00
Quincy Morgan
abd94a940f
Show non-actionable "Connect this feature" fix for disconnected roads and paths with both ends as noexits
...
Correctly reverse the "continue" fix icons for the right-to-left layout
2019-10-11 17:04:45 +02:00
Quincy Morgan
d7bde50649
Locate impossible way issues at the questionable node, not at the center of the way's extent
2019-10-10 15:08:54 +02:00
Quincy Morgan
1ed73b6531
Convert validation rules to validate against a specific graph, not always the current graph (re: #6459 )
2019-06-06 16:27:31 -04:00
Quincy Morgan
e697bdbeb1
Flag disconnected ferry routes
...
Flag disconnected highway multipolygon outer member ways
Let routing islands cross ferry routes
2019-05-17 00:15:53 -04:00
Quincy Morgan
fd8f460739
Don't flag oneway highways that connect to highway areas or ferry routes as impossible
...
Don't flag oneway waterways that connect to springs, storm drains, water bodies, or coastlines as impossible
2019-05-08 15:36:37 -04:00
Quincy Morgan
73467d53b4
Don't flag highways connected to amenity=parking_entrance nodes as disconnected
...
Don't flag oneways with entrance endpoints as impossible
2019-05-07 14:55:57 -04:00
Quincy Morgan
97cb90b562
Make issue messages dynamic ( close #6331 )
2019-05-07 14:48:30 -04:00
Quincy Morgan
0a71fd1e4f
Fix false positive for impossible oneway when connected way is circular
2019-05-02 12:18:21 -07:00
Quincy Morgan
375779882d
Add ability to ignore warnings
...
Replace issue's array of entities with array of entity IDs
Improve issue ID hashing
2019-04-29 17:52:32 -07:00
Quincy Morgan
ecc217f5d8
Add validation rule to flag impossible oneway highways and waterways ( close #6216 )
2019-04-26 12:04:43 -07:00
