38 Commits

Author SHA1 Message Date
Kyle Hensel
90c4241723 fix dependency cycle caused by utilDisplayLabel importing presetManager 2024-08-24 11:34:46 +10:00
Martin Raifer
41aa127d23 reduce use of parseFloat
as it silently strips non-numeric suffixes (e.g. a value of "123 foo" is transformed into a numeric value of 123 by `parseFloat`, which is typically not what we desire)
2022-11-24 19:39:15 +01:00
Martin Raifer
8bb1d39431 refactor validation modules to not inject html 2022-06-24 13:25:56 +02:00
Martin Raifer
9f3f8e1366 rename method 2021-11-29 19:26:18 +01:00
Martin Raifer
d78c357588 replace raw html injection of localized texts
by using d3 to insert the localized text spans directly into the DOM
2021-11-26 18:51:45 +01:00
Bryan Housel
9f30ebf551 Adjust verbose utilDisplayLabel call, use for more validation messages
(re: https://github.com/osmlab/name-suggestion-index/issues/4543#issuecomment-794527259)
2021-03-10 10:30:57 -05:00
Bryan Housel
f87c2d9357 Allow validators to return provisional results, revalidate after delay
Also add a ton of commments to validator.js
2021-01-27 10:38:48 -05:00
Quincy Morgan
7b5df1bc40 Add lang attribute to issue fix labels (re: #7963) 2020-09-22 17:48:35 -04:00
Quincy Morgan
aa9b44a0bf Add the lang attribute to issue messages (re: #7963) 2020-09-22 17:25:18 -04:00
Quincy Morgan
5435082d9c Revert t function to returning the plain string by default
Add `t.html` function for getting the string with the `lang` attribute
2020-09-22 12:03:29 -04:00
Quincy Morgan
a3549f9a76 Merge branch 'develop' into lang-attributes
# Conflicts:
#	modules/ui/commit_warnings.js
#	modules/ui/field.js
#	modules/ui/fields/wikidata.js
#	modules/ui/fields/wikipedia.js
#	modules/ui/full_screen.js
#	modules/ui/panels/history.js
#	modules/ui/sections/entity_issues.js
#	modules/ui/sections/map_features.js
#	modules/ui/sections/raw_member_editor.js
#	modules/ui/sections/validation_rules.js
#	modules/ui/tag_reference.js
2020-09-22 10:55:07 -04:00
Quincy Morgan
79688ce2d9 Show count and use plural forms for more operation strings (re: #8014) 2020-09-22 09:10:49 -04:00
Quincy Morgan
32f8274929 Make t function return a span element with a lang attribute unless html: false is specified in the options (re: #7963)
Update `text` functions to `html` to support inserting the `span` elements
Specify `html: false` for various instances where a `span` is not desired, e.g. `placeholder` and `title` attributes
2020-09-15 21:56:22 -04:00
Quincy Morgan
0120b009fa Take a graph parameter in utilDisplayLabel instead of the context 2020-04-01 13:29:17 -07:00
Quincy Morgan
a58abe3c6f Move localStorage interface from a property of coreContext to a corePreferences function 2020-04-01 11:00:48 -07:00
Quincy Morgan
a1af118f0e Ensure locales and presets are loaded before the UI loads (close #7406)
Consolidate localization behavior and init to a coreLocalizer function and singleton
Explicitly support `en-US` locale
Rename coreData to coreFileFetcher and export a singleton rather than using a property of coreContext
Add `apiConnections` property of coreContext to simplify adding a source switcher
Replace some init functions with re-callable, promise-supporting `ensureLoaded` functions
Make coreContext itself load the UI if a container has been specified at init time
Fix code tests
2020-03-31 12:23:31 -07:00
Quincy Morgan
03cea6435a Update unsquare way fix annotations 2019-12-12 17:02:55 -05:00
Quincy Morgan
24c72b64d1 Load issue fixes dynamically instead of cacheing them (close #7037) 2019-11-13 14:35:01 -05:00
Quincy Morgan
d57807478e Start validation documentation (re: #6100)
Add subtypes to close_nodes and unsquare_way validations
2019-10-09 12:43:38 +02:00
Quincy Morgan
b10ae96d62 Don't suggest adding nonsquare=yes to physically unsquare buildings (close #6332) 2019-06-16 18:47:32 -04:00
Quincy Morgan
1ed73b6531 Convert validation rules to validate against a specific graph, not always the current graph (re: #6459) 2019-06-06 16:27:31 -04:00
Quincy Morgan
460f136819 Lower default threshold for unsquare building detection to 5 degrees
Use the detection threshold for the action when fixing unsquare buildings
Don't disallow unsquare autofixing based on maximum angle
Disallow unsquare autofixing for features with wikidata tags
Don't toggle rule when selecting degree threshold field in Safari
Apply the change when pressing enter in the degree threshold field
Select the input when clicking the degree threshold field
Use the min or max threshold instead of the default when an input is out of bounds
2019-05-20 15:48:01 -04:00
Bryan Housel
511f8ecc82 Allow user to adjust the threshold for the unsquare building warning 2019-05-18 15:44:29 -04:00
Quincy Morgan
a9c30e840c Revalidate immediately after running most fixes (close #6354)
Allow individual fixes to control revalidation
Don't allow fixes to run within a second of running any fix for that issue
2019-05-14 14:41:07 -04:00
Quincy Morgan
4eedfa8b25 Don't allow autofixing unsquare buildings unless they are already very close to square
Allow autofixing buildings with tags
2019-05-13 16:28:08 -04:00
Quincy Morgan
ad744a75ef Use "nonsquare" instead of "nosquare" for marking unsquare ways as physically unsquare (re: #6332) 2019-05-09 19:11:11 -04:00
Quincy Morgan
7b441ab766 Don't flag unsquare buildings connected to building multipolygons 2019-05-09 18:06:40 -04:00
Quincy Morgan
0e7a63f5c5 Add quick fix to unsquare way validation to tag a way as having unsquare corners (close #6332) 2019-05-09 12:04:18 -04:00
Quincy Morgan
97cb90b562 Make issue messages dynamic (close #6331) 2019-05-07 14:48:30 -04:00
Bryan Housel
7551dd9093 fix typo 2019-05-06 13:04:00 -04:00
Bryan Housel
e3ea4b8484 Additional improvements to unsquare_way validation
(re: #6288)

- use default params for actionOrthogonalize, not relaxed epsilon
- only allow autofix if there are no extra tags on the building (e.g. source)
2019-05-06 12:58:40 -04:00
Bryan Housel
4608e9598c Adjust thresholds for unsquare_way detection
(re: #6288)

I'd like to keep the angle threshold the same as what the action does
for UI consistency, but use a larger epsilon, so that fewer nearly-orthogonal
errors are reported.

With previous constants, it was strange that very orthogonal buildings
were being flagged, and very not-orthogonal buildings were not.
2019-05-06 11:42:57 -04:00
Bryan Housel
59c34e2537 Perform orthagonalization fixes without a transition
We can just set `action.transitionable = false` to make the action instant.
Also removes the `onCompletion` handlers. They shouldn't really be needed,
because the validator will run after the fix is applied (and at other times).
2019-05-06 10:23:30 -04:00
Quincy Morgan
375779882d Add ability to ignore warnings
Replace issue's array of entities with array of entity IDs
Improve issue ID hashing
2019-04-29 17:52:32 -07:00
Quincy Morgan
59bd6194e0 Add "autofix" for the unsquare building validation 2019-04-26 14:56:39 -07:00
Quincy Morgan
b30c91828f Don't flag buildings with lots of nodes or buildings connected to other buildings as unsquare (re: #6215) 2019-04-24 14:52:41 -07:00
Quincy Morgan
d01bb78707 Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys (close #6237) 2019-04-24 13:45:59 -07:00
Quincy Morgan
34fcd01f98 Add validation warning for unsquare buildings 2019-04-23 15:50:52 -07:00