Quincy Morgan
1bfb9ac0c0
Updated almost junction issue message and tooltip to be better aligned with other issues
...
Added a quick fix for setting the almost junction node as noexit
2019-01-16 10:02:05 -05:00
Quincy Morgan
11b2102761
Merge branch 'master' into validation
...
# Conflicts:
# data/core.yaml
# dist/locales/en.json
# modules/ui/commit_warnings.js
# modules/ui/entity_editor.js
# modules/util/index.js
# modules/util/util.js
# modules/validations/index.js
# modules/validations/many_deletions.js
# modules/validations/missing_tag.js
2019-01-14 10:13:56 -05:00
Xiaoming Gao
ecacab3ffe
add validation for almost junction
...
but avoid connect when the edge goes in parallel to the other road.
also added tests for the validation.
2019-01-08 15:44:55 -05:00
Bryan Housel
6c5ea96ab6
Adjust generic name validation to better check tag values
...
e.g. "name=Fast Food" should match "amenity=fast_food"
2019-01-08 13:43:40 -05:00
Bryan Housel
5f20218f1f
Add validation warning for generic names
...
(closes #5590 )
2019-01-08 02:15:28 -05:00
Quincy Morgan
70d5529a58
Added initial implementation of quick fix for connecting crossing features (still has some bugs)
2018-12-21 17:39:20 -05:00
Quincy Morgan
90bc7bf6a5
Changed crossing ways issue severity from error to warning
2018-12-21 17:21:29 -05:00
Andrew Wong
958d918bbe
Merge pull request #5639 from wonga00/more_tests
...
Added more validation tests
2018-12-21 16:49:11 -05:00
Quincy Morgan
67e585e4c5
Crossing ways issues now use the relevant parent relation when the offending way itself does not have relevant tags
2018-12-21 16:10:48 -05:00
Quincy Morgan
c593bb3475
The issue id now accounts for all entities
2018-12-21 14:51:18 -05:00
Quincy Morgan
d9c6bd1f39
Added specialized issue messages for the common types of way crossing issues
...
Fixed several linting issues involving crossing way validations
2018-12-21 14:45:20 -05:00
Xiaoming Gao
5f333267f4
Merge pull request #5645 from gaoxm/improveCrossWayCheck
...
Improve cross way check
2018-12-21 14:16:47 -05:00
Quincy Morgan
dc3a42f33d
Fixed validation-related linting errors
2018-12-21 14:08:35 -05:00
Xiaoming Gao
dee005e9aa
Improve cross way check
...
1. Add more way types and relation types to check
2. Add more legit crossing cases
3. Add tests for 1 and 2
2018-12-21 14:00:31 -05:00
Quincy Morgan
627b4ee732
Fixed an bug where the wrong feature could be deleted from the untagged feature issue fix
2018-12-21 14:00:08 -05:00
Quincy Morgan
c9350c632e
Add issue fixes UI
...
Add two issue fixes for untagged feature
2018-12-21 12:31:33 -05:00
Andrew Wong
67bab7aecf
don't import all of d3
2018-12-20 16:31:32 -05:00
Andrew Wong
5971bbebb7
Added more validation tests
2018-12-20 15:39:26 -05:00
Quincy Morgan
d58867df7c
Add entity display label util function
...
Condense message and tooltip text for for the untagged feature issue
Use lighter border color for error issues
2018-12-20 14:04:15 -05:00
Quincy Morgan
d7ef2de073
Re-organizes issue messages and tooltips
2018-12-20 12:16:54 -05:00
Xiaoming Gao
a4e1012c91
add crossing_way validation
...
Tests are also added and passed.
One thing to note: I had to add the tree() function to history so that I can
use the tree in the test; hope that's fine.
2018-12-19 19:23:35 -05:00
Andrew Wong
6e749c70ef
listening to user generated history changes for validation
2018-12-19 17:28:34 -05:00
Quincy Morgan
490143d1a8
Added Issues section to the entity sidebar
...
Fixed bug where stale issues would stick around in the issues pane
2018-12-19 16:12:33 -05:00
Quincy Morgan
59b0252b0e
Fixed several linting errors
2018-12-19 13:22:48 -05:00
Quincy Morgan
6a931f9be6
Added colors to issue list icons
...
Corrected icon for warnings
Made disconnected_highway issue a warning instead of an error
2018-12-19 13:07:47 -05:00
Quincy Morgan
ff95e6a337
Merge branch 'validationIssueDataModel' into validation
2018-12-19 10:59:45 -05:00
Quincy Morgan
903cb63efe
Renamed validations to issues in relevant places
...
Made the issue pane get the issues from the issue manager rather than validating itself
2018-12-19 10:41:58 -05:00
Xiaoming Gao
07a53fe6ea
Extend data model for validation issues
...
Add the Issues pane
1. Add a class to represent the validation issue
2. Extend the data model for an validation issue to
(1) add a severity level field (useful for identify save-blocking issues later)
(2) replace single entity with an array of entities (useful for issues involving multiple entities)
(3) add a coordinates field for highlighting the location of the issue on the map
(4) add a fixes field for possible automatic fixes
3. Update existing validation modules to use the new data model
2018-12-19 10:37:32 -05:00
Quincy Morgan
0d0521c936
Moved feature applicability into the issue manager class
2018-12-19 10:32:14 -05:00
Quincy Morgan
161311faa5
Merge pull request #5626 from wonga00/wonga_issue_manager
...
added IssueManager
2018-12-18 18:05:40 -05:00
Quincy Morgan
858a9606d5
Added entity display name or preset name to the disconnected highway message
2018-12-18 18:05:27 -05:00
Andrew Wong
30f25c6e8d
added IssueManager
...
- IssueManager performs validation on the current graph and also
stores the issues and notifies listeners when the issues changed
2018-12-18 17:52:23 -05:00
Bryan Housel
5a2049b421
Drop extra whitespace, make sure service exists before using it
2018-12-18 15:38:53 -05:00
Max Grossman
0a31137c78
move maprules/mapcss to a service class
...
ref #remote-presets
2018-09-23 18:38:01 -04:00
Max Grossman
f168f85496
passing mapcss test w/out parser, use that on sever
...
ref #remote-presets
2018-08-10 09:16:59 -04:00
Bryan Housel
184e37253c
Allow tourism=artwork on line geometry
...
And when used on a line, silence `tag_suggests_area` warning
(closes #5206 )
2018-08-05 23:37:06 -04:00
Max Grossman
b93444de75
working on isArea-ish equivalent for mapcss selector objects
...
ref #remote-presets
2018-08-02 18:03:13 -04:00
Max Grossman
5b1dee3779
add tests for mapcss checks
...
ref #remote-presets
2018-08-02 12:47:47 -04:00
Max Grossman
2bf5eaf6e7
initial plumbing for iD validation errors
...
ref #remote-presets
2018-07-31 14:22:34 -04:00
Max Grossman
db78df55c8
get validaiton objects on context
...
ref #remote-presets
2018-07-31 13:41:24 -04:00
Benoit Costamagna
8e85fe847f
correcting build issues
2018-01-29 13:20:50 +01:00
Benoit Costamagna
45b74d8730
Added difference between ways and areas
2018-01-29 13:10:39 +01:00
Benoit Costamagna
70a70ae906
very small optimization
2018-01-29 12:55:16 +01:00
Benoit Costamagna
8831ac18c9
Added more details to the warning when many elements are deleted
2018-01-29 12:50:50 +01:00
Bryan Housel
eb5d00bcc3
Convert lodah-es and d3 to named imports for validations
2017-09-25 23:36:28 -04:00
Bryan Housel
660511ec66
Add a validation warning about creating old-style multipolygons
...
(closes #3933 )
2017-05-04 12:30:58 -04:00
Bryan Housel
0e788717c5
Do not warn if path is connected to entrance
...
(closes #3906 )
2017-03-17 14:40:55 -04:00
Bryan Housel
3b46f1c83f
Warn on untagged relations
...
(re #3812 )
2017-02-01 14:41:41 -05:00
Bryan Housel
e9e442e998
Add a disconnected highway validation
...
(closes #3786 )
2017-01-23 16:50:31 -05:00
Bryan Housel
3102a4ae6a
Rename all the things to include pseudonamespaces
2016-10-04 19:06:20 -04:00
