33 Commits

Author SHA1 Message Date
Martin Raifer
afce723b74 only consider proper lifecycle tagging in "past/futures" layer (#10943)
fixes #10186, where features with e.g. `intermittent=yes` were incorrectly sorted into the past/futures layer

now only features with correct tagging are included in the "past/futures" layer:
* either the "legacy" lifecycle tagging (e.g. `highway=construction`)
* or proper lifecycle prefix tags (e.g. `disused:shop=convenience`)
2025-04-17 12:47:10 +02:00
Dimitar
b2fc4a43c0 Consider lifecycle prefixed tags in Future/Past features (#10228)
and sharpen landuse filter
2024-06-05 14:47:19 +02:00
Bryan Housel
33fab5580b Before calling init() make sure the assetPath is set
init kicks off building the ui, which can fetch spritesheets for the <defs>
The assetPath needs to be set otherwise these files will not be found
2021-08-16 22:06:42 -04:00
James Kingdom
316bd62764 Make tests pass 2020-04-28 22:17:48 +01:00
Quincy Morgan
c893147e15 Convert some element ids to classes to avoid collisions when embedding iD 2020-03-20 13:53:17 -07:00
Bryan Housel
e19bcb77d5 Require init() call before coreContext starts doing things
(closes #7304)
2020-01-29 19:27:12 -05:00
Quincy Morgan
94a47f05de Add tests for the indoor, piste, and aerialway map feature categories 2019-05-24 11:02:45 -04:00
Quincy Morgan
2232d7dadf Fix code tests 2019-05-22 11:59:48 -04:00
Bryan Housel
f6708fd84c Hide feature if _all_ rules hidden (was: if _any_ rule hidden)
This matters as we start to match more rules for hybrid features like rail
platforms, which now match both path and rail.  We want to show them unless the
user has hidden all the rules that they match.

Also this changes the test code slightly to actually test rule matching.
Before it was really just testing hiding.
2019-04-15 10:20:58 -04:00
Bryan Housel
11bfeaabfc Add browser-polyfills, remove lodash assign, compact, values
(re: #6087)
2019-03-22 17:14:41 -04:00
Quincy Morgan
bc5912881b Add code tests for hidden boundary relation members (re: #5601) 2019-02-11 16:31:51 -05:00
Bryan Housel
ba44c80076 Force visible any entities related to a selected error
(closes #5880)
2019-02-10 23:29:49 -05:00
Bryan Housel
71b2d2c6b7 Upgrade legacy symbols in tests
- iD.Context -> iD.coreContext
- iD.Graph -> iD.coreGraph
- iD.Node -> iD.osmNode
- iD.Way -> iD.osmWay
- iD.Relation -> iD.osmRelation
2019-01-30 15:43:02 -05:00
Bryan Housel
7de54a3c2b Fix feature test - amenity=shelter no longer matches building rule 2018-06-18 13:58:49 -04:00
Bryan Housel
c42556ec96 When boundaries are shared with roads, consider them as roads.
(closes #4973)

This is same as existing logic in the feature matching code
for the "rail" and "past_future" rules.
2018-04-09 12:59:13 -04:00
Bryan Housel
b3842d97f4 Remove lodash from the test suite
(closes #4378)
2017-10-18 14:37:39 -04:00
Bryan Housel
6ca4b13304 Store view transform and selectedIDs w/history, and undo/redo them
(closes #2204)
2016-12-10 23:25:58 -05:00
Bryan Housel
f800e5afbc Remove unnecessary window parameter to Context 2016-11-10 15:19:03 -05:00
Bryan Housel
7ca6d06254 Replace iD global with iD.Context() module (#3254) 2016-07-19 10:15:32 -04:00
Kushan Joshi
9dcb6856ab Remove linting errors from spec/renderer 2016-06-15 18:26:11 +05:30
Bryan Housel
c4fbacd625 Rename major_roads -> traffic_roads, minor_roads -> service_roads 2016-03-05 23:58:09 -05:00
Bryan Housel
63ab1e1267 Adjust matching rules for multipolygon members (closes #2887) 2016-01-04 12:07:12 -05:00
Bryan Housel
74c16ac674 failing test for #2887 2015-12-31 21:02:38 -05:00
Bryan Housel
58cb66f472 Add highway=corridor and universal level field
For now, `highway=corridor`:
  * styled like highway=pedestrian
  * and matches 'paths' feature filter.

(closes #2687, closes #2218)
2015-06-30 22:02:22 -04:00
Bryan Housel
05ff86e5c2 Prevent no-match parent relations from breaking getMatches
(e.g. a site relation with a fence in it)
Also, updated the test graph to contain one of these.
see https://github.com/openstreetmap/iD/pull/2554#issuecomment-78517442
2015-03-12 13:59:48 -04:00
Bryan Housel
3308b5507b Feature Filtering: don't match multipolygon lines as 'others'
(fixes #2548)

If the entity is a way that is a member of a parent relation,
use that parent relation's matches instead of matching 'other'
2015-03-10 00:06:29 -04:00
Bryan Housel
dfe8fd1e90 features performance enhancements
1. reusue entity.geometry where possible
2. cache entity parents
2014-11-18 22:05:08 -05:00
John Firebaugh
9e9a4b3cc0 Fix tests 2014-11-11 14:32:50 -08:00
Bryan Housel
b20f1495de restore toggle function and add test 2014-10-29 15:06:43 -04:00
Bryan Housel
927c533bb4 add feature tests for auto-hiding 2014-10-28 21:37:04 -04:00
Bryan Housel
43f1cdd3eb decoupled graph from context for better testing
fixed feature matching tests for vertices and relations
2014-10-28 21:37:04 -04:00
Bryan Housel
2b260f9a6c added tests for feature filtering
(some tests failing because I need to decouple graph from context)
2014-10-28 21:37:04 -04:00
Bryan Housel
6b6ca8d523 initial checkin of features unit tests 2014-10-28 21:37:04 -04:00