CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-13 01:02:58 +00:00
Code Issues Packages Projects Releases Wiki Activity
16,273 Commits 2 Branches 0 Tags
develop
Commit Graph

88 Commits

Author SHA1 Message Date
Bryan Housel
77801a3ecd Merge pull request #6284 from Bonkles/id-5869 
Improve validation for disconnected highways #5869
 2019-05-05 22:17:12 -04:00
Benjamin Clark
ec01933d84 Disconnected highways will now be warning flagged only if unattached to existing highways. 2019-05-01 17:42:23 -04:00
Quincy Morgan
375779882d Add ability to ignore warnings 
Replace issue's array of entities with array of entity IDs
Improve issue ID hashing
 2019-04-29 17:52:32 -07:00
Quincy Morgan
7d29a98a14 Add subtype to some validation issues 2019-04-25 10:35:27 -07:00
Quincy Morgan
aa91c2d768 Move old multipolygon warning into Outdated Tags rule (close #6218) 2019-04-24 15:46:50 -07:00
Quincy Morgan
13f7e536dc Move highway=road validation warning to the missing_tag validation rule (re: #6218) 2019-04-24 15:19:57 -07:00
Bryan Housel
294ce00211 substitute 'info' for 'data' (so I can use 'info' for an info drawer) 2019-04-15 16:56:21 -04:00
Bryan Housel
0a77a494aa Merge branch 'master' into validation_and_change_perf 2019-04-10 14:22:20 -04:00
Bryan Housel
1bcc0f613c WIP: fix caches, replace id() function with plain id property 2019-04-05 17:41:04 -04:00
Quincy Morgan
6dd9e9ce48 Add code tests for incompatible_source validation 2019-04-05 13:53:57 -07:00
Bryan Housel
82a9375e0f Move coreValidator test to test/spec/core/validator.js 2019-04-05 09:34:53 -04:00
Bryan Housel
8b1c0551cc WIP: understand state held by the validator, avoid translations 
- Make sure all state variables prefixed with `_`
- Add explicit `init`/`reset` methods
  (graph/entity refs should never persist through a save to OSM)
- Thinking of how best cache validation results
 2019-04-05 09:28:36 -04:00
Quincy Morgan
b841b0c242 Fix lint errors 2019-03-21 12:04:29 -04:00
Quincy Morgan
a2822caf2f Add tests for generic_name validation 2019-03-21 12:00:04 -04:00
Quincy Morgan
f03066e580 Add tests for private_data validation 2019-03-21 11:44:30 -04:00
Quincy Morgan
59b1d4d28d Add tests for unknown_road validation 2019-03-21 11:37:23 -04:00
Quincy Morgan
f114945628 Flag disconnected highway areas and multipolygons (close #6075) 
Don't flag highways connected only to highway multipolygons
 2019-03-21 10:13:59 -04:00
Quincy Morgan
fb25a44017 Generalize deprecated_tags validation to outdated_tags validation 
Add check for missing addTags go outdated_tags validation (close #6043, close #6042)
 2019-03-12 17:08:20 -04:00
Quincy Morgan
4eabf2da07 Add unit tests for old multipolygon validation 2019-02-26 12:09:16 -05:00
Quincy Morgan
8a9399edb7 Add line geometry to traffic_calming=island preset (re: #5945) 
Add more unit tests for tag_suggests_area
Replace "finds" with "flags" in validation unit test labels
 2019-02-26 11:30:03 -05:00
Quincy Morgan
12d770a05e Add unit tests for missing role validation 2019-02-26 11:00:00 -05:00
Quincy Morgan
12a44421c3 Account for indoor features in crossing ways validation 
Recommend using an appropriate structure/layer/level for crossing ways validation
Flag crossing highways on different levels but without bridges or tunnels
 2019-02-19 11:43:05 -05:00
Bryan Housel
c4fe42653a s/coordinates/loc and replace legacy names in tests 
In iD codebase `loc` is usually a single coordinate pair
and `coordinates` is usually an array of pairs
 2019-02-12 21:18:25 -05:00
Quincy Morgan
4595a822dc Add code tests for more missing_tag cases 2019-02-06 10:08:28 -05:00
Quincy Morgan
d3946894e8 Standardize deprecated_tag and missing_tag rule type ids 
Run crossing_ways before disconnected_way
Break out crossing_ways issue creation into a separate function
 2019-02-04 16:29:29 -05:00
Quincy Morgan
bfb5285dc9 Fix tests and lint warnings 2019-02-04 13:34:27 -05:00
Quincy Morgan
46f3cea33a Reorganize validation code 
Rename IssueManager to coreValidator
Rename disconnected highway to disconnected way
Rename highway almost junction to almost junction
Rename mapcss checks to maprules
Rename deprecated tags to deprecated tag
 2019-02-01 11:20:51 -05:00
Quincy Morgan
4389bd8741 Merge pull request #5723 from gaoxm/almostJunctAutoFix 
add auto-fix for almost junction by creating connection nodes
 2019-01-23 13:24:48 -05:00
Xiaoming Gao
08bc219e6f fix tests for crossing way validation check 
There're still test failures for "Almost Junction"; those are fixed
in a separate PR.
 2019-01-18 22:26:27 -05:00
Xiaoming Gao
aa5f1aec5b add auto-fix for almost junction by creating connection nodes 2019-01-16 20:02:25 -05:00
Xiaoming Gao
ecacab3ffe add validation for almost junction 
but avoid connect when the edge goes in parallel to the other road.
also added tests for the validation.
 2019-01-08 15:44:55 -05:00
Andrew Wong
958d918bbe Merge pull request #5639 from wonga00/more_tests 
Added more validation tests
 2018-12-21 16:49:11 -05:00
Andrew Wong
437cc5a9a5 added severity checks 2018-12-21 15:42:19 -05:00
Quincy Morgan
d9c6bd1f39 Added specialized issue messages for the common types of way crossing issues 
Fixed several linting issues involving crossing way validations
 2018-12-21 14:45:20 -05:00
Xiaoming Gao
dee005e9aa Improve cross way check 
1. Add more way types and relation types to check
2. Add more legit crossing cases
3. Add tests for 1 and 2
 2018-12-21 14:00:31 -05:00
Andrew Wong
5971bbebb7 Added more validation tests 2018-12-20 15:39:26 -05:00
Xiaoming Gao
a4e1012c91 add crossing_way validation 
Tests are also added and passed.

One thing to note: I had to add the tree() function to history so that I can
use the tree in the test; hope that's fine.
 2018-12-19 19:23:35 -05:00
Andrew Wong
c11ac6ed89 added missing_tag test 2018-12-19 13:33:02 -05:00