Quincy Morgan
9785021f44
Rename simpleMultipolygon functions to oldMultipolygon
...
Return old_multipolygon validation issues for the relations as well as the outer ways
Remove console logging
Don't run missing_tag validation for relations with old_multipolygon issues
2019-02-01 15:19:28 -05:00
Quincy Morgan
46f3cea33a
Reorganize validation code
...
Rename IssueManager to coreValidator
Rename disconnected highway to disconnected way
Rename highway almost junction to almost junction
Rename mapcss checks to maprules
Rename deprecated tags to deprecated tag
2019-02-01 11:20:51 -05:00
Quincy Morgan
09bc2a6e6c
Merge branch 'master' into validation
2019-01-30 16:44:14 -05:00
Bryan Housel
09f7f9189f
Fix field tests to run with minimal set of presets
2019-01-30 16:29:27 -05:00
Bryan Housel
71b2d2c6b7
Upgrade legacy symbols in tests
...
- iD.Context -> iD.coreContext
- iD.Graph -> iD.coreGraph
- iD.Node -> iD.osmNode
- iD.Way -> iD.osmWay
- iD.Relation -> iD.osmRelation
2019-01-30 15:43:02 -05:00
Bryan Housel
7138acc652
Properly export areaKeys, fix preset and maprules tests
2019-01-30 15:29:37 -05:00
Bryan Housel
15c0b82eb2
First attempt to run tests with minimal preset config
2019-01-30 10:25:40 -05:00
Quincy Morgan
0b19d5f93a
Merge branch master into validation
2019-01-29 14:51:59 -05:00
Bryan Housel
7aea67fcfe
Merge pull request #5745 from jguthrie100/stop_merge_overlapping_self
...
Add check to stop joining ways if resulting way intersects itself
2019-01-29 14:07:34 -05:00
Quincy Morgan
f25a80c48c
Merge branch 'master' into validation
2019-01-28 12:14:04 -05:00
Bryan Housel
b9444ab991
Restore hand cursor on dropdown carat
...
(closes #5769 )
This change allows pointer events to flow to the caret, and forwards
them back to the combo input. Also renames several event handlers
for clarity, and increases the double-click detection threshold.
2019-01-26 13:22:31 -05:00
Bryan Housel
55715a4827
Try to dispatch an accept event on blur
...
(re: #5752 - but does not close it)
2019-01-25 14:47:17 -05:00
Quincy Morgan
4389bd8741
Merge pull request #5723 from gaoxm/almostJunctAutoFix
...
add auto-fix for almost junction by creating connection nodes
2019-01-23 13:24:48 -05:00
Quincy Morgan
0aff34d980
Merge pull request #5736 from gaoxm/fixCrossWayTest
...
fix tests for crossing way validation check
2019-01-23 13:24:27 -05:00
Quincy Morgan
e69f2a0389
Merge branch 'master' into validation
2019-01-23 13:15:33 -05:00
Bryan Housel
0c7b9a631e
Improve combobox event handling and avoid overwriting typed data
...
(closes #5722 , re: #5637 , re: #5618 )
dispatched with a value() string instead of a datum, which
causes issues for code expecting a datum always.
(such as localized.js brand picker or "Add Field" combo)
Fix for this coming in next commit.
2019-01-22 22:26:27 -05:00
J Guthrie
631ace27d5
Add check to stop joining ways if resulting way intersects itself
...
- Includes new test case
2019-01-22 03:07:38 +00:00
Minh Nguyễn
9e3d49efb7
Replace wkid/w/s/n/e in WMS URL templates
2019-01-19 15:42:22 -08:00
Bryan Housel
19a8f5c47c
Remove test that only works if we can reliably simulate clicks
...
Previously the combo showed immediately on mousedown, now it
shows on mouseup after some slight delay.
2019-01-18 23:34:59 -05:00
Bryan Housel
1ec5b708fc
Restore default click behaviors on mousedown of a combobox
...
(closes #5732 )
2019-01-18 23:23:35 -05:00
Xiaoming Gao
08bc219e6f
fix tests for crossing way validation check
...
There're still test failures for "Almost Junction"; those are fixed
in a separate PR.
2019-01-18 22:26:27 -05:00
Xiaoming Gao
aa5f1aec5b
add auto-fix for almost junction by creating connection nodes
2019-01-16 20:02:25 -05:00
Yuri Astrakhan
d724677c9f
Support extracting wiki info from tag and key
2019-01-15 21:50:57 -05:00
Quincy Morgan
11b2102761
Merge branch 'master' into validation
...
# Conflicts:
# data/core.yaml
# dist/locales/en.json
# modules/ui/commit_warnings.js
# modules/ui/entity_editor.js
# modules/util/index.js
# modules/util/util.js
# modules/validations/index.js
# modules/validations/many_deletions.js
# modules/validations/missing_tag.js
2019-01-14 10:13:56 -05:00
Xiaoming Gao
ecacab3ffe
add validation for almost junction
...
but avoid connect when the edge goes in parallel to the other road.
also added tests for the validation.
2019-01-08 15:44:55 -05:00
Bryan Housel
7986fcbfbf
Merge branch 'keep-right_QA'
2019-01-04 21:37:19 -05:00
Bryan Housel
495793929f
Skip wikidata field test, too time sensitive to work reliably
2018-12-27 12:06:53 -05:00
Yuri Astrakhan
9f7f4aa3fc
Fix language fallback processing, caching bug.
2018-12-23 01:57:26 -05:00
Yuri Astrakhan
aa78cd10a3
Data items - remove hardcoded locale IDs
...
Locale IDs are now fetched together with the other data
when the language code is provided.
2018-12-22 14:58:15 -05:00
Yuri Astrakhan
b2810105a5
Implement support for multilingual descriptions from wiki data items
...
* Takes data directly from the Wikibase data items (OSM Wiki)
https://wiki.openstreetmap.org/wiki/OpenStreetMap:Data_Items
* Understands the difference in regions - e.g. will show different
images depending on the local settings
* Perf: Single request will get both the tag and key description
2018-12-22 00:23:31 -05:00
Bryan Housel
22e36be4f2
WIP on replacing documentation with direct calls to OSM wikibase
2018-12-22 00:23:31 -05:00
Andrew Wong
958d918bbe
Merge pull request #5639 from wonga00/more_tests
...
Added more validation tests
2018-12-21 16:49:11 -05:00
Andrew Wong
437cc5a9a5
added severity checks
2018-12-21 15:42:19 -05:00
Quincy Morgan
d9c6bd1f39
Added specialized issue messages for the common types of way crossing issues
...
Fixed several linting issues involving crossing way validations
2018-12-21 14:45:20 -05:00
Xiaoming Gao
dee005e9aa
Improve cross way check
...
1. Add more way types and relation types to check
2. Add more legit crossing cases
3. Add tests for 1 and 2
2018-12-21 14:00:31 -05:00
Andrew Wong
5971bbebb7
Added more validation tests
2018-12-20 15:39:26 -05:00
Quincy Morgan
f0fa59874f
Merge branch 'master' into validation
2018-12-20 10:31:25 -05:00
Bryan Housel
e2c0f5edcd
Merge pull request #5636 from openstreetmap/5596
...
open combobox if anywhere on box clicked...
2018-12-20 10:09:24 -05:00
Max Grossman
e3407d4168
do not use mouseover, use mousedown!
...
ref #5596
2018-12-20 09:05:23 -05:00
Xiaoming Gao
a4e1012c91
add crossing_way validation
...
Tests are also added and passed.
One thing to note: I had to add the tree() function to history so that I can
use the tree in the test; hope that's fine.
2018-12-19 19:23:35 -05:00
Quincy Morgan
ac539dddaa
Merge branch 'master' into validation
2018-12-19 18:13:44 -05:00
Quincy Morgan
cfbb86f88c
Change the initial view of the sidebar on selection
2018-12-19 17:44:41 -05:00
Bryan Housel
ca2d4e2c34
Fix layer test
2018-12-19 17:31:55 -05:00
Bryan Housel
2deadd5d6c
Fix merge issues
2018-12-19 17:12:06 -05:00
Andrew Wong
0e34313d1d
fixed maprules test
2018-12-19 13:38:21 -05:00
Andrew Wong
6ae25eada7
fixing tests around issues
2018-12-19 13:34:16 -05:00
Andrew Wong
c11ac6ed89
added missing_tag test
2018-12-19 13:33:02 -05:00
Thomas Hervey
75cff00a2a
displaying keep right (currently as notes)
2018-12-19 13:18:37 -05:00
Bryan Housel
81b5fc788e
Merge pull request #5629 from openstreetmap/5587
...
5587 - make geolocation show geolocation
2018-12-19 12:14:36 -05:00
Bryan Housel
e1f26b5692
Merge pull request #5624 from ockendenjo/hat-route
...
Add more tests for splitting ways in relations containing loops
2018-12-19 12:10:12 -05:00