16273 Commits

Author SHA1 Message Date
Quincy Morgan 3fade479af Merge pull request #8310 from openstreetmap/fix_notes
Fix a few errors in note processing
2021-02-05 11:46:06 -05:00
Quincy Morgan 8245822e60 Merge pull request #8337 from openstreetmap/dependabot/npm_and_yarn/rollup-2.38.3
Bump rollup from 2.36.2 to 2.38.3
2021-02-01 10:05:43 -05:00
dependabot[bot] 4bfa7dd157 Bump rollup from 2.36.2 to 2.38.3
Bumps [rollup](https://github.com/rollup/rollup) from 2.36.2 to 2.38.3.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rollup/rollup/compare/v2.36.2...v2.38.3)

Signed-off-by: dependabot[bot] <support@github.com>
2021-02-01 15:03:22 +00:00
Quincy Morgan a55d99a2db Merge pull request #8335 from openstreetmap/dependabot/npm_and_yarn/rollup/plugin-node-resolve-11.1.1
Bump @rollup/plugin-node-resolve from 11.0.1 to 11.1.1
2021-02-01 09:55:19 -05:00
dependabot[bot] a282ce3194 Bump @rollup/plugin-node-resolve from 11.0.1 to 11.1.1
Bumps [@rollup/plugin-node-resolve](https://github.com/rollup/plugins) from 11.0.1 to 11.1.1.
- [Release notes](https://github.com/rollup/plugins/releases)
- [Commits](https://github.com/rollup/plugins/compare/commonjs-v11.0.1...node-resolve-v11.1.1)

Signed-off-by: dependabot[bot] <support@github.com>
2021-02-01 05:24:07 +00:00
Bryan Housel 3665f80d46 Also include operator:wikidata as a wikidata tag
osmEntity#hasWikipedia was only used by the suspicious_name validator
2021-01-29 11:11:59 -05:00
Bryan Housel b032cd9f01 Adust NSI matching validation code:
- don't try matching semicolon-separated lists to NSI
- better matching for flagpoles with a `country` tag
- better lists of namelike keys (don't match flag operator)

see: https://github.com/openstreetmap/iD/pull/8305#issuecomment-769174070
2021-01-28 17:17:49 -05:00
Marc-marc-marc 6fa4bdf88a Fix contributing document typo (#8331)
fix typo data/core/yaml -> data/core.yaml
2021-01-28 13:01:06 +00:00
Bryan Housel 4c1d51348d Don't repurpose a node with interesting tags in crossing_ways fix
(closes #8326)
2021-01-27 14:38:11 -05:00
Bryan Housel 3640e15fa2 Fix misspelling "coprorate" -> "corporate" 2021-01-27 11:54:39 -05:00
Bryan Housel 16f2f07300 Merge pull request #8319 from openstreetmap/promisify_validation
Promisify validation
2021-01-27 11:49:27 -05:00
Bryan Housel f87c2d9357 Allow validators to return provisional results, revalidate after delay
Also add a ton of commments to validator.js
2021-01-27 10:38:48 -05:00
René Buffat c721c1ebb5 fix wms detection 2021-01-26 20:30:36 +01:00
Bryan Housel 11201eb822 Rewrite the validator in ES6/Promises, several improvements here:
- implements a validation work queue, jobs are run during browser idle callbacks
- when merging base entities, don't run validations 2x on both base and head graphs (this was wasteful)
- keep track of resolved issues in a separate set (it's not a simple compare of base/head anymore)
  this happens after validation queue is empty and avoids race conditions and inaccurate resolved counts
2021-01-25 12:50:11 -05:00
dependabot[bot] cb1e087126 Bump d3 from 6.3.1 to 6.5.0
Bumps [d3](https://github.com/d3/d3) from 6.3.1 to 6.5.0.
- [Release notes](https://github.com/d3/d3/releases)
- [Changelog](https://github.com/d3/d3/blob/master/CHANGES.md)
- [Commits](https://github.com/d3/d3/compare/v6.3.1...v6.5.0)

Signed-off-by: dependabot[bot] <support@github.com>
2021-01-25 05:22:33 +00:00
Bryan Housel 4f369a85a5 Match the prereleased nsi v5 (for now) 2021-01-22 11:59:14 -05:00
Bryan Housel f195128968 Fix a few errors in note processing
- Notes still load over the xml api, so when the user is not authenticated,
  we can't use d3_json to fetch them (instead use to d3_xml)
- Make sure to delete the deferred callback handles once the callbacks are
  processed (probably unnecessary, but good housekeeping)
- Remove a stray `if (!json.elements)` block from the `parseUserJSON`
  function. This was preventing the user profile from parsing, as the
  user's JSON has no such property (was probably copied from `parseJSON`)
2021-01-21 14:29:17 -05:00
Quincy Morgan 2803cd721e Merge pull request #8309 from openstreetmap/polygon-clipping
Swap out w8r/martinez clipper for mfogel/polygon-clipping
2021-01-21 14:17:15 -05:00
Bryan Housel 2cd11040b3 Swap out w8r/martinez clipper for mfogel/polygon-clipping
This is a drop in replacement that performs better and yields more correct results
see also https://github.com/ideditor/location-conflation/pull/20
2021-01-21 11:31:29 -05:00
Bryan Housel 96298f2836 Preserve name value if this preset shows brand or operator field
This also fixes the logic for calculating whether the preset shows a
`brand` or `operator` field - it needs to use `fields()` to actually
resolve the fields, as these fields can be inherited from another preset.

This also includes a change to match "primary" names before
"alternate" names (aka the "Baby Gap" / "Gap" problem)
2021-01-19 13:15:16 -05:00
Bryan Housel f61a3ef5e3 Don't replace flag:name tag - it's expected to be in local language 2021-01-18 21:44:27 -05:00
Bryan Housel a32553595c name:pronunciation is not namelike 2021-01-18 21:39:06 -05:00
Bryan Housel 74d28257c4 Fix teh misspellings 2021-01-18 19:48:35 -05:00
Bryan Housel 4228b65602 Support more *:wikidata tags for field locking and pin styling 2021-01-18 17:18:37 -05:00
Bryan Housel f39f73e3ae Make sure suggestion preset terms get used in the search 2021-01-18 15:02:07 -05:00
Bryan Housel a38a93c073 Actually assign the locationSetID properties on the given objects
(should have been in 868db8819)
2021-01-18 13:41:46 -05:00
Bryan Housel 0b3795cde3 NSI match returns an object now 2021-01-15 17:25:24 -05:00
Bryan Housel d3fb8c60f9 Upgrade validations outdated_tags, suspicious_names to NSI v5 2021-01-13 13:46:00 -05:00
Quincy Morgan cb8e9e379a Merge pull request #8297 from openstreetmap/dependabot/npm_and_yarn/rollup-2.36.1
Bump rollup from 2.35.1 to 2.36.1
2021-01-13 10:18:18 -05:00
dependabot[bot] d621ed03ab Bump rollup from 2.35.1 to 2.36.1
Bumps [rollup](https://github.com/rollup/rollup) from 2.35.1 to 2.36.1.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rollup/rollup/compare/v2.35.1...v2.36.1)

Signed-off-by: dependabot[bot] <support@github.com>
2021-01-13 05:13:08 +00:00
Bryan Housel 2d8c90786f coreLocation tests, documentation 2021-01-11 13:01:30 -05:00
Bryan Housel 868db8819f Have mergeLocationSets work on Objects, add locationSetID property
This means less work for the other parts of the code,
now they don't need to chain that extra step after the promise.
2021-01-09 10:34:58 -05:00
Bryan Housel c4daf1b377 Use locationManager to resolve/query community index 2021-01-08 17:05:37 -05:00
Bryan Housel 271e1c2e19 Use locationManager to filter fields/presets/defaults 2021-01-08 16:06:57 -05:00
Bryan Housel ab85590eb4 Pre-resolve the world locationSet 2021-01-08 14:00:49 -05:00
Bryan Housel 0ad7de0f10 Move the location index and resolver into a global coreLocations 2021-01-08 11:29:51 -05:00
Quincy Morgan 483ea41f46 Merge pull request #8276 from openstreetmap/1ec5-display-name-direction
Label route relations with directions and waypoints
2021-01-08 10:13:41 -05:00
Bryan Housel 9eb6f8781f Update presetIndex to resolve and index locationSets
Added a deferred work queue to do this with requestIdleCallback in the background
2021-01-06 16:26:12 -05:00
Quincy Morgan ddf868221a Use vertical bar for selecting parent ways instead of command+up arrow (re: #8264)
Support pressing vertical bar again to return to node selection
2021-01-06 14:26:24 -05:00
Quincy Morgan b0df3139e4 Don't highlight-focus single ways when one of their nodes is selected
Fix stale highlight-focus of parent way when selecting an unrelated vertex
Rename some confusing identifiers in modeSelect
Move global _relatedParent functionality into modeSelect proper
Re: #8264
2021-01-06 12:26:08 -05:00
Quincy Morgan 872d820b5a Merge pull request #8264 from openstreetmap/1ec5-select-way-2225
Add shortcut to select parent way(s)
2021-01-06 11:04:38 -05:00
Bryan Housel b0800c10ed Update to name-suggestion-index v5
Merge in NSI presets after UI has initialized
2021-01-05 12:44:33 -05:00
Quincy Morgan da00571409 Update variable name 2021-01-05 12:43:27 -05:00
Quincy Morgan e57793fab0 Use full width semicombo field for Via field (re: https://github.com/openstreetmap/id-tagging-schema/issues/104) 2021-01-05 11:07:00 -05:00
Quincy Morgan 2c2eabb145 Don't count tags under the name namespace as descriptive tags (close #8273)
Don't count `description`, `note`, `start_date`, or tags under those namespaces as descriptive tags
2021-01-05 09:56:19 -05:00
Quincy Morgan 1997aa2193 Merge pull request #8282 from openstreetmap/dependabot/npm_and_yarn/js-yaml-4.0.0
Bump js-yaml from 3.14.1 to 4.0.0
2021-01-05 09:19:22 -05:00
dependabot[bot] f5ea15d3c2 Bump js-yaml from 3.14.1 to 4.0.0
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.14.1 to 4.0.0.
- [Release notes](https://github.com/nodeca/js-yaml/releases)
- [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nodeca/js-yaml/compare/3.14.1...4.0.0)

Signed-off-by: dependabot[bot] <support@github.com>
2021-01-05 05:09:41 +00:00
Quincy Morgan cf75c814e4 Merge pull request #8274 from openstreetmap/dependabot/npm_and_yarn/ideditor/location-conflation-0.7.0
Bump @ideditor/location-conflation from 0.6.0 to 0.7.0
2021-01-04 10:37:15 -05:00
Quincy Morgan e2e53515b0 Merge pull request #8280 from openstreetmap/dependabot/npm_and_yarn/osm-community-index-3.1.0
Bump osm-community-index from 3.0.1 to 3.1.0
2021-01-04 10:36:38 -05:00
dependabot[bot] 0bf598ad5d Bump osm-community-index from 3.0.1 to 3.1.0
Bumps [osm-community-index](https://github.com/osmlab/osm-community-index) from 3.0.1 to 3.1.0.
- [Release notes](https://github.com/osmlab/osm-community-index/releases)
- [Changelog](https://github.com/osmlab/osm-community-index/blob/main/CHANGELOG.md)
- [Commits](https://github.com/osmlab/osm-community-index/compare/v3.0.1...v3.1.0)

Signed-off-by: dependabot[bot] <support@github.com>
2021-01-04 05:17:24 +00:00