16273 Commits

Author SHA1 Message Date
Bryan Housel 37557a7c98 Defer processing clicks in behaviorSelect
(closes #6028) (I hope?)

Because this click may trigger a blur event,
and the blur event may trigger a tag change,
and we really want that tag change to go to the already selected entity
and not the one that we are about to select with the click  #6028, #5878

(Be very careful entering modeSelect anywhere that might also blur a field!)
2019-05-01 14:47:29 -04:00
Quincy Morgan 949b57d118 Ensure that relations are called before ways when categorizing fetched features (close #6277) 2019-05-01 11:33:39 -07:00
Quincy Morgan 907df1c10e Include relation members when forcing relations visible in all cases, not just selection (re: 6eeaf94076) 2019-05-01 11:08:52 -07:00
Bryan Housel d3f767d6f4 Code cleanups, prefix state variables with _ 2019-05-01 13:48:36 -04:00
Quincy Morgan 21dc6fe500 Update meadow preset terms (close #6280) 2019-05-01 09:24:34 -07:00
Quincy Morgan 1d8e27ef91 Add derived data from prior merge 2019-05-01 09:06:40 -07:00
Quincy Morgan 6d1bb43793 Merge pull request #6275 from westnordost/presets-more-artwork-types
Add bust, graffiti and installation artwork type preset
2019-05-01 09:04:47 -07:00
Tobias Zwick 250df5b6a8 use "Graffiti" instead of "Graffiti Artwork" as name 2019-05-01 11:12:44 +02:00
Quincy Morgan 52d92f125c Add button to reset ignored issues
Don't cache issue extent
2019-04-30 16:32:36 -07:00
Bryan Housel d026f2f296 Add index property to tag rows, don't reorder on modifying key
(closes #5927)
2019-04-30 18:22:11 -04:00
Tobias Zwick 6a59a8c1f6 change name to Installation Art 2019-05-01 00:09:36 +02:00
Tobias Zwick a36c746b56 Add bust, graffiti and installation artwork type preset 2019-04-30 23:26:20 +02:00
Tobias Zwick 4bb5c27a2a remove removeTags from 2 recently deprecated presets 2019-04-30 22:28:18 +02:00
Tobias Zwick 446dc1097d Merge branch 'master' into patch-10
# Conflicts:
#	data/presets/presets/highway/crossing/unmarked-raised.json
#	data/presets/presets/highway/crossing/unmarked.json
2019-04-30 22:20:05 +02:00
Quincy Morgan a4ebbaf7f5 Don't use the issue loc as a differentiator for all issues 2019-04-30 13:16:03 -07:00
Tobias Zwick ba996f700d remove all now unnecessary removeTags 2019-04-30 22:15:51 +02:00
Tobias Zwick a1b89332bb add test 2019-04-30 22:15:34 +02:00
Tobias Zwick 62e0f76243 update readme and preset schema description 2019-04-30 22:15:16 +02:00
Tobias Zwick d008a585fa remove removeTags from suggestionsToPresets 2019-04-30 22:14:51 +02:00
Quincy Morgan 26f1e29072 Merge branch 'master' into ignoring-issues
# Conflicts:
#	data/core.yaml
#	dist/locales/en.json
2019-04-30 13:05:07 -07:00
Quincy Morgan 76e2948088 Add underscores to filenames of unsearchable crossing presets 2019-04-30 11:55:18 -07:00
Quincy Morgan 9d6b461d0e Apply the crossing tag of the path to the node even if it's not a footpath when connecting crossing ways 2019-04-30 11:53:03 -07:00
Quincy Morgan 07573091ad Don't add a "crossing" tag to ambiguous crossings when connecting crossing ways via the quick fix (re: #6244) 2019-04-30 11:46:15 -07:00
Quincy Morgan 5eb3416431 Don't suggest upgrading crossings without a "crossing" tag to crossing=unmarked (close #6244)
Style crossing icons more nicely
2019-04-30 11:41:50 -07:00
Quincy Morgan 942d55a4bf Update strings for duplicate node validation
Use routable highway tags for duplicate node validation instead of any highway tag
2019-04-30 10:18:22 -07:00
Quincy Morgan ddae6641b3 Fix issue where preset list would not appear when adding new features (close #6271) 2019-04-30 09:42:24 -07:00
Bryan Housel dbb10bb155 Just update save count on all changes
(closes #6239)
2019-04-30 10:02:00 -04:00
Bryan Housel b215c1f1a5 built with updated imagery 2019-04-30 10:01:47 -04:00
Bryan Housel 0a4e2c03a3 Extend timeouts on slow async mapillary tests
Trying to avoid false test failures.  Default timeout is 2sec, and we can't
be sure slow async tests will finish in that time esp. in a CI environment
2019-04-30 09:59:51 -04:00
Tobias Zwick f1d9b82831 inherit preset.removeTags from preset.addTags if not defined 2019-04-30 09:50:47 +02:00
Bryan Housel 2fde32ce9f Merge pull request #6267 from gaoxm/dupeNodeValidation
add validation for very close node on road
2019-04-29 23:52:49 -04:00
Ming Gao 18dff285d0 add validation for very close node on road
addresses issue #6241

also made a change in inspector, so that when an untagged entity has issues,
show the entity editor so that the issues are visible when an item is clicked
in the issues pane.
2019-04-29 22:59:27 -04:00
Bryan Housel a3605f9b74 Comment out "anchor encoding" for wiki links
(closes #6232)
2019-04-29 22:53:16 -04:00
Bryan Housel a72865e4d8 Treat anything with a from/via/to like a restriction
(closes #6221)

Applies to actions like splitting, connecting, extracting a via node, etc
2019-04-29 21:58:10 -04:00
Bryan Housel 2b46440429 Add Relation#hasFromViaTo method and tests 2019-04-29 21:39:40 -04:00
Bryan Housel bd2490a965 Reverse internal left/right/forward/backward keyparts
(closes #6235)

Previously only trailing keyparts would reverse:
 `cycleway:left` ⟺  `cycleway:right`
Now it can do internal keyparts too:
 `cycleway:left:surface` ⟺  `cycleway:right:surface`
2019-04-29 21:13:18 -04:00
Bryan Housel f9eacc9507 Fix typo "segements" -> "segments" 2019-04-29 21:03:05 -04:00
Quincy Morgan 375779882d Add ability to ignore warnings
Replace issue's array of entities with array of entity IDs
Improve issue ID hashing
2019-04-29 17:52:32 -07:00
Quincy Morgan 4215db39a2 Add derived data for the prior merge 2019-04-29 15:18:17 -07:00
Quincy Morgan eec2f6748d Merge pull request #6266 from westnordost/patch-9
deprecate shop=jewellery
2019-04-29 15:16:57 -07:00
Quincy Morgan 9837af3ba9 Add Building Height and Building Levels field to some POI presets if they are buildings (close #6238) 2019-04-29 15:13:25 -07:00
Quincy Morgan 9b37461ea6 Rename "SSID (Network Name)" field to "Wifi Network Name" to be clearer to most people 2019-04-29 14:58:59 -07:00
Tobias Zwick 494dac0225 deprecate shop=jewellery 2019-04-29 23:58:27 +02:00
Quincy Morgan 957735bb70 Make Internet Access Fee field appear immediately after setting Internet Access in more cases (close #6265)
Add internet_access fields to moreFields of more presets (because the network is everywhere!)
2019-04-29 14:51:16 -07:00
Bryan Housel 80b99eb7cb Get rid of extremely slow sibling selector affecting combo performance
(closes #6249)

I don't even think it affects anything anymore.
2019-04-29 17:26:40 -04:00
Bryan Housel fceb1a86f7 Merge pull request #6245 from openstreetmap/d3-v5
d3 v5
2019-04-29 15:46:08 -04:00
Bryan Housel e981cd5dd5 Switch mapillary and openstreetcam tests to work async
- can't reliably use sinon.spy to tell whether a thing has been called,
  so we listen for events instead and check server.requests()
- make sure to request the next page before dispatching `loadedImages` so
  we can `server.respond()` to the request in the event handler if we want to
- also moves `localeDateString` in the openstreetcam service from parsing
  code to display code, because it's very slow (we can just do this for the
  images we look at, instead of all images we fetch)
2019-04-29 15:31:08 -04:00
Quincy Morgan 4f03a2d34b Simplify self-service laundry preset filename 2019-04-29 10:57:55 -07:00
Tobias Zwick 0656ceff63 remove building=shed from bicycle_parking=shed preset
building=shed should not be added if the geometry is a point, but should, if possible, if it is an area. Unfortunately, the iD preset system is currently not able to map this behavior to a preset. Instead, there is the building_area field which automatically adds building=yes to the preset if it is an area.
2019-04-29 19:50:40 +02:00
Quincy Morgan ca8d92edd3 Capitalize Service in shop/laundry/self_service name
Add derived data for previous merge
2019-04-29 10:48:49 -07:00