Commit Graph

152 Commits

Author SHA1 Message Date
Bryan Housel 47aa28dc98 man_made=pipeline doesn't imply oneway
thread: https://lists.openstreetmap.org/pipermail/tagging/2014-June/017944.html
2014-06-21 15:20:05 -04:00
Bryan Housel 0c5f563a26 add test for iD.Entity.layer(), fix spelling of man_made. 2014-06-09 23:39:16 -04:00
Bryan Housel 97b189b397 Precreate fixed number of layergroups between -10, 10 2014-06-09 21:20:50 -04:00
Bryan Housel 849363ff8c Group by layer to correctly depth sort lines.. 2014-06-06 16:10:37 -04:00
Bryan Housel 5ee391dd52 Better layer sorting to fix z-depth issues.. 2014-05-30 15:20:36 -04:00
John Firebaugh 38b821bdea Limit imagery_used tag to 255 characters (fixes #2181) 2014-05-28 17:04:49 -07:00
John Firebaugh c0db8b8e67 jshint 2014-05-27 14:42:15 -07:00
John Firebaugh 0c09871c4a Don’t show turn restriction editor for non-highways (fixes #2240) 2014-05-27 14:35:57 -07:00
Bryan Housel 10bd86cb45 Check single source for implied onewayness #2220 2014-05-23 17:07:11 -04:00
Bryan Housel b8501bcf89 iD.Way.isOneWay should return false if oneway=no #2220
i.e. overrides implied oneway tag like `highway=motorway` or `junction=roundabout`
2014-05-20 00:14:23 -04:00
Bryan Housel a757142146 Rename "Entrance" as "Entrance/Exit" and add parking_entrance preset. 2014-05-19 15:39:16 -04:00
Bryan Housel d245121b19 Fix isConvex() to correctly test the angle that closes the way. 2014-04-23 14:12:20 -04:00
Bryan Housel 210e7889a1 Factor makeConvex into new method, fix missing comma and style issues.. 2014-04-14 23:54:03 -04:00
Bryan Housel a928d4894d Add isConvex() to iD.Way.. 2014-04-10 11:00:13 -04:00
Bryan Housel 9fade58d85 add picnic area stuff: firepit, picnic_table, bbq 2014-03-19 17:33:28 -04:00
John Firebaugh 8e96752039 barrier=fence shouldn't be an area (fixes #2158) 2014-03-16 22:05:18 -07:00
John Firebaugh f6b7acf9ed Remove conditional that's always true
The base graph never has any ownProperty entities.
2014-02-25 10:03:48 -08:00
tyr efd3223e0c extend history loading fix to deletions
Deleted objects need to be kept in the base of the history stack, too.

This also improves the respective unit tests.
2014-02-22 14:09:17 +01:00
tyr fc0a15e6c4 fix duplicate objects after restoring data from localStorage
This makes sure that the originals of changed entities get merged
into the base of the stack after restoring the data from JSON.
This is necessary, because the stack will only have elements for
the current viewport after a restart and previously *modified*
objects will now be falsely detected as *created* ones.

Also removed some ineffective code.
2014-02-21 10:01:26 +01:00
tyr b71c98cfca protect against relation loops, part 2. fixes #2096 2014-01-10 11:12:10 +01:00
John Firebaugh 1561c366be Update OSM.org links 2014-01-08 16:29:00 -08:00
John Firebaugh 089924ac38 Remove unused variable 2014-01-06 16:26:55 -08:00
John Firebaugh 4bf21cbc8a Restore deleted nodes that are discovered to have extant parents
This bug has existed since 1.0!

Fixes #2085
2014-01-06 16:23:15 -08:00
John Firebaugh 354ef9df44 Clock preset 2014-01-03 13:31:02 -08:00
John Firebaugh 7bbca76a20 Protect against relation loops (fixes #2072) 2014-01-02 17:42:57 -08:00
MaltaProject f1cceceec7 Added craft presets 2013-12-13 16:07:31 -04:00
Adam Solove 2213b072dd Clean up and test relation sorting code. 2013-12-10 22:39:37 -05:00
MateoV c7ebf2d754 aerialway & piste presets 2013-12-05 16:35:29 -05:00
MateoV 56d9ac56d2 add pressets and category for golf features, closes #2013 2013-11-26 14:42:19 -08:00
John Firebaugh 15590525d3 Fix build 2013-11-21 14:51:52 -08:00
John Firebaugh 4831f84480 Placate jshint 2013-11-21 14:39:00 -08:00
John Firebaugh 8ec53185df Build iD.Way.areaKeys from presets
This eliminates the possibility that a feature will
flip from area to line when you apply a preset.

Fixes #1996
2013-11-21 13:53:06 -08:00
tyr 2cf4c20a47 don't load parent multiple times into tree when multiple childs are changed
when an action (e.g. moving a way) caused multiple child elements
of the same parent to be changed, their parent was also loaded into
the tree multiple times during `tree.intersects()`.

this fixes #1978
2013-11-19 11:27:29 +01:00
John Firebaugh b383bfec1f Fix unclosed area rendering (fixes #1958) 2013-11-13 17:41:57 -08:00
John Firebaugh 492fc88aa4 Make the Graph#rebase argument an array 2013-10-31 16:24:31 -07:00
John Firebaugh ffdeef398d Rewrite tree logic
The main problem with the existing logic was that it
did not update the extents of relations when previously incomplete members were loaded.

It was also overly stateful; the various queues and flags
are no longer required.

Fixes #1928.
Fixes #1540.
2013-10-28 16:57:18 -07:00
John Firebaugh e0e08115e5 Pass entity array to Tree#rebase 2013-10-28 16:34:08 -07:00
John Firebaugh 1e78ee5c87 Stricter jshint 2013-10-24 16:08:48 -07:00
John Firebaugh 8323c948a7 jshint fixes 2013-10-24 15:33:52 -07:00
John Firebaugh fbf2118c76 Fix change summary calculation after restoring
We can't rely on identity equality here due to how
restoring works, and don't want to anyway -- the summary
should ignore net-no-op tag changes.

Fixes #1915.
2013-10-23 17:35:35 -07:00
John Firebaugh 2de500a90a Add a few more vertex cases to summary 2013-10-23 13:36:58 -07:00
John Firebaugh 697faf0265 Use summary to calculate # in Save button 2013-10-23 13:36:58 -07:00
John Firebaugh b8e88a7aaf Convert relevantChanges to a method on Difference 2013-10-23 13:36:58 -07:00
Aaron Lidman 594baa18b3 Update save commit dialog to use a feature list 2013-10-18 17:11:52 -04:00
John Firebaugh 26e38d7f8f Return geometries rather than features in asGeoJSON
No code needs the tags, and it eliminates one level
of function calls in the d3 stream pipeline.
2013-10-16 09:40:01 -04:00
John Firebaugh 81bc280aba More reliable method for mutexed localStorage saves
Fixes #1883
2013-10-10 14:59:48 -07:00
Paul Norman e6aeba1f60 Add more tags to areas list
Keys added from osm2pgsql, excluded values from overpass turbo
2013-09-26 13:44:01 -07:00
John Firebaugh bfef7962fe Add office to area list (fixes #1784) 2013-09-26 13:18:32 -07:00
John Firebaugh a32ce33238 Add Way#affix 2013-08-30 13:59:29 -07:00
John Firebaugh 163c85bacb Delete relations that become empty
Fixes #465
Fixes #1454
2013-08-27 12:27:11 -07:00