0f913113c7
Match a 'route_master' as if it were a 'route'
...
This code just treats `type=route_master` relations as if they were `type=route`
so they will match the transit networks in NSI.
(closes https://github.com/osmlab/name-suggestion-index/issues/5184 )
2021-08-05 22:05:11 -04:00
15ee63e875
Improve code for keeping only interesting key/value pairs
...
Before it was not actually checking that the osmvalue was in the vmap,
so we were testing a bunch of pairs like `highway/crossing` and
`highway/residential` that would never match a NSI category.
2021-08-05 16:59:07 -04:00
1d5c8253be
NSI matcher shouldn't treat old_name like a name tag
...
(closes #8617 )
2021-08-02 12:21:34 -04:00
bd97df6aac
In general, preserve existing values for tags that can be toplevel
...
We'll only _replace_ the tag value if this tag is the toplevel/defining tag for the matched item (`k`)
(closes #8615 )
2021-08-02 12:07:13 -04:00
8db1c1f7f5
Construct URL to match version number that package.json has
...
https://github.com/openstreetmap/iD/pull/8305#discussion_r663037548
2021-07-02 10:27:50 -04:00
896d14ba80
Upgrade to name-suggestion-index v6
...
Also bump country-coder and location-conflation
2021-06-24 16:41:50 -04:00
add11432d3
More sophisticated name/branch splitting
...
(re: https://github.com/openstreetmap/iD/pull/8305#issuecomment-805454952 )
2021-03-24 18:03:37 -04:00
55d9da9480
Improve logic for matching name fragments like TUI ReiseCenter
...
(re: https://github.com/osmlab/name-suggestion-index/issues/4543#issuecomment-799732746 )
2021-03-22 20:23:22 -04:00
77e7620ab8
Switch to published NSI v5 🎉
2021-03-22 14:39:58 -04:00
f5b6024988
Revise name/branch splitting code
...
This now breaks the name into fragments and reruns the fragments against the NSi matcher
rather than using flaky regular expressions. Has a few advantages:
(re: https://github.com/osmlab/name-suggestion-index/issues/4543#issuecomment-797577999 )
2021-03-12 15:03:50 -05:00
d282140999
If we match a generic name, stop looking
...
This is for "nextbike"
(re: https://github.com/osmlab/name-suggestion-index/issues/4543#issuecomment-796126041 )
2021-03-11 17:51:09 -05:00
98a622f41a
Make sure a name is either primary or alternate (can't be both)
2021-03-11 17:46:09 -05:00
19a8fd16d2
Be smarter about identifying what tree an osm feature might be in
...
Needed this after I added `highway=bus_stop` to the transit tree
2021-03-11 16:28:26 -05:00
a827e13a6d
Be less aggressive about removing toplevel tags
...
(re: https://github.com/openstreetmap/iD/pull/8305#issuecomment-792871448 )
2021-03-08 11:36:41 -05:00
7a82dba825
Only match alternate amenity/yes if it actually is tagged that way
2021-03-05 10:59:15 -05:00
3f8faec413
Improvements to name gathering
...
- Actually bail out properly if namelike values contain semicolon ';'
- Prioritize the canonical tags like `brand:wikidata`, `operator:wikidata`
- Don't insert a name into 'alternate' set if it's already in 'primary' set
2021-03-05 10:40:06 -05:00
1b1bf8eed2
Don't offer upgrades to dissolved items
2021-03-05 10:04:29 -05:00
bbed217625
For some names, consider splitting name into name and branch..
2021-03-05 09:54:47 -05:00
1f6a2121c4
Move all of NSI into a service, rewrite matcher code
2021-03-03 12:04:37 -05:00
Bryan Housel