Commit Graph

28 Commits

Author SHA1 Message Date
Xiaoming Gao
07a53fe6ea Extend data model for validation issues
Add the Issues pane

1. Add a class to represent the validation issue
2. Extend the data model for an validation issue to
  (1) add a severity level field (useful for identify save-blocking issues later)
  (2) replace single entity with an array of entities (useful for issues involving multiple entities)
  (3) add a coordinates field for highlighting the location of the issue on the map
  (4) add a fixes field for possible automatic fixes

3. Update existing validation modules to use the new data model
2018-12-19 10:37:32 -05:00
Quincy Morgan
0d0521c936 Moved feature applicability into the issue manager class 2018-12-19 10:32:14 -05:00
Quincy Morgan
161311faa5 Merge pull request #5626 from wonga00/wonga_issue_manager
added IssueManager
2018-12-18 18:05:40 -05:00
Quincy Morgan
858a9606d5 Added entity display name or preset name to the disconnected highway message 2018-12-18 18:05:27 -05:00
Andrew Wong
30f25c6e8d added IssueManager
- IssueManager performs validation on the current graph and also
   stores the issues and notifies listeners when the issues changed
2018-12-18 17:52:23 -05:00
Bryan Housel
5a2049b421 Drop extra whitespace, make sure service exists before using it 2018-12-18 15:38:53 -05:00
Max Grossman
0a31137c78 move maprules/mapcss to a service class
ref #remote-presets
2018-09-23 18:38:01 -04:00
Max Grossman
f168f85496 passing mapcss test w/out parser, use that on sever
ref #remote-presets
2018-08-10 09:16:59 -04:00
Bryan Housel
184e37253c Allow tourism=artwork on line geometry
And when used on a line, silence `tag_suggests_area` warning
(closes #5206)
2018-08-05 23:37:06 -04:00
Max Grossman
b93444de75 working on isArea-ish equivalent for mapcss selector objects
ref #remote-presets
2018-08-02 18:03:13 -04:00
Max Grossman
5b1dee3779 add tests for mapcss checks
ref #remote-presets
2018-08-02 12:47:47 -04:00
Max Grossman
2bf5eaf6e7 initial plumbing for iD validation errors
ref #remote-presets
2018-07-31 14:22:34 -04:00
Max Grossman
db78df55c8 get validaiton objects on context
ref #remote-presets
2018-07-31 13:41:24 -04:00
Benoit Costamagna
8e85fe847f correcting build issues 2018-01-29 13:20:50 +01:00
Benoit Costamagna
45b74d8730 Added difference between ways and areas 2018-01-29 13:10:39 +01:00
Benoit Costamagna
70a70ae906 very small optimization 2018-01-29 12:55:16 +01:00
Benoit Costamagna
8831ac18c9 Added more details to the warning when many elements are deleted 2018-01-29 12:50:50 +01:00
Bryan Housel
eb5d00bcc3 Convert lodah-es and d3 to named imports for validations 2017-09-25 23:36:28 -04:00
Bryan Housel
660511ec66 Add a validation warning about creating old-style multipolygons
(closes #3933)
2017-05-04 12:30:58 -04:00
Bryan Housel
0e788717c5 Do not warn if path is connected to entrance
(closes #3906)
2017-03-17 14:40:55 -04:00
Bryan Housel
3b46f1c83f Warn on untagged relations
(re #3812)
2017-02-01 14:41:41 -05:00
Bryan Housel
e9e442e998 Add a disconnected highway validation
(closes #3786)
2017-01-23 16:50:31 -05:00
Bryan Housel
3102a4ae6a Rename all the things to include pseudonamespaces 2016-10-04 19:06:20 -04:00
Bryan Housel
a86f34b4ef Pacify eslint, get build and tests running again 2016-08-26 01:15:07 -04:00
Tom MacWright
af776501d3 Require locale, second pass (#3259)
* Require locale, second pass

* Remove t global, remove t where it isn't needed
2016-07-21 16:20:13 -04:00
Tom MacWright
604d1e2719 import lodash (#3257) 2016-07-19 12:04:16 -04:00
Kushan Joshi
68e0400332 Add external modules to validations 2016-06-22 12:34:43 +05:30
Martin Raifer
6f1744700a refactor validations into ES6 modules #3118 2016-06-14 21:55:11 +02:00