CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-14 09:42:56 +00:00
Code Issues Packages Projects Releases Wiki Activity
11,551 Commits 2 Branches 0 Tags
07bc2821cd2f02ca7a9021ebfad9df0ae53baf4d
Commit Graph

240 Commits

Author SHA1 Message Date
Quincy Morgan
07bc2821cd Flag entire routing islands as single issues 2019-05-16 22:40:25 -04:00
Quincy Morgan
93a475c9a2 Correct issue with almost junction layer handling 2019-05-14 16:48:24 -04:00
Quincy Morgan
99565e8457 Don't flag crossing waterways and pier highways 2019-05-14 15:39:04 -04:00
Quincy Morgan
a9c30e840c Revalidate immediately after running most fixes (close #6354) 
Allow individual fixes to control revalidation
Don't allow fixes to run within a second of running any fix for that issue
 2019-05-14 14:41:07 -04:00
Quincy Morgan
4eedfa8b25 Don't allow autofixing unsquare buildings unless they are already very close to square 
Allow autofixing buildings with tags
 2019-05-13 16:28:08 -04:00
Quincy Morgan
bb4aa84a3b Don't flag almost junction issues between features on different layers or levels (close #6355) 2019-05-13 13:03:34 -04:00
Quincy Morgan
36a564f453 Add explicit check for very close nodes with an identical location 2019-05-10 12:14:29 -04:00
Quincy Morgan
8de10def2a Use actionMergeNodes instead of operationMerge for the very close nodes issue fix (close #6343) 2019-05-10 09:12:11 -04:00
Quincy Morgan
ad744a75ef Use "nonsquare" instead of "nosquare" for marking unsquare ways as physically unsquare (re: #6332) 2019-05-09 19:11:11 -04:00
Quincy Morgan
7b441ab766 Don't flag unsquare buildings connected to building multipolygons 2019-05-09 18:06:40 -04:00
Quincy Morgan
58e6afd3ea Don't flag very close nodes in boundaries 2019-05-09 17:50:22 -04:00
Quincy Morgan
f264cc47f0 Don't flag almost junctions when endpoint is building or parking entrance 
Include issues for disabled rules in entity issues
 2019-05-09 14:38:19 -04:00
Quincy Morgan
0e7a63f5c5 Add quick fix to unsquare way validation to tag a way as having unsquare corners (close #6332) 2019-05-09 12:04:18 -04:00
Quincy Morgan
399b9be006 Don't flag very close nodes in ways with too few nodes, indoor ways, and very small ways 2019-05-08 17:15:18 -04:00
Quincy Morgan
fd8f460739 Don't flag oneway highways that connect to highway areas or ferry routes as impossible 
Don't flag oneway waterways that connect to springs, storm drains, water bodies, or coastlines as impossible
 2019-05-08 15:36:37 -04:00
Quincy Morgan
3a78cf512c Move connect ways fix to its own function 
Make the edges and connection tags part of the crossing ways issue ID
 2019-05-08 10:32:25 -04:00
Quincy Morgan
73467d53b4 Don't flag highways connected to amenity=parking_entrance nodes as disconnected 
Don't flag oneways with entrance endpoints as impossible
 2019-05-07 14:55:57 -04:00
Quincy Morgan
97cb90b562 Make issue messages dynamic (close #6331) 2019-05-07 14:48:30 -04:00
Quincy Morgan
fd35e10aa7 Make the very close nodes validation work for any way (close #6326) 2019-05-07 12:28:59 -04:00
Bryan Housel
7551dd9093 fix typo 2019-05-06 13:04:00 -04:00
Bryan Housel
e3ea4b8484 Additional improvements to unsquare_way validation 
(re: #6288)

- use default params for actionOrthogonalize, not relaxed epsilon
- only allow autofix if there are no extra tags on the building (e.g. source)
 2019-05-06 12:58:40 -04:00
Bryan Housel
4608e9598c Adjust thresholds for unsquare_way detection 
(re: #6288)

I'd like to keep the angle threshold the same as what the action does
for UI consistency, but use a larger epsilon, so that fewer nearly-orthogonal
errors are reported.

With previous constants, it was strange that very orthogonal buildings
were being flagged, and very not-orthogonal buildings were not.
 2019-05-06 11:42:57 -04:00
Bryan Housel
59c34e2537 Perform orthagonalization fixes without a transition 
We can just set `action.transitionable = false` to make the action instant.
Also removes the `onCompletion` handlers. They shouldn't really be needed,
because the validator will run after the fix is applied (and at other times).
 2019-05-06 10:23:30 -04:00
Bryan Housel
77801a3ecd Merge pull request #6284 from Bonkles/id-5869 
Improve validation for disconnected highways #5869
 2019-05-05 22:17:12 -04:00
Quincy Morgan
4afd071a00 Add "Connect this feature" fix to disconnected ways if continuing drawing isn't possible 2019-05-03 12:59:18 -07:00
Quincy Morgan
dbc3978d71 Add non-actionable fix recommendation to move very close points apart 2019-05-03 12:15:26 -07:00
Bryan Housel
ddc9d16b62 Merge pull request #6302 from openstreetmap/text-raw-tag-editor 
Text raw tag editor / Copy-paste tags
 2019-05-03 14:53:08 -04:00
Quincy Morgan
b1d00db874 Show very close node issues on the parent way as well as on the points themselves (close #6304) 2019-05-03 10:40:12 -07:00
Bryan Housel
7b4a9a43b0 Change utilTagDiff to return an object with details 2019-05-02 22:59:41 -04:00
Quincy Morgan
bfc944e30a Fix two potential exceptions and one lint warning 2019-05-02 16:26:33 -07:00
Quincy Morgan
ba9fd58fa9 Don't flag roads connected only to ferry routes as disconnected (close #6287) 
Use common routable highway tag list for disconnected way check
 2019-05-02 14:49:27 -07:00
Quincy Morgan
0a71fd1e4f Fix false positive for impossible oneway when connected way is circular 2019-05-02 12:18:21 -07:00
Quincy Morgan
752bc72e7c Fix issue where close nodes validation may not detect issues in some cases 2019-05-02 12:03:09 -07:00
Quincy Morgan
b4dacdad2a Reduce very close nodes validation threshold (close #6292) 
Use spherical distances for very close nodes validation
Don't flag very close nodes from different ways
Don't flag very close nodes if both have interesting tags
Update very close nodes validation reference string
 2019-05-02 11:39:12 -07:00
Bryan Housel
ed9a436318 Move common tag diffing code from validators into utilTagDiff 2019-05-02 11:16:15 -04:00
Benjamin Clark
ec01933d84 Disconnected highways will now be warning flagged only if unattached to existing highways. 2019-05-01 17:42:23 -04:00
Quincy Morgan
a4ebbaf7f5 Don't use the issue loc as a differentiator for all issues 2019-04-30 13:16:03 -07:00
Quincy Morgan
26f1e29072 Merge branch 'master' into ignoring-issues 
# Conflicts:
#	data/core.yaml
#	dist/locales/en.json
 2019-04-30 13:05:07 -07:00
Quincy Morgan
9d6b461d0e Apply the crossing tag of the path to the node even if it's not a footpath when connecting crossing ways 2019-04-30 11:53:03 -07:00
Quincy Morgan
07573091ad Don't add a "crossing" tag to ambiguous crossings when connecting crossing ways via the quick fix (re: #6244) 2019-04-30 11:46:15 -07:00
Quincy Morgan
942d55a4bf Update strings for duplicate node validation 
Use routable highway tags for duplicate node validation instead of any highway tag
 2019-04-30 10:18:22 -07:00
Ming Gao
18dff285d0 add validation for very close node on road 
addresses issue #6241

also made a change in inspector, so that when an untagged entity has issues,
show the entity editor so that the issues are visible when an item is clicked
in the issues pane.
 2019-04-29 22:59:27 -04:00
Quincy Morgan
375779882d Add ability to ignore warnings 
Replace issue's array of entities with array of entity IDs
Improve issue ID hashing
 2019-04-29 17:52:32 -07:00
Quincy Morgan
59bd6194e0 Add "autofix" for the unsquare building validation 2019-04-26 14:56:39 -07:00
Quincy Morgan
ecc217f5d8 Add validation rule to flag impossible oneway highways and waterways (close #6216) 2019-04-26 12:04:43 -07:00
Quincy Morgan
7d29a98a14 Add subtype to some validation issues 2019-04-25 10:35:27 -07:00
Quincy Morgan
42de00e640 Add validation warning for "fixme" tags (close #6214) 2019-04-24 16:59:57 -07:00
Quincy Morgan
aa91c2d768 Move old multipolygon warning into Outdated Tags rule (close #6218) 2019-04-24 15:46:50 -07:00
Quincy Morgan
6a9c7b97a8 Don't flag websites on residential buildings 2019-04-24 15:21:49 -07:00
Quincy Morgan
13f7e536dc Move highway=road validation warning to the missing_tag validation rule (re: #6218) 2019-04-24 15:19:57 -07:00