Commit Graph

507 Commits

Author SHA1 Message Date
Quincy Morgan
e69f2a0389 Merge branch 'master' into validation 2019-01-23 13:15:33 -05:00
Bryan Housel
7e69ab508f Add quotes around "to" way to match other error messages 2019-01-18 18:23:08 -05:00
Yuri Astrakhan
3caf6eabed remove non local non en wiki links 2019-01-16 15:00:20 -05:00
Yuri Astrakhan
54b4a798b1 Localize language name 2019-01-16 14:35:47 -05:00
Yuri Astrakhan
2df519567d updated wiki link text 2019-01-16 14:09:22 -05:00
Quincy Morgan
1bfb9ac0c0 Updated almost junction issue message and tooltip to be better aligned with other issues
Added a quick fix for setting the almost junction node as noexit
2019-01-16 10:02:05 -05:00
Yuri Astrakhan
1127a34f94 Add wiki links from tag description
This feature requires P31 property to be present
in the data item. For an example, see
https://wiki.openstreetmap.org/wiki/Item:Q104#P31

Once the bot populates them in the data items,
it will automatically work for all existing keys/tags.
2019-01-15 20:07:45 -05:00
Quincy Morgan
21286467fa Merge branch 'master' into validation 2019-01-14 12:04:00 -05:00
Bryan Housel
67ef2bce1c Simplify and fix a few typos 2019-01-14 11:15:56 -05:00
Bryan Housel
fd23d13563 Distinguish between "This highway" and "highway" forms of error parts.
(closes #5703)
2019-01-14 10:59:45 -05:00
Quincy Morgan
11b2102761 Merge branch 'master' into validation
# Conflicts:
#	data/core.yaml
#	dist/locales/en.json
#	modules/ui/commit_warnings.js
#	modules/ui/entity_editor.js
#	modules/util/index.js
#	modules/util/util.js
#	modules/validations/index.js
#	modules/validations/many_deletions.js
#	modules/validations/missing_tag.js
2019-01-14 10:13:56 -05:00
Bryan Housel
ae8dffa43c Improve URL error messages 411, 412, 413 2019-01-10 21:35:13 -05:00
Bryan Housel
7f321abbaf Add links to the main error object in KeepRight error messages
re: https://github.com/openstreetmap/iD/issues/5679#issuecomment-452281850
2019-01-10 17:38:09 -05:00
Bryan Housel
9c190e83e9 Add quickLinks to preset editor, zoom to selected feature 2019-01-09 21:56:08 -05:00
Xiaoming Gao
ecacab3ffe add validation for almost junction
but avoid connect when the edge goes in parallel to the other road.
also added tests for the validation.
2019-01-08 15:44:55 -05:00
Bryan Housel
5f20218f1f Add validation warning for generic names
(closes #5590)
2019-01-08 02:15:28 -05:00
Bryan Housel
da4cb156a0 Fix missing parenthesis in error string 380 2019-01-05 01:15:01 -05:00
Bryan Housel
7986fcbfbf Merge branch 'keep-right_QA' 2019-01-04 21:37:19 -05:00
Bryan Housel
0582faff1d Convert KeepRight error 73 to regex
(re: https://github.com/openstreetmap/iD/pull/5201#discussion_r245349395 )
2019-01-04 20:27:22 -05:00
Bryan Housel
d0343c9fa7 Reintroduce some error localization, fix some nagging parse issues 2019-01-03 18:16:28 -05:00
Bryan Housel
35f8078f98 Reduce number of marker colors, increase contrast, tweak language 2019-01-03 15:30:36 -05:00
Bryan Housel
69ce5ee964 Remove user details and auth and adjust button texts for commenting
The user details and auth are not needed
because KeepRight accepts only anonymous updating
2019-01-03 00:07:55 -05:00
Bryan Housel
ee92758801 KeepRight only allows one anonymous comment per issue - simplify 2019-01-02 16:15:21 -05:00
Bryan Housel
9557c0204a Relax some more regex for tag parsing, (to support 'key=*')
Also implement parsing error 231 - layer conflict
2019-01-02 13:39:21 -05:00
Bryan Housel
2ec02f369f Simplify regex matching - goal is to have fewer, simpler rules 2019-01-02 11:46:13 -05:00
Bryan Housel
d54d5bfd89 Move title into keepright error header 2018-12-29 17:55:40 -05:00
Bryan Housel
192b4da9e6 Fix the strings I broke in 3785ffb15 2018-12-29 17:30:35 -05:00
Bryan Housel
3785ffb154 Simplify translation strings 2018-12-22 12:12:28 -05:00
Yuri Astrakhan
b2810105a5 Implement support for multilingual descriptions from wiki data items
* Takes data directly from the Wikibase data items (OSM Wiki)
     https://wiki.openstreetmap.org/wiki/OpenStreetMap:Data_Items
* Understands the difference in regions - e.g. will show different
  images depending on the local settings
* Perf: Single request will get both the tag and key description
2018-12-22 00:23:31 -05:00
Quincy Morgan
70d5529a58 Added initial implementation of quick fix for connecting crossing features (still has some bugs) 2018-12-21 17:39:20 -05:00
Quincy Morgan
d9c6bd1f39 Added specialized issue messages for the common types of way crossing issues
Fixed several linting issues involving crossing way validations
2018-12-21 14:45:20 -05:00
Quincy Morgan
c9350c632e Add issue fixes UI
Add two issue fixes for untagged feature
2018-12-21 12:31:33 -05:00
Bryan Housel
f7150004c0 Refactor things out of util with limited use, move more to service 2018-12-21 11:56:55 -05:00
Bryan Housel
4eb0e4b3a4 Remove more duplicate strings 2018-12-20 16:09:18 -05:00
Bryan Housel
6e1d6bcfda Drop legacy translation keys 2018-12-20 15:38:04 -05:00
Quincy Morgan
d58867df7c Add entity display label util function
Condense message and tooltip text for for the untagged feature issue
Use lighter border color for error issues
2018-12-20 14:04:15 -05:00
Quincy Morgan
d7ef2de073 Re-organizes issue messages and tooltips 2018-12-20 12:16:54 -05:00
Quincy Morgan
7416fc7ac3 Fixed typo in crossing ways issue label 2018-12-20 10:40:48 -05:00
Xiaoming Gao
a4e1012c91 add crossing_way validation
Tests are also added and passed.

One thing to note: I had to add the tree() function to history so that I can
use the tree in the test; hope that's fine.
2018-12-19 19:23:35 -05:00
Quincy Morgan
2207a6c3a4 Added severity tooltip to issue icon 2018-12-19 18:35:17 -05:00
Bryan Housel
2deadd5d6c Fix merge issues 2018-12-19 17:12:06 -05:00
Thomas Hervey
c501c44f60 updated: KeepRight description text 2018-12-19 13:45:35 -05:00
Thomas Hervey
f4e71812ca added: help documentation 2018-12-19 13:45:35 -05:00
Thomas Hervey
ee00635cc4 updated: some error colors; fixed: error 320, 220 2018-12-19 13:45:15 -05:00
SilentSpike
1f7455fdad Add missing error types 73, 74 and 75 2018-12-19 13:45:15 -05:00
SilentSpike
9bd772748a Convert warnings to regex
These aren't shown in the layer currently, but for future use this
should work
2018-12-19 13:45:15 -05:00
SilentSpike
005927dae3 Fix parsing of error type 211 2018-12-19 13:45:15 -05:00
SilentSpike
e0e48b7505 Fix parsing of error type 231 2018-12-19 13:45:15 -05:00
SilentSpike
d054e9cf6b Convert all error message schema to regex 2018-12-19 13:45:15 -05:00
SilentSpike
424bebf099 Convert preliminary amount of errors to regex
This focuses on converting error types I found on the map for testing
(can confirm the code is working!) as well as the more problematic cases
from the old code to show that this approach can handle them easily.
2018-12-19 13:45:15 -05:00