Commit Graph

58 Commits

Author SHA1 Message Date
Quincy Morgan
40b6fe7ff9 Fix semicombo drag-and-drop issues with stale data and target positioning (re: #7024) 2020-01-10 13:59:50 -05:00
Quincy Morgan
20fd66630b Update semicombo reordering (re: #7024):
Don't try reordering multiCombo fields
Fix offset behavior for full-width semicombos
Use grab/grabbing cursor style
Keep dragged chip above others
2020-01-09 14:43:18 -05:00
Arjun
ba00334f2b drag and drop of semicombos 2020-01-06 16:00:48 +00:00
Quincy Morgan
0a3b3df80c Filter out values with fewer 10 or fewer uses from combo field suggestions (close #7203) 2020-01-03 11:49:43 -05:00
Bryan Housel
16ff2b1373 Upgrade country-coder to scoped package @ideditor/country-coder 2019-12-02 13:51:04 -05:00
Quincy Morgan
d89996e52c Update country-coder to 2.0.0 (close #7029)
Localize address field in walkthrough without overwriting country coder function
2019-11-07 18:45:46 +01:00
Quincy Morgan
8c0740191f Replace remaining nominatim countryCode calls with country-coder calls (close #6941) 2019-11-01 18:15:35 +01:00
Quincy Morgan
d01bb78707 Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys (close #6237) 2019-04-24 13:45:59 -07:00
Bryan Housel
d5abe468b9 Remove rest of the lodash iterators: map, reduce, forEach
(re: #6087)
2019-03-29 15:14:21 -04:00
Quincy Morgan
748c9c9598 Filter out deprecated tag values from combobox suggestions (close #6084) 2019-03-27 17:15:10 -04:00
Bryan Housel
5b4aa529de Replace lodash uniq
(re: 6087)
2019-03-27 02:43:25 -04:00
Bryan Housel
963a4127db Remove lodash remove
(re: #6087)
2019-03-24 01:50:32 -04:00
Bryan Housel
5280d07bad Remove lodash reject (re: #6087) 2019-03-23 12:51:13 -04:00
Bryan Housel
76e0d13729 Remove lodash every and filter
(re: #6087)
2019-03-23 01:22:56 -04:00
Bryan Housel
7e6f68a1b2 Remove lodash some
(re: #6087)
2019-03-23 00:07:52 -04:00
Bryan Housel
ff4f8f005f Remove lodash find and findIndex
(re: #6087)
2019-03-22 17:31:41 -04:00
Bryan Housel
166a50028b Handle commas and semicolons typed into semi/multicombo values
(closes #6013)
2019-03-05 14:51:29 -05:00
Bryan Housel
26368522c9 Batch changes from raw tag editor so blur/remove tag don't conflict
(closes #5878)
2019-02-10 22:08:13 -05:00
Quincy Morgan
46beb31e74 Removed extra padding in comboboxes when the caret is hidden 2019-01-18 11:59:40 -05:00
Quincy Morgan
bf2574f4e3 Hide the dropdown arrow in combo fields if there are no suggestions from tagInfo (closes #5730) 2019-01-18 11:21:31 -05:00
Quincy Morgan
bc81a62a58 Made the value chips in the Destinations semiCombo field full-width to mimic the layout of highway signs (re: #4178)
The input and combobox caret elements in the multicombo field value list are now wrapped in a li element for consistency
2019-01-18 10:41:51 -05:00
Quincy Morgan
77cfde7913 combo, multiCombo, and semiCombo fields now correctly submit the typed value upon pressing enter/return without deselecting the feature (closes #5725) 2019-01-17 15:42:35 -05:00
Bryan Housel
39b3f1df68 Avoid creating comboboxes
(closes #5568)

Several strategies in here:
- Move uiCombobox() from inside the render function to class variable
- Don't render stuff like the raw tag editor when it's collapsed
- Don't show as many fields/combos on hover
- Don't instantiate fields (like universal/more) until they're actually shown
- Bind the combo on enter selection not on update selection
2018-12-11 16:07:00 -05:00
Bryan Housel
15a54cab17 Use context.container instead of passing it in 2018-12-10 14:14:27 -05:00
Bryan Housel
e5dedeff8b Move lib/d3.combobox.js -> ui/combobox.js
As with other things from this lib/ folder, little original code remains
and turning these things into reusable d3 plugins is not a priority.
2018-12-10 12:38:21 -05:00
Bryan Housel
958d7fac4f wip changing all fields to use flexbox everywhere 2018-11-28 18:15:38 -05:00
Bryan Housel
71592f3c72 Treat multicombo values other than 'no' and '' as if they are set
And don't set a multicombo value to 'yes' if it already has a non-'no' value
(closes #5291)
2018-09-04 17:31:46 -04:00
Bryan Housel
91872d72f8 Code formatting, replace regex match with test
(minor point, but `test` is much faster when you just want a boolean result)
2018-09-04 16:16:34 -04:00
Bryan Housel
4a71aa6146 Use safer field ids in classes, element ids, css selectors
Fixes issue with nested/namespaced fields, such as `maxspeed/advisory`,
in situations where would try to use a css selector or element id.
Can't use characters like '/' in a css selector.
2018-03-15 00:57:41 -04:00
Bryan Housel
c0040f3cd6 Add caseSensitive option for combofields, use for source=*
(closes #4558)
2017-11-26 19:30:19 -05:00
Bryan Housel
6d65a1c89a Convert lodah-es and d3 to named imports for ui/fields 2017-09-26 00:17:13 -04:00
Bryan Housel
746b54f3d2 Make combo field work without an entity 2017-08-15 15:34:34 -04:00
Bryan Housel
5f44c9a00a Add combobox menus to id-container instead of document.body
(re: https://github.com/openstreetmap/iD/issues/3925#issuecomment-290718356)
2017-03-31 13:44:55 -04:00
Bryan Housel
c3502a4e16 Only add the ellipses if the placeholder doesn't already end in one
(closes #3920)
2017-03-21 22:11:35 -04:00
Bryan Housel
ea2a1e10b1 Make sure multiData array is updated when item is removed 2017-03-17 13:32:45 -04:00
Bryan Housel
1205e1758e Add semiCombo field for setting values in semicolon-delimited lists
(closes #3905)
2017-03-17 01:47:00 -04:00
Bryan Housel
cd23d76875 Don't debounce combo placeholder lookups
(closes #3874)
2017-03-02 21:41:57 -05:00
Bryan Housel
2314acfec7 Add utilNoAuto to remove autocorrect/spellcheck features from inputs
(closes #3839)
2017-02-14 17:19:24 -05:00
Bryan Housel
94483af4c7 Fix service name nominatim -> geocoder 2017-01-17 16:46:41 +05:30
Bryan Housel
053074d076 Export live binding for services in iD.services, fix init/reset
(closes #3324)

Previously we allowed devs to swap out services that they didn't need.
This became difficult now that ES6 exports are immutable bindings.
But we can wrap the immutable bindings themselves in a live object,
to get back the flexibility that we used to have.

This change also drops the `taginfo` accessor on Context, since devs who want
to swap out taginfo service with something else can now do so through the live
binding.  `iD.services.taginfo = myTaginfo()`
2016-10-14 10:38:09 -04:00
Bryan Housel
7f61d36a5e Rename countryCode->code to avoid rollup name collision bug 2016-10-05 23:01:56 -04:00
Bryan Housel
3102a4ae6a Rename all the things to include pseudonamespaces 2016-10-04 19:06:20 -04:00
Bryan Housel
460ea42c95 Fix enter/update selections for multicombo chips 2016-09-27 00:12:37 -04:00
Bryan Housel
d7b3bb5a89 Fix placeholders set during enter selection not finding input element
Also remove unhelpful placeholder from access_simple.json
2016-09-26 01:03:55 -04:00
Bryan Housel
0ea59a043d Fields mostly working (but not dispatch/update) 2016-09-20 22:41:05 -04:00
Tom MacWright
ed135ce9ef Enable lib tests 2016-09-05 10:22:45 -04:00
Bryan Housel
a86f34b4ef Pacify eslint, get build and tests running again 2016-08-26 01:15:07 -04:00
Tom MacWright
cdb533fa84 Begin d3 v4 update 2016-08-21 15:19:27 -04:00
Tom MacWright
8819d3d061 Remove continued iD references (#3341)
* Remove continued iD references

* make build.js safe enough to dodge json plugin bug

* Package as an iife to avoid var name issue
2016-08-10 20:06:45 -07:00
Minh Nguyễn
d1d6b5399e Filter taginfo by country code prefix
taginfo returns results that match anywhere within the string. So in Canada, you might get results like US:CA:SF. This change filters out such results.
2016-08-02 07:26:50 -07:00