Commit Graph

1747 Commits

Author SHA1 Message Date
Martin Raifer be8dd830d8 properly convert callback to a promise (#10773) 2025-02-16 11:08:08 +01:00
andrewpmk a7038955ca Revalidate disconnected_way and impossible_oneway errors on change (#8911) 2025-02-15 18:45:32 +01:00
Martin Raifer 9f2b00f8c4 Merge branch 'develop' into way-reverse-dont-change-red-turn-direction 2025-02-13 11:00:58 +01:00
Kyℓe Hensel c1ca888b72 linkify keys & tags in the preset docs from the wiki (#10763) 2025-02-12 15:42:29 +01:00
Kyℓe Hensel 4747ae253c refactor isOneWay to properly support bidirectional ways (#10730) 2025-02-12 14:22:09 +01:00
Kyℓe Hensel 6328776df1 Fix + symbol appearing in changeset comments from external tools (#10766) 2025-02-12 14:13:15 +01:00
Martin Raifer f3a985f78b ways with more than 2000 nodes: prevent lockup and provide validator-fix (#8808)
* add validation & fix for way vertices limit imposed by OSM API (try to choose splitting locations at existing intersection vertices if possible)
* fix splitting of closed ways at two or more nodes:
  this bug resulted sometimes in one extra split point in the result, or one of the split  vertices to be left unsplit
2025-02-11 20:08:38 +01:00
Martin Raifer 121f3e2fb8 don't reauthenticate on HTTP 400 errors
since these are likely unrelated to authentication issues, but rather have to do with generic API errors or outages
2025-02-11 16:29:01 +01:00
Kyle Hensel f244e63661 validate crossing aeroways (#9315) 2025-02-05 14:42:32 +01:00
Kyℓe Hensel a2e347ac97 prevent degenerate ways caused by deleting a corner of a triangle (#10003) 2025-02-05 14:38:03 +01:00
burrscurr 841991055c don't change direction of red_turn when way is reversed
Fixes #10736
2025-02-05 12:57:00 +01:00
burrscurr f1d67e70e0 improve test coverage for reversing of turn lane values 2025-02-05 11:07:55 +01:00
Kyℓe Hensel 2c0f8a4b5f handle cycleway:both=* (#9587)
this works for any `directionalCombo` field, including `sidewalk:both`
2025-02-05 10:41:48 +01:00
Nick Doiron 6dcc73cf7c Add lang atttribute on multilingual names, wikidata/wikipedia fields (#10716)
This improves rendering of CJK names that contain unified ideographs that share a unicode codepoint, such as 化.
2025-01-31 13:49:49 +01:00
Kyℓe Hensel 5735b2509d ignore relations by default in the extract operation (#9816)
using Shift+E allows the node **and its relations** to be extracted (the old behaviour)
2025-01-30 11:25:01 +01:00
Kyℓe Hensel 3011acc23c fix occasional test failures (#10690) 2025-01-22 15:16:45 +01:00
Kyℓe Hensel 1c5b3b4051 use a more visible colour for oneway arrows on dark lines (#9143) 2025-01-15 11:38:36 +01:00
Kyℓe Hensel fb8b969c3f fix non-integer layer tag causing invisible features (#9933) 2025-01-15 11:35:18 +01:00
Kyle Hensel f5e36cfa80 add failing test case 2024-11-23 04:48:27 +14:00
Martin Raifer 93c8e3dd7d Merge remote-tracking branch 'k-yle/kh/mismatched-geom-error' into develop 2024-11-13 15:27:30 +01:00
Minh Nguyễn 6cfd1cf6fc Include route number in label of named route relations (#10478)
* iD#8707 Show ref in the name of route relations

* Avoid combining PTv2-formatted name with ref

* Pair name with other tags when labeling routes

---------

Co-authored-by: Kyle Hensel <k.y.l.e@outlook.co.nz>
2024-11-03 16:38:00 -08:00
Martin Raifer e7f56cf7f5 see b4e55c202 2024-10-16 13:52:28 +02:00
Martin Raifer b4e55c2027 backport fixes from PR#10452 missing in merge e839b6307 2024-10-16 13:49:03 +02:00
Kyle Hensel 108893c624 enable --no-isolate to speed up unit tests
This required fixing deferred code that was running after the unit test had unmounted
2024-10-16 13:42:51 +02:00
Kyle Hensel c3c0e23ba8 fix unsolvable validator error for presets with locationSet 2024-09-09 20:57:26 +10:00
Kyle Hensel 7bc94d6f4b migrate unit tests to vitest 2024-09-03 19:23:21 +10:00
Kyle Hensel 7afecd39ec minor tweaks to make some tests pass 2024-09-03 19:23:21 +10:00
Mattia Pezzotti ebb68d610e Fix panoramax non existing inaccurate sequence (#10375)
fixes #10365
2024-08-03 21:08:57 +02:00
Martin Raifer 9407f309a7 Merge branch 'develop' into panoramax 2024-07-29 15:13:38 +02:00
Martin Raifer fafb9f3d41 add test case for #10342 2024-07-26 11:59:06 +02:00
Martin Raifer e195947509 Merge branch 'develop' into panoramax 2024-07-12 18:22:53 +02:00
Martin Raifer a166210f34 Merge remote-tracking branch 'arch0345/improveosm' into develop 2024-07-12 12:54:16 +02:00
mattiapezzotti a9d8da10d1 prepared for pr 2024-07-12 00:01:05 +02:00
arch0345 14794ee992 Remove references to ImproveOSM 2024-07-08 17:15:38 -07:00
Martin Raifer b2b3009a64 .env oauth2 config: drop client secret; use URL if API_URL is empty 2024-07-05 16:15:47 +02:00
Dimitar b2fc4a43c0 Consider lifecycle prefixed tags in Future/Past features (#10228)
and sharpen landuse filter
2024-06-05 14:47:19 +02:00
Martin Raifer 25d98b14e0 Merge pull request #10198 from openstreetmap/dependabot/npm_and_yarn/eslint-9.0.0
Bump eslint from 8.57.0 to 9.0.0
2024-04-12 18:47:04 +02:00
Martin Raifer 85a388f345 fix small typo 2024-04-12 18:45:16 +02:00
Martin Raifer 211b6dde5f upgrade to eslintv9 (config format, lint to updated rules) 2024-04-12 18:44:04 +02:00
Hirako 85278c35e4 Field: fix wikiURL by URL encoding it - and slight refactors (#10165)
* Field: fix wikiURL by URL encoding it - and slight refactors

* Field: fix wikiURL only encodeURIComponent instead of redundant full URL

* Field: refactors function to generate wikiURL, ensures anchor part is also URI encoded, ensures the anchor ref is not encoded, adds unit tests

* Field: refactors wikipedia URI encoding of the anchor logic, removes legacy anchorencode effort via try-catch that replaced percentage character with dots, adds unit further  tests, reduces exessive inlining
2024-03-21 00:42:08 -07:00
Martin Raifer f89beef46d add a few more test cases: split carriageway route; route with alternate 2024-03-05 17:19:45 +01:00
Martin Raifer 296ce859cf allow splitting of closed roundabout for certain rel types 2024-03-05 14:23:02 +01:00
Martin Raifer 11dfbe804c fix splitting of (route) relation member ways
instead of fully re-sorting the whole relation every time a member is split, perform a local operation: This works under the assumption that the relation is already sorted properly. The new way is inserted into the relation before or after the existing member, depending on how the old/new way connect to their neighboring members.

for cases where two ways form a loop, a additional look-ahead is implemented to disambiguate the order
2024-03-04 19:02:31 +01:00
Martin Raifer 97442403cf drop validator which checks for old style multipolygons
these have long been [fixed](https://blog.jochentopf.com/2017-08-28-polygon-fixing-effort-concluded.html) in OSM

see wiki: https://wiki.openstreetmap.org/wiki/Old_style_multipolygons
2024-02-29 13:28:22 +01:00
marc tobias 277b5d4f45 new validator: mutually exclusive tags 2024-02-25 18:40:10 +01:00
Martin Raifer 85f4cc0316 don't reverse side tag of highway=cyclist_waiting_aid features, fixes #10128 2024-02-25 15:36:17 +01:00
Martin Raifer ce2fc08d3a fix mistake in test definition 2024-02-16 18:37:08 +01:00
Martin Raifer 83754e4a4a switch to Bing Maps API for Bing Streetside layer, fixes #10074
replaces the use of undocumented APIs for Microsoft's street level imagery service and gets rid of hardcoded values, e.g. for the `g` ("generation") parameter

see https://learn.microsoft.com/en-us/bingmaps/rest-services/imagery/get-imagery-metadata#get-streetside-metadata-centered-at-a-point for API docs

see also #10100
2024-02-16 18:29:23 +01:00
NaVis0mple 01d650d450 Expand DMS format and fix sec rounding logic (#10066)
Most DMS format parsed by @mapbox/sexagesimal, 
add a expandable matcher and two new formats for coordinates in DMS format in search bar

example: `35 11 10.1 , 136 49 53.8` (D M SS format), or `35 11.168 , 136 49.896` (D MM format)
2024-02-02 15:26:47 +01:00
Excitable Snowball 4bf79e9f1a Sanitize Amazon CloudFront signature in imagery_used (#10007) 2023-12-06 12:40:15 +01:00