Commit Graph

4482 Commits

Author SHA1 Message Date
Martin Raifer 5f1360ed0f don't suggest to "connect the ends" if a feature with area tags matches a line preset
For example, when a feature tagged as `highway=primary` (line preset) and `man_made=bridge` (area preset) is mapped as an unclosed way, converting it to an area (by closing the way by connecting the endpoints) does not improve the situation, as then the other tag doesn't fit to the geometry anymore.

closes #7037
2022-11-04 12:23:15 +01:00
Martin Raifer 58f597165b match shortest possible name or alias when sorting presets
improves preset matching in cases like https://github.com/openstreetmap/id-tagging-schema/issues/632
2022-11-04 10:06:20 +01:00
Kyℓe Hensel 2bf92b42b9 fix the phone input field showing the wrong placeholder (#9316) 2022-11-01 18:56:48 +01:00
Martin Raifer 78d37fd7a8 fix tooltip of "back/forward" buttons in preset list and entity editor 2022-11-01 18:32:47 +01:00
Martin Raifer 34a414ee18 make checkbox fields work with cross referenced string 2022-11-01 17:58:36 +01:00
Martin Raifer 56c05b1d1a Merge remote-tracking branch 'origin/locationmanager_perf' into develop 2022-10-28 17:30:10 +02:00
Bryan Housel 2b2a71f597 Don't pre-resolve and index complex locationSets into GeoJSON.
This was taking a lot of time at app startup.

Instad now we resolve and index only the include and exclude parts.
We can still determine the valid locationSets at runtime in `locationSetsAt()`
by checking the `_locationIncludedIn` and `_locationExcludedIn` caches.

This also upgrades the locationManger to an ES6 class.

This also includes some hacky code in nsi.js so that the NSI will continue to work.
The NSI matcher can build its own location index, but it doesn't need to do this.
We monkeypatch a few of the matcher collections to work with the new LocationManager.
2022-10-28 10:49:01 -04:00
Martin Raifer c9adbc724e fix crash when conflict resolver is opened, closes #9345 2022-10-28 13:48:54 +02:00
Martin Raifer 097c6bd774 skip unsupported/invalid restrictions instead of fallback to "no_*"
closes #9337 (at least kind of… for a proper solution see #6460)
2022-10-27 18:36:05 +02:00
Martin Raifer dd30a39d74 fix logic bug, extend test coverage 2022-10-27 17:07:32 +02:00
Martin Raifer 96bac0650b on preset change: don't drop tags if ∃ a matching field in the new preset
closes #9341
closes #9104
2022-10-27 13:06:00 +02:00
Martin Raifer b94b811591 use config to fetch preset translations 2022-10-27 12:11:26 +02:00
Martin Raifer e8b0c5c7cd fix leaking of localized strings in combo fields when taginfo is unavailable
fixes #9342

and fall back to populate such fields with "static" options if taginfo service is offline
2022-10-25 16:33:59 +02:00
Martin Raifer cb1202883f fix export 2022-10-18 13:58:38 +02:00
Martin Raifer b2b6cb5c19 add support for field type colour
see https://github.com/ideditor/schema-builder/pull/38
2022-10-18 11:56:05 +02:00
Martin Raifer d349baad1e fix loading of non-auto-suggested combo options
this was a typo/regression in b5e987b75
2022-10-17 18:35:00 +02:00
Martin Raifer c8a3cf154b make more cdn's and API urls/settings configurable
* CDNs for OCI, NSI, etc.
* OSM API (URL and oauth API settings)
* taginfo API
* nominatim API
2022-10-14 19:19:29 +02:00
Martin Raifer e8ceba1107 only use long-press context menu behavior on touch/stylus inputs
closes #8105
2022-10-14 13:02:15 +02:00
Martin Raifer 8076f6f2fe fix opening of context menu when pressing context menu key 2022-10-14 12:46:44 +02:00
Martin Raifer b5e987b755 fetch options from referenced strings 2022-10-13 19:18:55 +02:00
Martin Raifer 18b50ccd6d synchronize fetching presets from cdn
by first fetching `package.json` and loading the exact version from that for further presets requests
2022-10-13 18:42:52 +02:00
Martin Raifer b635cdd508 Merge branch 'schema-builder-v5' into develop 2022-10-13 13:53:31 +02:00
Martin Raifer 674421eec7 implement fetching string references
see https://github.com/openstreetmap/id-tagging-schema/pull/598
2022-10-07 12:04:23 +02:00
Martin Raifer e03d3b48fa fix selection of best background when starting zoomed-out, fixes #9325
By only selecting best imagery sources which cover at least half of the viewport area, and skipping overlays which are also marked as "best"
2022-10-06 20:51:38 +02:00
Martin Raifer df1f755150 don't show empty tooltips in backgrounds list 2022-09-27 14:00:28 +02:00
Martin Raifer 397161db1f Set development version number 2022-09-27 11:52:16 +02:00
Martin Raifer 0d4c58cc52 v2.22.0 2022-09-27 11:45:41 +02:00
Minh Nguyễn 3bf8d52ca9 Fixed undo text when deleting private tags 2022-09-23 11:08:14 -07:00
Martin Raifer aee8258570 fix tests 2022-09-23 19:18:10 +02:00
Martin Raifer e9eb0a0b3a include matching preset of selected object in preset selection list
see https://github.com/openstreetmap/iD/issues/9298#issuecomment-1250929094
2022-09-23 15:12:22 +02:00
Martin Raifer 4f34e28431 don't return hidden presets in recent 2022-09-23 15:07:56 +02:00
Martin Raifer e9bdd79887 fix content of locked ui field tooltip 2022-09-19 13:43:04 +02:00
Martin Raifer 12da8cbfee render side-markers also for coastline areas, fixes #9293 2022-09-14 19:25:52 +02:00
Martin Raifer a2cacaaf24 Don't auto-suggest undocumented tag values which have fewer than 100 uses
* previously, this check was based on the "fraction" of the respective tag value, which excluded more values for common tag keys, but fewer for less common ones.
* this sets a limit of 100 uses for undocumented tags (key=value pairs)
* tags with a wiki page are always allowed
* this harmonizes the heuristic of which tags to show between preset fields and the raw tag editor (previously, there was an additional `count > 10` filter present in combo fields, which is now uncessary)

closes #9227
2022-08-01 19:10:18 +02:00
Martin Raifer 1efdcb60ba update osmose service:
* change API requests to use `.geojson` ending
* drop issue type 8360-1, which doesn't seem top be supported anymore

fixes #9208
2022-07-21 11:47:49 +02:00
Martin Raifer 4b40ec81c6 linter fix 2022-07-19 19:31:59 +02:00
Martin Raifer 6d84857731 drop unused import 2022-07-19 19:31:28 +02:00
Martin Raifer 841789621f defer initializing background after ui has fully loaded
this makes sure that the map extent is known when deciding which background imagery to load (e.g. which are valid in the viewport or which is the "best" one)
2022-07-19 19:17:27 +02:00
Martin Raifer eb18de83a9 fix crash caused by wrongly set title of validation fix 2022-07-19 19:14:05 +02:00
Martin Raifer dbfc090e0f make sure ui and map (extent) are properly loaded when setting background 2022-07-19 18:59:51 +02:00
Martin Raifer 9c951aa235 fix regression which caused fist validation fix to revert to "ignore"
regressed in 8bb1d39431
2022-07-19 17:38:20 +02:00
Martin Raifer 0c1d4c7c44 Merge remote-tracking branch 'faebebin/fix/9176-connect-features-crossing-with-pedestrian-signals' into develop 2022-07-19 16:38:18 +02:00
Martin Raifer 60eead24ca use proper map extent when choosing imagery sources 2022-07-19 13:28:46 +02:00
Martin Raifer 6f5a195188 drop console.log 2022-07-19 13:12:39 +02:00
Martin Raifer 6526d655f6 further tweak and add tests for last map location restore
see #9146
2022-07-19 13:04:44 +02:00
Martin Raifer 67c65887b6 simplify map location restore, see #9146 2022-07-19 12:02:03 +02:00
Martin Raifer 981628bfd1 Merge remote-tracking branch 'bvercelli99/remember-location-hash' into develop 2022-07-19 11:31:33 +02:00
Martin Raifer 645d73a76e Merge remote-tracking branch 'k-yle/render-ref-as-label' into develop 2022-07-19 11:27:17 +02:00
Martin Raifer eee346e7dc apply "is background valid" on "last used" instead of "requested" layer 2022-07-15 18:57:50 +02:00
Renan 1313e4b21e Fix iD using invalid user selected imagery 2022-07-15 18:54:49 +02:00