Commit Graph

960 Commits

Author SHA1 Message Date
Yuri Astrakhan 1127a34f94 Add wiki links from tag description
This feature requires P31 property to be present
in the data item. For an example, see
https://wiki.openstreetmap.org/wiki/Item:Q104#P31

Once the bot populates them in the data items,
it will automatically work for all existing keys/tags.
2019-01-15 20:07:45 -05:00
Quincy Morgan 92e514f891 Make the preset browser appear upon adding a new relation.
Closes #5656
2019-01-14 16:25:43 -05:00
Bryan Housel 3090b5c875 Merge pull request #5708 from iriman/context-menu-rtl
[RTL] place tooltip under #id-container to inherit rtl
2019-01-14 09:07:12 -05:00
iriman bc9a64058f [RTL] place edit menu under #id-container to inherit rtl 2019-01-14 15:50:31 +03:30
iriman 7b53d0aa5a [RTL] pick appropriate class for .field-help-title > h2 2019-01-13 19:44:49 +03:30
Bryan Housel 09e574983f Don't call formFields.tagsChanged() when presetEditor.tags change
(closes #5690)

This change also makes sure to use the latest copy of the entity in
field.isAllowed() to ensure the prerequisite field check works
and fieldsArr is filtered properly for #5583
2019-01-11 17:42:34 -05:00
Bryan Housel b575ee8500 Move formFields klass from an argument to a state variable
(maybe needed in case render can get called different ways)
2019-01-11 13:56:16 -05:00
Bryan Housel 55a92ca79d Add closed:note changeset tag for closed OSM notes 2019-01-11 10:14:55 -05:00
Bryan Housel 5ebe0976fe Add closed:keepright changeset tag for closed issues
The issues are written as `schema:error_id` and semicolon delimited
e.g.  `closed:keepright=56:102661142`
closes this issue:
https://www.keepright.at/report_map.php?schema=56&error=102661142
2019-01-10 23:27:55 -05:00
Bryan Housel 7f321abbaf Add links to the main error object in KeepRight error messages
re: https://github.com/openstreetmap/iD/issues/5679#issuecomment-452281850
2019-01-10 17:38:09 -05:00
Bryan Housel 98c08a02ef Add "zoom to this" quicklink and keybind for keepright editor
(re #5169)
2019-01-09 22:59:44 -05:00
Bryan Housel 9282a51795 Add "zoom to this" quicklink and keybind for data editor
(re #5169)
2019-01-09 22:49:51 -05:00
Bryan Housel 6efbbb8aa3 Add "zoom to this" quicklink and keybind for note editor
(closes #5169)
2019-01-09 22:24:52 -05:00
Bryan Housel 9c190e83e9 Add quickLinks to preset editor, zoom to selected feature 2019-01-09 21:56:08 -05:00
Bryan Housel 5c6406ea63 Remove section borders from inspector
There is enough separation with the disclosure headings that we
don't need to break the sidebar up with lines
2019-01-08 14:04:07 -05:00
Bryan Housel 5f2d80c7a6 pacify eslint 2019-01-08 10:58:47 -05:00
Bryan Housel 5f20218f1f Add validation warning for generic names
(closes #5590)
2019-01-08 02:15:28 -05:00
Bryan Housel d9015baa47 Improve links in KeepRight error messages
(re: #5679)

Also move the localizeable string dictionary to data/keepRight.json
2019-01-07 16:10:44 -05:00
Bryan Housel 4ed2858cc5 Explicitly include '?' as a fallback key for keyboard shortcuts
(closes #5675)

This allows for a localized version of the key,
but iD will still respond to the '?'
2019-01-07 11:39:12 -05:00
Bryan Housel 826f66a91b Unique values for key codes moved to utilKeybinding, uiShortcuts
This lets us supply lists of keys which might contain duplicates, but will be
made unique.  For example: [t('sidebar.key'), '`', '²']
'sidebar.key' may be one of the other choices, but will be deduplicated.
2019-01-07 11:12:24 -05:00
Bryan Housel 55d2dddb70 Keybind all of _uniq([t(sidebar.key), '`', '²']) to toggle sidebar
(closes #5663)
2019-01-06 00:33:35 -05:00
Minh Nguyễn 3c82174f03 Capitalize first letter of KeepRight error detail 2019-01-05 00:32:45 -08:00
Bryan Housel 7986fcbfbf Merge branch 'keep-right_QA' 2019-01-04 21:37:19 -05:00
Bryan Housel 35f8078f98 Reduce number of marker colors, increase contrast, tweak language 2019-01-03 15:30:36 -05:00
Bryan Housel 46ebce2d6f Fix error reporting urls and make sure sidebar not showing stale data 2019-01-03 11:37:14 -05:00
Bryan Housel 9e6497b549 Update or remove the error after POSTing changes to server 2019-01-03 01:39:40 -05:00
Bryan Housel 69ce5ee964 Remove user details and auth and adjust button texts for commenting
The user details and auth are not needed
because KeepRight accepts only anonymous updating
2019-01-03 00:07:55 -05:00
Bryan Housel ee92758801 KeepRight only allows one anonymous comment per issue - simplify 2019-01-02 16:15:21 -05:00
Bryan Housel 4494c3ab9c Fix comment box style, remove unused vars for eslint 2019-01-02 15:46:25 -05:00
Bryan Housel 9557c0204a Relax some more regex for tag parsing, (to support 'key=*')
Also implement parsing error 231 - layer conflict
2019-01-02 13:39:21 -05:00
Bryan Housel d54d5bfd89 Move title into keepright error header 2018-12-29 17:55:40 -05:00
Bryan Housel 192b4da9e6 Fix the strings I broke in 3785ffb15 2018-12-29 17:30:35 -05:00
Bryan Housel 4f0a608439 Merge pull request #5637 from openstreetmap/5618
fix autocomplete combobox bug
2018-12-26 15:15:29 -05:00
Yuri Astrakhan 9f7f4aa3fc Fix language fallback processing, caching bug. 2018-12-23 01:57:26 -05:00
Yuri Astrakhan 8b931f3e6c Use new message to encourage editing and translation 2018-12-22 15:03:22 -05:00
Bryan Housel 3785ffb154 Simplify translation strings 2018-12-22 12:12:28 -05:00
Yuri Astrakhan b2810105a5 Implement support for multilingual descriptions from wiki data items
* Takes data directly from the Wikibase data items (OSM Wiki)
     https://wiki.openstreetmap.org/wiki/OpenStreetMap:Data_Items
* Understands the difference in regions - e.g. will show different
  images depending on the local settings
* Perf: Single request will get both the tag and key description
2018-12-22 00:23:31 -05:00
Bryan Housel 22e36be4f2 WIP on replacing documentation with direct calls to OSM wikibase 2018-12-22 00:23:31 -05:00
Bryan Housel f7150004c0 Refactor things out of util with limited use, move more to service 2018-12-21 11:56:55 -05:00
Bryan Housel 7f669d292f Simplify KeepRight tile fetching code 2018-12-20 14:40:14 -05:00
Quincy Morgan 7c192a2e36 Fixed bug where the entity ID could not be found for the field 2018-12-20 12:25:35 -05:00
Quincy Morgan 97c2361f43 Changed initial sidebar screen for highway intersection vertices from preset list to editor 2018-12-20 10:17:16 -05:00
Bryan Housel 62547e3459 Merge pull request #5638 from openstreetmap/5612
remove highlight from relation member after it is deleted from relation
2018-12-20 10:10:46 -05:00
Bryan Housel e2c0f5edcd Merge pull request #5636 from openstreetmap/5596
open combobox if anywhere on box clicked...
2018-12-20 10:09:24 -05:00
Max Grossman 9a5a77f96c remove unneccessary space
ref #5612
2018-12-20 09:24:46 -05:00
Max Grossman 18c32511a2 remove member's highlight when removed from relation
ref #5612
2018-12-20 09:23:58 -05:00
Max Grossman e3407d4168 do not use mouseover, use mousedown!
ref #5596
2018-12-20 09:05:23 -05:00
Max Grossman 2dab19e9ae default to value() if neither d and choice are null in the accept function
ref #5618
2018-12-20 08:52:16 -05:00
Max Grossman 5a1dfeec72 open combobox if anywhere on box clicked...
ref #5596
2018-12-20 08:47:37 -05:00
Quincy Morgan cfbb86f88c Change the initial view of the sidebar on selection 2018-12-19 17:44:41 -05:00