CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-03-19 09:33:32 +00:00
Code Issues Packages Projects Releases Wiki Activity
10,031 Commits 2 Branches 0 Tags
11b2102761c293c06bbb8495ce3d33ebcf903ccf
Commit Graph

1096 Commits

Author SHA1 Message Date
Quincy Morgan
11b2102761 Merge branch 'master' into validation 
# Conflicts:
#	data/core.yaml
#	dist/locales/en.json
#	modules/ui/commit_warnings.js
#	modules/ui/entity_editor.js
#	modules/util/index.js
#	modules/util/util.js
#	modules/validations/index.js
#	modules/validations/many_deletions.js
#	modules/validations/missing_tag.js
 2019-01-14 10:13:56 -05:00
Xiaoming Gao
ecacab3ffe add validation for almost junction 
but avoid connect when the edge goes in parallel to the other road.
also added tests for the validation.
 2019-01-08 15:44:55 -05:00
Bryan Housel
7986fcbfbf Merge branch 'keep-right_QA' 2019-01-04 21:37:19 -05:00
Bryan Housel
495793929f Skip wikidata field test, too time sensitive to work reliably 2018-12-27 12:06:53 -05:00
Yuri Astrakhan
9f7f4aa3fc Fix language fallback processing, caching bug. 2018-12-23 01:57:26 -05:00
Yuri Astrakhan
aa78cd10a3 Data items - remove hardcoded locale IDs 
Locale IDs are now fetched together with the other data
when the language code is provided.
 2018-12-22 14:58:15 -05:00
Yuri Astrakhan
b2810105a5 Implement support for multilingual descriptions from wiki data items 
* Takes data directly from the Wikibase data items (OSM Wiki)
     https://wiki.openstreetmap.org/wiki/OpenStreetMap:Data_Items
* Understands the difference in regions - e.g. will show different
  images depending on the local settings
* Perf: Single request will get both the tag and key description
 2018-12-22 00:23:31 -05:00
Bryan Housel
22e36be4f2 WIP on replacing documentation with direct calls to OSM wikibase 2018-12-22 00:23:31 -05:00
Andrew Wong
958d918bbe Merge pull request #5639 from wonga00/more_tests 
Added more validation tests
 2018-12-21 16:49:11 -05:00
Andrew Wong
437cc5a9a5 added severity checks 2018-12-21 15:42:19 -05:00
Quincy Morgan
d9c6bd1f39 Added specialized issue messages for the common types of way crossing issues 
Fixed several linting issues involving crossing way validations
 2018-12-21 14:45:20 -05:00
Xiaoming Gao
dee005e9aa Improve cross way check 
1. Add more way types and relation types to check
2. Add more legit crossing cases
3. Add tests for 1 and 2
 2018-12-21 14:00:31 -05:00
Andrew Wong
5971bbebb7 Added more validation tests 2018-12-20 15:39:26 -05:00
Quincy Morgan
f0fa59874f Merge branch 'master' into validation 2018-12-20 10:31:25 -05:00
Bryan Housel
e2c0f5edcd Merge pull request #5636 from openstreetmap/5596 
open combobox if anywhere on box clicked...
 2018-12-20 10:09:24 -05:00
Max Grossman
e3407d4168 do not use mouseover, use mousedown! 
ref #5596
 2018-12-20 09:05:23 -05:00
Xiaoming Gao
a4e1012c91 add crossing_way validation 
Tests are also added and passed.

One thing to note: I had to add the tree() function to history so that I can
use the tree in the test; hope that's fine.
 2018-12-19 19:23:35 -05:00
Quincy Morgan
ac539dddaa Merge branch 'master' into validation 2018-12-19 18:13:44 -05:00
Quincy Morgan
cfbb86f88c Change the initial view of the sidebar on selection 2018-12-19 17:44:41 -05:00
Bryan Housel
ca2d4e2c34 Fix layer test 2018-12-19 17:31:55 -05:00
Bryan Housel
2deadd5d6c Fix merge issues 2018-12-19 17:12:06 -05:00
Andrew Wong
0e34313d1d fixed maprules test 2018-12-19 13:38:21 -05:00
Andrew Wong
6ae25eada7 fixing tests around issues 2018-12-19 13:34:16 -05:00
Andrew Wong
c11ac6ed89 added missing_tag test 2018-12-19 13:33:02 -05:00
Thomas Hervey
75cff00a2a displaying keep right (currently as notes) 2018-12-19 13:18:37 -05:00
Bryan Housel
81b5fc788e Merge pull request #5629 from openstreetmap/5587 
5587 - make geolocation show geolocation
 2018-12-19 12:14:36 -05:00
Bryan Housel
e1f26b5692 Merge pull request #5624 from ockendenjo/hat-route 
Add more tests for splitting ways in relations containing loops
 2018-12-19 12:10:12 -05:00
Max Grossman
399e7781c1 remove dispatched changes and re-order layers 
ref #5587
 2018-12-19 11:54:39 -05:00
Max Grossman
b010f42125 update layers test for new geolocate svg layer 
ref #5587
 2018-12-19 11:14:03 -05:00
ockendenjo
cec442012a Add test for route going round loop in other direction 2018-12-18 22:09:20 +00:00
ockendenjo
8aaa387d4e Add tests for hat route splitting #4876 2018-12-18 21:39:35 +00:00
Bryan Housel
5a2049b421 Drop extra whitespace, make sure service exists before using it 2018-12-18 15:38:53 -05:00
Max Grossman
6ba8bacb75 use severity in test 2018-12-18 10:27:15 -05:00
Max Grossman
64f2d913e8 remove unused entities from test 2018-12-17 17:39:47 -05:00
Max Grossman
8f33a85a12 make collection.index function to handle failing tests 2018-12-17 17:16:10 -05:00
Max Grossman
1b51b8bc57 adding tests and updating/fixing external presets logic 2018-12-14 13:23:58 -05:00
Max Grossman
c897331cd1 presets test w/build 2018-12-13 13:30:38 -05:00
Max Grossman
96e44be69c merge 2.12.2 2018-12-13 11:22:32 -05:00
Max Grossman
f3e6459191 working on preset visibility 2018-12-13 11:16:24 -05:00
Bryan Housel
222b3f1b04 Don't render contents of collapsed sections 
(speeds things up if raw tag editor is hidden)
 2018-12-11 15:19:29 -05:00
Bryan Housel
6732ca6eda Comboboxes no longer show on focus.. update tests 2018-12-11 01:19:51 -05:00
Bryan Housel
15a54cab17 Use context.container instead of passing it in 2018-12-10 14:14:27 -05:00
Bryan Housel
e5dedeff8b Move lib/d3.combobox.js -> ui/combobox.js 
As with other things from this lib/ folder, little original code remains
and turning these things into reusable d3 plugins is not a priority.
 2018-12-10 12:38:21 -05:00
Bryan Housel
247900f727 Change several of the event things, remove numeric index 
re: https://github.com/openstreetmap/iD/issues/5558#issuecomment-445307568
 2018-12-07 16:54:32 -05:00
Huon Wilson
dd0be84da4 Add one-sided triangular markers to ways with sides (e.g. natural=cliff). 
This generalizes the oneway arrow logic for adding SVG markers along a
line. Using that functionality, certain tags get arrows on their
right-hand side, indicating which side is "inside", e.g. the
right-side of a cliff is the lower side.

The list of tags considered to be sided (unless there's a
two_sided=yes tag) is:

- natural=cliff
- natural=coastline
- barrier=retaining_wall
- barrier=kerb
- barrier=guard_rail
- barrier=city_wall
- man_made=embankment

The triangles attempt to be reminiscent of the triangles used for
rendering cliffs on OSM (and elsewhere). The different tags get
different renderings (e.g. colors that match the main way, and
different spacings). In addition, natural=coastline is special-cased
to have blue markers (despite having a green way), to emphasise that
the "inside" of a coastline is the water.

Fixes https://github.com/openstreetmap/iD/issues/1475.
 2018-11-28 01:45:50 +11:00
Huon Wilson
f356c6ac49 test: add tests for adding oneway arrows to lines 2018-11-28 01:25:04 +11:00
Bryan Housel
9341e477a6 Merge remote-tracking branch 'origin/master' into brand-name-protection 2018-11-26 15:27:56 -05:00
J Guthrie
a23c975232 Fix specs 2018-11-24 21:27:20 +00:00
Bryan Housel
ea9e3008a5 addTags() -> setTags() / removeTags() -> unsetTags() 
This avoids overriding the `addTags` and `removeTags` objects with functions
 2018-11-21 12:59:43 -05:00
Bryan Housel
e3f5aecda9 Remove dataSuggestions and utilSuggestNames 
- dataSuggestions was just a reexport of the name-suggestion-index
- utilSuggestNames was a combobox fetcher function used only once by uiFieldLocalized
    Doesn't need to be a util if it's only used once in the code
    and the tests for it were not really that interesting
 2018-11-20 21:27:32 -05:00