Commit Graph

1871 Commits

Author SHA1 Message Date
John Firebaugh 4720a84d38 No-op a null tag merge
Reduces unnecessary node churn in Connect action.
2013-03-12 16:26:40 -07:00
John Firebaugh 4fa88acc85 Fix connecting adjacent vertices
Can't unconditionally delete the node; it may be a member
of other ways.

I didn't preserve the behavior of dragging a midpoint to
an adjacent node being a no-op. In general we don't try to
eliminate compound operations whose net result is a no-op;
I don't think it's important to do so for this special case.

The degenerate case of connecting the endpoints of a two-vertex
line now results in a point. This is what naturally resulted
from the code, and seems ok.

Fixes #983.
2013-03-12 16:26:40 -07:00
John Firebaugh 3b3ee84a84 Specs for Way#areAdjacent 2013-03-12 16:22:30 -07:00
Ansis Brammanis 831b67beae universal presets
presets with universal=true show up for
any preset if the key is present
2013-03-12 19:19:10 -04:00
Ansis Brammanis ca1a7cf7f6 add ability to add general form fields 2013-03-12 17:42:55 -04:00
John Firebaugh 03cede7e24 Ensure tooltip is removed (fixes #986) 2013-03-12 13:42:35 -07:00
John Firebaugh be567fb028 Render landuse=farm and landuse=farmland identically
See http://www.openstreetmap.org/user/Harry%20Wood/diary/14079
for an entertaining rant on this subject.
2013-03-12 13:12:07 -07:00
John Firebaugh 107f6cfeba type -> geometry 2013-03-12 13:00:32 -07:00
Ansis Brammanis d7645d7f21 fix locale.js 2013-03-12 15:45:39 -04:00
saman bb 6dc7b7b236 preset style/layout cleanup. 2013-03-12 15:32:26 -04:00
Ansis Brammanis 917d5bfaeb avoid history change when dragging midpoint
dragging a midpoint onto an adjacent node
should do nothing
2013-03-12 14:38:01 -04:00
John Firebaugh 42be94c97f Localize address placeholders 2013-03-12 11:19:45 -07:00
John Firebaugh a5885ce3c2 Localize preset form labels 2013-03-12 11:19:45 -07:00
John Firebaugh 0be66fabf6 alpha3 2013-03-12 10:09:10 -07:00
Saman Bemel-Benrud 5e35bc87d7 cleaning up presets. 2013-03-11 20:32:25 -04:00
John Firebaugh 68cc99c412 Disable Move operation on incomplete relations (fixes #972) 2013-03-11 16:43:06 -07:00
John Firebaugh 113ae58de8 Fix up tests 2013-03-11 15:45:27 -07:00
John Firebaugh 9f5ba8342d Convert DragNode to a mode
This makes the CSS more consistent and makes fixing #953
easier. Also, dragging now clears the selection and closes
any operations menu, which is good.

There's still a minor Chrome bug: it doesn't refresh the
cursor when the .behavior-hover class is removed.
2013-03-11 15:45:27 -07:00
Ansis Brammanis 4c45ab1787 Operation tooltips are absolutely positioned 2013-03-11 17:52:49 -04:00
Ansis Brammanis 79ae138a19 add shorcuts to geocoder/background tooltips 2013-03-11 17:12:23 -04:00
Ansis Brammanis 057051f906 fix mousedown on combobox caret 2013-03-11 16:59:18 -04:00
Ansis Brammanis f74dc5f229 clicking on combobox caret behaves the same as input 2013-03-11 16:35:45 -04:00
Saman Bemel-Benrud 86518a071b minor cleanup of inspector. 2013-03-11 16:11:47 -04:00
John Firebaugh 7c122f1ee0 More keydown hacks (fixes #923) 2013-03-11 13:06:58 -07:00
Ansis Brammanis 6129fbf4f5 prevent creation of ways with duplicate segments or repeated nodes 2013-03-11 16:00:24 -04:00
John Firebaugh ab561ff198 Better way to prevent snapping to area fill
This also prevents are hover behavior during node dragging,
while allowing snapping to vertex fill.
2013-03-11 12:29:00 -07:00
Saman Bemel-Benrud 30952ef2c9 starting to refine preset styles. 2013-03-11 15:03:34 -04:00
Ansis Brammanis 00464b44b2 combobox mousedown now toggles options
fixes #958
2013-03-11 12:07:14 -04:00
Ansis Brammanis 1cf35eeaf3 Fix hiding geocoder and background
fixes #959
2013-03-11 11:01:25 -04:00
John Firebaugh 8c79d9672e Alternate SVG sprite technique for operations (fixes #956) 2013-03-10 20:02:18 -07:00
Ansis Brammanis 8406b7de80 use capture for esc in select mode
so that the mode can be escaped even if
a text input is focused
2013-03-10 21:27:49 -04:00
John Firebaugh 711b867b61 Render waterway=riverbank as area 2013-03-10 18:25:25 -07:00
Ansis Brammanis 512fe877b7 fix combobox position on scroll
fixes #948
2013-03-10 15:53:35 -04:00
Ansis Brammanis 9cb2fb13b5 use cemetery pattern for graveyards 2013-03-10 14:44:46 -04:00
Ansis Brammanis cef5726813 update index, style tweaks 2013-03-10 01:45:14 -05:00
Ansis Brammanis 0c6da9549a fix 'other' preset 2013-03-10 01:42:15 -05:00
Ansis Brammanis cb887f47e3 fix updating tags from taglist
fixes #965
2013-03-10 01:40:47 -05:00
Ansis Brammanis 6440905e36 add transparency for highway tunnels 2013-03-10 00:45:22 -05:00
Ansis Brammanis 335265590f add radio preset input 2013-03-10 00:22:05 -05:00
Ansis Brammanis a1a77d25cd fix name input 2013-03-10 00:21:42 -05:00
Ansis Brammanis d736cddccd add defaultcheck input type 2013-03-09 23:12:21 -05:00
Ansis Brammanis 1aefc6e7c5 elminate preset switch 2013-03-09 20:11:01 -05:00
Ansis Brammanis 609e8b9119 refactor preset inputs 2013-03-09 18:30:54 -05:00
John Firebaugh af7fb41d4b Don't use hand as placeholder icon (#942) 2013-03-09 09:34:22 -08:00
John Firebaugh da37237955 Add man_made presets 2013-03-09 09:22:56 -08:00
John Firebaugh 60ff6fc021 Use maki icons for points (fixes #881) 2013-03-08 20:22:06 -08:00
Tom MacWright dae8a67e68 Merge branch 'master' of github.com:systemed/iD 2013-03-08 16:53:40 -05:00
Tom MacWright fe2c57d7f4 Remove rowselect, build data with imagery, use nicer json formatting. 2013-03-08 16:53:26 -05:00
John Firebaugh b653f00215 Merge remote-tracking branch 'origin/master' 2013-03-08 13:24:28 -08:00
Tom MacWright 1294c972d0 Add dimensions, improve make situation for presets. 2013-03-08 16:18:20 -05:00