Commit Graph

2285 Commits

Author SHA1 Message Date
Martin Raifer dabbd89e5d suppress autocomplete for taginfo results if field has static values
fixes #9898

Fixes a problem that occurs because the order of the field `options`
can be in general different from the order returned by taginfo
(taginfo sorts by usage, while presets typically are sorted alphabetically),
causing different values to be potentially selected for autocomplete values.
As the taginfo results typically come in a few moments delayed, this can
lead to confusing behaviour.

This solves it by just not reattempting an autocomplete using the taginfo
results, if a field has static options available.
2023-11-08 10:42:09 +01:00
Martin Raifer 5d00f604ae show source field for changesets by default in the upload form 2023-10-10 16:03:09 +02:00
Martin Raifer c297d9bc18 fix name clash which was overriding an existing event handler
fixes #9829

fixes regression from d7902e1388
2023-08-11 15:11:25 +02:00
Martin Raifer cf2e4c990e lint 2023-08-09 18:24:16 +02:00
Martin Raifer 97fcb18d2a switch to (vegbilder's) zoomable plane photo viewer 2023-08-09 11:54:13 +02:00
Martin Raifer 471354af4f add list of loaded local photos 2023-08-08 17:12:35 +02:00
Martin Raifer 634ce10d24 add proper local photo strings, enable layer switcher checkbox 2023-08-07 16:14:32 +02:00
Martin Raifer 1572835a48 move local photos to "Photo Overlays" section 2023-08-07 11:52:33 +02:00
Martin Raifer 8c1b185fb3 remove unused imports/vars, fix code indentation, lint 2023-08-07 11:09:16 +02:00
Martin Raifer 884874dedc Merge branch 'develop' into gsoc_2022/explore_iD 2023-08-07 10:38:10 +02:00
Martin Raifer e8703e6bb6 Merge remote-tracking branch 'noenandre/vegbilder' into develop 2023-08-07 10:31:07 +02:00
Kyle Hensel d01112372b don't suggest discardable tags in the raw tag editor 2023-08-06 15:07:35 +12:00
Martin Raifer a2d3cf8f9a fix jumping cursor while editing in some input fields
fixes #9233
2023-08-03 16:49:37 +02:00
Martin Raifer 57ca36227b fix clearing of contents of some input field when the tag is removed
e.g. when using the trash can icon on the UI field
2023-08-02 17:54:48 +02:00
Martin Raifer d7902e1388 only show regional street-level photo providers in the available region
and disable selection checkbox if not zoomed in enough to load the photos
2023-08-02 16:35:56 +02:00
Martin Raifer 13300026e3 Merge branch 'develop' into vegbilder 2023-08-01 17:09:21 +02:00
sezerbozbiyik d35aff7ebb Merge branch 'develop' into add_mapilio_data 2023-07-21 14:40:58 +03:00
Martin Raifer 46a2d6365f show tag reference info for the currently filled-in tag value, closes #9786 2023-07-21 11:03:28 +02:00
Martin Raifer 61af54c069 fix combo field's dropdown when tag reference info is displayed
show it immediately after the input field instead of after the tag documentation text
2023-07-21 10:44:21 +02:00
Martin Raifer 3159c87ae1 disable deprecated marked options
to get rid of warnings in the console
2023-07-21 09:34:20 +02:00
Martin Raifer 7b622e040b Merge branch 'develop' into vegbilder 2023-07-20 17:21:45 +02:00
Martin Raifer d0e061c472 don't hardcode padding constanst, add changelog 2023-07-20 17:15:21 +02:00
Martin Raifer 9bd5817ecc don't crash on invalid identifiers
fixes a bug where the link button would not be correctly disabled on invalid identifier values

(regression in 7015fae91c)
2023-07-17 19:40:36 +02:00
Martin Raifer 7b44dfaa1b fix sorting of nearby streets in address field dropdown 2023-07-17 14:09:36 +02:00
sezerbozbiyik 04581bd7c3 Merge branch 'develop' into add_mapilio_data 2023-07-12 15:15:20 +03:00
Martin Raifer 1c1086662e fix crash when a multisel. contains empty&non-empty numeric vals, fixes #9739
this is a regression/bug in 559a4ba
2023-07-07 18:22:18 +02:00
Martin Raifer 85affbadc8 lint 2023-07-07 13:34:08 +02:00
Martin Raifer ea054a00a5 fix bug in "lang=badvalue" handling for wikidata api
see https://github.com/openstreetmap/iD/pull/9638#issuecomment-1623497481
2023-07-07 12:49:55 +02:00
Martin Raifer 9595e997e9 Merge branch 'develop' into addr_place 2023-05-26 20:37:54 +02:00
Martin Raifer f19a55fa13 Add support for icons on multiCombo/semiCombo fields (#9433) 2023-05-26 20:35:12 +02:00
Martin Raifer 53f77fb852 accept raw number input also for roadspeed/roadheight fields 2023-05-26 19:34:32 +02:00
Martin Raifer 2b64d70352 generalize implementation to skip input value update
when contents are "equivalent" in a given context, e.g. for numeric values with potentially different formatting in number fields
2023-05-26 19:24:10 +02:00
Martin Raifer e0f11af2b2 also allow "raw" numbers to be input in numeric fields
when a user enters a decimal number using the "international"/English/OSM-raw-data formatting (e.g. as in `0.5`), it is parsed using the basic, non-localized, number parser. In such cases, the content of the input field should not be overwritten with the localized formatting, as that would cause unexpected glitches and make editing harder (e.g. when thousands-grouping characters seemingly "magically" disappear or appear while typing).

see https://github.com/openstreetmap/iD/pull/8769/#pullrequestreview-1324246437 ff.
2023-05-26 18:38:16 +02:00
sezerbozbiyik 9876e92377 add hover and click event 2023-05-26 18:16:49 +03:00
Martin Raifer b266ec57ad treat "empty" numbers in semicolon separated "list" as invalid 2023-05-26 15:00:10 +02:00
Martin Raifer 6d01c05f76 allow numbers to be input in "raw" format 2023-05-26 13:44:50 +02:00
Martin Raifer 249771d747 fix variable declarations 2023-05-26 13:25:59 +02:00
Martin Raifer 6c362b6517 Merge branch 'develop' into 1ec5-number-field-format-3615 2023-05-26 13:06:09 +02:00
Martin Raifer 43784e2eff take entity loc into account when resolving fields via parent preset, fixes #9524
this necessary when a regional preset (e.g. from NSI) is supposed to inherit fields from a parent preset, but the direct parent does NOT apply at the location of the entity to be added/edited. In that case we need to search for a potential regional variant of the parent preset.
2023-05-25 19:19:09 +02:00
Martin Raifer 28630ae9fc don't repeat values from multi-selection in dropdown
as their state can now been toggled using the checkbox in the chip
2023-05-25 18:47:30 +02:00
Martin Raifer 805becfe3b support no and "other" states of options of multiCombo/manyCombo fields
closes https://github.com/openstreetmap/id-tagging-schema/issues/895 and #7427
2023-05-25 18:17:00 +02:00
Martin Raifer 559a4ba728 support input fields with multiple tag keys
requires upstream changes from tagging-schema v6.3, see https://github.com/openstreetmap/id-tagging-schema/issues/905
2023-05-23 15:22:58 +02:00
Martin Raifer bd98ff904b restrict taginfo suggestions in raw tag editor to ones which match the input string
this additinoal filtering is needed because of the caching performed by the services/taginfo.js module.
2023-05-16 17:10:30 +02:00
Martin Raifer 9779f320a8 Properly handle case sensitive tags in taginfo suggestion in raw tag editor, fixes #9640 2023-05-16 17:06:39 +02:00
Martin Raifer a35653d35d use all available option strings when setting value
this fixes where tag values of fields with referenced strings can become corrupted when the sub-field has restricted `options`, and an unavailable option is entered manually into the field.

important for openstreetmap/id-tagging-schema#891
2023-05-11 15:06:37 +02:00
Martin Raifer 140e56768e fix hiding of "Add" input on comboboxes with fixed options
the check for this needs to be done after the available options are actually refreshed
2023-05-02 14:10:48 +02:00
Martin Raifer 24e514fa99 defer loading of static combo options
fixes a bug where `multi/many/semiCombo` options are not selectable immediately after they were removed from a field, when the field does not use taginfo to fetch options
2023-05-02 13:01:32 +02:00
Martin Raifer 9aa28faf4a only offer admin_level>8 for addr:place
as admin_level=8 is for `addr:city`
2023-04-30 21:07:15 +02:00
Martin Raifer 6f9bb116f3 fix logic bug, make condition more readable 2023-04-30 20:56:51 +02:00
Martin Raifer aca88bf702 fix bug in getting nearby postcodes 2023-04-28 19:55:43 +02:00