Commit Graph

1991 Commits

Author SHA1 Message Date
Bryan Housel 68be75af09 Assumption about mozInputSource = 1 was incorrect
Removing this conditional allows 2 finger panning on Firefox
2019-01-15 14:46:23 -05:00
Quincy Morgan 4252c5cb36 Presets no longer inherit fields for keys that define them 2019-01-15 13:52:03 -05:00
Quincy Morgan 4b2c380b18 Changed preset field inheritance to target specific presets rather than just the parent preset 2019-01-15 13:07:58 -05:00
Quincy Morgan ae7c099c8a Moved field inheritance resolution from the data build to the preset initialization
Removed the data build check for duplicate values between fields and moreFields
Renamed the shop field from Type to Shop Type
Renamed the beauty field from Shop Type to Beauty Specialty
Added the brand field to the shop preset under moreFields
2019-01-15 09:53:26 -05:00
Bryan Housel 59795e41ab Don't style the active vertex in line drawing mode as a large endpoint
(closes #5711)
2019-01-14 17:30:20 -05:00
Quincy Morgan 92e514f891 Make the preset browser appear upon adding a new relation.
Closes #5656
2019-01-14 16:25:43 -05:00
Bryan Housel 3090b5c875 Merge pull request #5708 from iriman/context-menu-rtl
[RTL] place tooltip under #id-container to inherit rtl
2019-01-14 09:07:12 -05:00
iriman bc9a64058f [RTL] place edit menu under #id-container to inherit rtl 2019-01-14 15:50:31 +03:30
iriman 7b53d0aa5a [RTL] pick appropriate class for .field-help-title > h2 2019-01-13 19:44:49 +03:30
Bryan Housel 09e574983f Don't call formFields.tagsChanged() when presetEditor.tags change
(closes #5690)

This change also makes sure to use the latest copy of the entity in
field.isAllowed() to ensure the prerequisite field check works
and fieldsArr is filtered properly for #5583
2019-01-11 17:42:34 -05:00
Bryan Housel b575ee8500 Move formFields klass from an argument to a state variable
(maybe needed in case render can get called different ways)
2019-01-11 13:56:16 -05:00
Bryan Housel 55a92ca79d Add closed:note changeset tag for closed OSM notes 2019-01-11 10:14:55 -05:00
Bryan Housel 5ebe0976fe Add closed:keepright changeset tag for closed issues
The issues are written as `schema:error_id` and semicolon delimited
e.g.  `closed:keepright=56:102661142`
closes this issue:
https://www.keepright.at/report_map.php?schema=56&error=102661142
2019-01-10 23:27:55 -05:00
Bryan Housel 623f96449e z-sort errors above warnings 2019-01-10 21:47:37 -05:00
Bryan Housel ae8dffa43c Improve URL error messages 411, 412, 413 2019-01-10 21:35:13 -05:00
Bryan Housel 7f321abbaf Add links to the main error object in KeepRight error messages
re: https://github.com/openstreetmap/iD/issues/5679#issuecomment-452281850
2019-01-10 17:38:09 -05:00
Bryan Housel 98c08a02ef Add "zoom to this" quicklink and keybind for keepright editor
(re #5169)
2019-01-09 22:59:44 -05:00
Bryan Housel 9282a51795 Add "zoom to this" quicklink and keybind for data editor
(re #5169)
2019-01-09 22:49:51 -05:00
Bryan Housel 6efbbb8aa3 Add "zoom to this" quicklink and keybind for note editor
(closes #5169)
2019-01-09 22:24:52 -05:00
Bryan Housel 9c190e83e9 Add quickLinks to preset editor, zoom to selected feature 2019-01-09 21:56:08 -05:00
Bryan Housel 5c6406ea63 Remove section borders from inspector
There is enough separation with the disclosure headings that we
don't need to break the sidebar up with lines
2019-01-08 14:04:07 -05:00
Bryan Housel 6c5ea96ab6 Adjust generic name validation to better check tag values
e.g. "name=Fast Food" should match "amenity=fast_food"
2019-01-08 13:43:40 -05:00
Bryan Housel 5f2d80c7a6 pacify eslint 2019-01-08 10:58:47 -05:00
Bryan Housel 5f20218f1f Add validation warning for generic names
(closes #5590)
2019-01-08 02:15:28 -05:00
Bryan Housel 528cbb29e1 Store the transform and selectedIDs with the rest of the history
(closes #5664)
2019-01-08 00:36:41 -05:00
Bryan Housel d9015baa47 Improve links in KeepRight error messages
(re: #5679)

Also move the localizeable string dictionary to data/keepRight.json
2019-01-07 16:10:44 -05:00
Bryan Housel 4ed2858cc5 Explicitly include '?' as a fallback key for keyboard shortcuts
(closes #5675)

This allows for a localized version of the key,
but iD will still respond to the '?'
2019-01-07 11:39:12 -05:00
Bryan Housel 826f66a91b Unique values for key codes moved to utilKeybinding, uiShortcuts
This lets us supply lists of keys which might contain duplicates, but will be
made unique.  For example: [t('sidebar.key'), '`', '²']
'sidebar.key' may be one of the other choices, but will be deduplicated.
2019-01-07 11:12:24 -05:00
Bryan Housel 55d2dddb70 Keybind all of _uniq([t(sidebar.key), '`', '²']) to toggle sidebar
(closes #5663)
2019-01-06 00:33:35 -05:00
Minh Nguyễn 3c82174f03 Capitalize first letter of KeepRight error detail 2019-01-05 00:32:45 -08:00
Bryan Housel 7986fcbfbf Merge branch 'keep-right_QA' 2019-01-04 21:37:19 -05:00
Bryan Housel 48cc06fdbb Adjust distance from KeepRight marker and underlying geometry
Makes it easier to select the point/vertex that the error is about.
2019-01-04 21:28:35 -05:00
Bryan Housel fadd8e2e8a Switch KeepRight markers to use touch targets
This makes it easier to select the KeepRight issue and avoid selecting
the OSM geometry underneath them
2019-01-04 21:17:38 -05:00
Bryan Housel cd9203975d Use touch targets for notes, fix a few bugs with note dragging
(closes #5213)
2019-01-04 15:48:39 -05:00
Bryan Housel d0343c9fa7 Reintroduce some error localization, fix some nagging parse issues 2019-01-03 18:16:28 -05:00
Bryan Housel 35f8078f98 Reduce number of marker colors, increase contrast, tweak language 2019-01-03 15:30:36 -05:00
Bryan Housel 46ebce2d6f Fix error reporting urls and make sure sidebar not showing stale data 2019-01-03 11:37:14 -05:00
Bryan Housel 9e6497b549 Update or remove the error after POSTing changes to server 2019-01-03 01:39:40 -05:00
Bryan Housel 69ce5ee964 Remove user details and auth and adjust button texts for commenting
The user details and auth are not needed
because KeepRight accepts only anonymous updating
2019-01-03 00:07:55 -05:00
Bryan Housel ee92758801 KeepRight only allows one anonymous comment per issue - simplify 2019-01-02 16:15:21 -05:00
Bryan Housel 4494c3ab9c Fix comment box style, remove unused vars for eslint 2019-01-02 15:46:25 -05:00
Bryan Housel 9557c0204a Relax some more regex for tag parsing, (to support 'key=*')
Also implement parsing error 231 - layer conflict
2019-01-02 13:39:21 -05:00
Bryan Housel 2ec02f369f Simplify regex matching - goal is to have fewer, simpler rules 2019-01-02 11:46:13 -05:00
Bryan Housel d54d5bfd89 Move title into keepright error header 2018-12-29 17:55:40 -05:00
Bryan Housel 192b4da9e6 Fix the strings I broke in 3785ffb15 2018-12-29 17:30:35 -05:00
Bryan Housel 4f0a608439 Merge pull request #5637 from openstreetmap/5618
fix autocomplete combobox bug
2018-12-26 15:15:29 -05:00
Bryan Housel bc72c387e4 Merge pull request #5647 from nyurik/osm_wikibase
OSM Multilingual data directly from wiki (wikibase data items)
2018-12-26 14:48:39 -05:00
Yuri Astrakhan 9f7f4aa3fc Fix language fallback processing, caching bug. 2018-12-23 01:57:26 -05:00
Tobias 5009edee4b Move variable to the top of the file and reuse
As suggested in https://github.com/openstreetmap/iD/pull/5650#issuecomment-449589375
2018-12-23 07:38:00 +01:00
Yuri Astrakhan 8b931f3e6c Use new message to encourage editing and translation 2018-12-22 15:03:22 -05:00