Commit Graph

145 Commits

Author SHA1 Message Date
Bryan Housel
e377270372 WIP: introduce validatedGraph, try on mode change not history change 2019-04-06 13:39:19 -04:00
Bryan Housel
1bcc0f613c WIP: fix caches, replace id() function with plain id property 2019-04-05 17:41:04 -04:00
Bryan Housel
78acd999c8 WIP: switch from validating everything to validating differences 2019-04-05 13:29:57 -04:00
Bryan Housel
f17ebee402 Use Set, simplify util functions to collect entities with children 2019-04-05 11:05:04 -04:00
Bryan Housel
8b1c0551cc WIP: understand state held by the validator, avoid translations
- Make sure all state variables prefixed with `_`
- Add explicit `init`/`reset` methods
  (graph/entity refs should never persist through a save to OSM)
- Thinking of how best cache validation results
2019-04-05 09:28:36 -04:00
Bryan Housel
561ffc402a Remove annotatedChange events (we'll replace with something else) 2019-04-03 11:56:56 -04:00
Bryan Housel
d5abe468b9 Remove rest of the lodash iterators: map, reduce, forEach
(re: #6087)
2019-03-29 15:14:21 -04:00
Bryan Housel
0d79e3e616 Remove lodash cloneDeep and forOwn from context.js
(re: #6087)

Tests in Phantom run twice as fast now!
2019-03-29 12:57:37 -04:00
Bryan Housel
0edd10001e Removing more lodash: isEmpty, isNumber, some map/reduce/forEach
(re: #6087)
2019-03-27 13:32:35 -04:00
Bryan Housel
ff4f8f005f Remove lodash find and findIndex
(re: #6087)
2019-03-22 17:31:41 -04:00
Quincy Morgan
7d0080a642 Persist the photo overlay layers via the URL query string (re: #5813) 2019-03-14 16:48:08 -04:00
Quincy Morgan
c65a4d038e Add photo overlay filter options for hiding flat and pano photos (close #5433) 2019-03-14 14:24:21 -04:00
Quincy Morgan
213d0ee3e8 Move preset favoriting functions from core/context.js to presets/index.js
Make recent presets persistent and compatible with favorite presets
2019-03-07 16:49:29 -05:00
Quincy Morgan
ba185d2ee6 Make Point, Line, and Area the default favorite presets 2019-03-07 13:32:14 -05:00
Quincy Morgan
efac17810c Check for valid indices when reordering favorites 2019-03-07 11:22:19 -05:00
Quincy Morgan
c3d1dc43d4 Add valid geometry check for saved favorite presets 2019-03-07 11:17:41 -05:00
Quincy Morgan
a38da25dc4 RTL layout support for previous commit
Add check to make sure saved favorite presets are valid
2019-03-07 11:16:01 -05:00
Quincy Morgan
78590466ba Merge branch 'master' into add-feature-search-bar 2019-03-06 15:50:31 -05:00
Bryan Housel
6da2ba7b9d Make sure pause/resumeChangeDispatch can be called multiple times 2019-03-06 15:41:12 -05:00
Quincy Morgan
2618565826 Make favorites list last in, first out 2019-03-06 08:49:17 -05:00
Quincy Morgan
776c0556e1 Add drag-and-drop reordering of favorite presets 2019-03-05 20:21:54 -05:00
Quincy Morgan
e22f3359f5 Allow up to 10 favorite presets
Show favorite preset keyboard shortcut in tooltip
2019-03-05 12:27:42 -05:00
Quincy Morgan
b302d853ac Fix issue where the favorite preset button could be stale
Use first in, first out favoriting order
2019-02-27 13:13:15 -05:00
Quincy Morgan
a3424aa4b1 Merge branch 'master' into squash-favorite-preset 2019-02-26 14:25:34 -05:00
Quincy Morgan
0fa7e757b1 v2.14.3 2019-02-26 13:45:53 -05:00
Quincy Morgan
70e88ee9af v2.14.2 2019-02-21 17:01:00 -05:00
Quincy Morgan
1bde3ba63f v2.14.1 2019-02-20 18:23:47 -05:00
Quincy Morgan
1f1e88314d v2.14.0 2019-02-20 16:19:36 -05:00
Brian Hatchl
d8531c88bb fix lint complaints 2019-02-20 15:44:16 -05:00
Brian Hatchl
1faa6ad839 Favorite preset 2019-02-20 15:23:58 -05:00
Quincy Morgan
46f3cea33a Reorganize validation code
Rename IssueManager to coreValidator
Rename disconnected highway to disconnected way
Rename highway almost junction to almost junction
Rename mapcss checks to maprules
Rename deprecated tags to deprecated tag
2019-02-01 11:20:51 -05:00
Quincy Morgan
09bc2a6e6c Merge branch 'master' into validation 2019-01-30 16:44:14 -05:00
Bryan Housel
7138acc652 Properly export areaKeys, fix preset and maprules tests 2019-01-30 15:29:37 -05:00
Quincy Morgan
5b93ee0f7a Run validation upon data restore after page reload 2019-01-30 13:40:02 -05:00
Quincy Morgan
226c4f88e1 Re-run validation automatically upon merging fetched remote data into the history 2019-01-29 11:10:12 -05:00
Quincy Morgan
0866110d77 Merge branch 'master' into validation 2019-01-29 09:16:06 -05:00
Quincy Morgan
02ccd7cfd6 v2.13.1 2019-01-28 17:38:05 -05:00
Quincy Morgan
e69f2a0389 Merge branch 'master' into validation 2019-01-23 13:15:33 -05:00
Quincy Morgan
24b6e9aeec v2.13.0 2019-01-23 11:33:23 -05:00
Bryan Housel
a873c0f2ca Remove unused, add maprules documentation 2019-01-23 11:08:19 -05:00
Quincy Morgan
536ee2e786 Validations now update instantly upon an annotated graph change 2019-01-14 15:19:00 -05:00
Quincy Morgan
11b2102761 Merge branch 'master' into validation
# Conflicts:
#	data/core.yaml
#	dist/locales/en.json
#	modules/ui/commit_warnings.js
#	modules/ui/entity_editor.js
#	modules/util/index.js
#	modules/util/util.js
#	modules/validations/index.js
#	modules/validations/many_deletions.js
#	modules/validations/missing_tag.js
2019-01-14 10:13:56 -05:00
Bryan Housel
9c190e83e9 Add quickLinks to preset editor, zoom to selected feature 2019-01-09 21:56:08 -05:00
Andrew Wong
5971bbebb7 Added more validation tests 2018-12-20 15:39:26 -05:00
Andrew Wong
6e749c70ef listening to user generated history changes for validation 2018-12-19 17:28:34 -05:00
Thomas Hervey
31f35b0389 added basics to sidebar 2018-12-19 13:35:26 -05:00
Andrew Wong
30f25c6e8d added IssueManager
- IssueManager performs validation on the current graph and also
   stores the issues and notifies listeners when the issues changed
2018-12-18 17:52:23 -05:00
Bryan Housel
5a2049b421 Drop extra whitespace, make sure service exists before using it 2018-12-18 15:38:53 -05:00
Max Grossman
e0e6f5b918 remove non-used util class 2018-12-17 12:52:21 -05:00
Max Grossman
d87b1822f7 add/make visible weakly matched presets 2018-12-14 15:42:25 -05:00