Commit Graph

16 Commits

Author SHA1 Message Date
Bryan Housel
3896b2282f Remove lodash isNaN, isNumber, isString, bind, uniqBy
(re: 6087)
2019-03-27 23:11:45 -04:00
Bryan Housel
39b3f1df68 Avoid creating comboboxes
(closes #5568)

Several strategies in here:
- Move uiCombobox() from inside the render function to class variable
- Don't render stuff like the raw tag editor when it's collapsed
- Don't show as many fields/combos on hover
- Don't instantiate fields (like universal/more) until they're actually shown
- Bind the combo on enter selection not on update selection
2018-12-11 16:07:00 -05:00
Bryan Housel
15a54cab17 Use context.container instead of passing it in 2018-12-10 14:14:27 -05:00
Bryan Housel
e5dedeff8b Move lib/d3.combobox.js -> ui/combobox.js
As with other things from this lib/ folder, little original code remains
and turning these things into reusable d3 plugins is not a priority.
2018-12-10 12:38:21 -05:00
Bryan Housel
470835b38f Extract all graphics from iD sprite, reassemble with svg-sprite
All iD sprite graphics are now prefixed with `iD-`
Also includes support for sending the preset logos to taginfo
2018-06-08 16:06:46 -04:00
Bryan Housel
d8f6fafe74 Don't add empty source tag on a changeset
(closes #4993)
2018-04-18 17:33:56 -04:00
Bryan Housel
3d13620705 Convert lodah-es and d3 to named imports for ui 2017-09-26 11:22:43 -04:00
Bryan Housel
4cf357f61a Add code to extract hashtags from changeset comment 2017-08-16 00:30:34 -04:00
Bryan Housel
09a661c718 Restore "good changeset comments" link in tag-reference section
Also includes a bunch of css cleanups for the tag-reference section
to fix style for readonly raw-tag-editor rows and adjust margin widths
2017-08-15 13:12:57 -04:00
Bryan Housel
7563f3ac16 Refactor duplicate form-field code to uiFormFields 2017-08-15 09:35:57 -04:00
Bryan Housel
194b56c0f0 Restore the comment google warning 2017-08-14 22:59:15 -04:00
Bryan Housel
e6eff907a2 Restore the previous changeset dropdown 2017-08-14 12:46:10 -04:00
Bryan Housel
4971a20409 Pacify eslint 2017-08-13 23:42:06 -04:00
Bryan Housel
9b37ac7b6c Fix errors with changeset fields and warnings, improve styles 2017-08-13 23:25:37 -04:00
Bryan Housel
e0266da083 WIP: add changeset fields and refactor 2017-08-12 14:26:34 -04:00
Bryan Housel
439eed4b39 WIP: refactor uiCommit into sections, introduce uiChangesetEditor
uiCommit is getting kind of big as we add more to the commit pane.

I'm going to split it up and put the field rendering code into a separate
module, similar to how uiEntityEditor embeds uiPresetEditor for the fields.

This allows us to add a few more fields that users can set on their changesets
(like hashtags, source), and even hide them under a "Add field" dropdown.
2017-08-11 17:17:46 -04:00