Commit Graph

3653 Commits

Author SHA1 Message Date
Quincy Morgan a7e16a5625 Show the number of unique nodes instead of the aggregate for the selection in the measurement panel (re: #7329) 2020-06-08 17:07:26 -04:00
Quincy Morgan 2f2e0dcb94 Show combined length, area, and node count in the measurement panel for multiselections (close #7329) 2020-06-08 16:47:03 -04:00
Quincy Morgan 8b258d2cbd Load the maximum nodes per way value from the OSM API and add a getter to the service object
Disable the Merge operation if the resultant way would have more than the maximum number of nodes (close #6030)
Simplify some code in operationMerge
2020-06-08 14:38:49 -04:00
Quincy Morgan bf7b30ace9 Fix unreleased regression where OSM notes were being parsed as JSON and thus not loading (re: #7188) 2020-06-08 13:19:46 -04:00
Quincy Morgan 2e5e3791c5 Disable the straighten operation for selections that are already straight (close #7658) 2020-06-08 11:58:10 -04:00
Quincy Morgan 61b3aaafd2 Autofocus new note descriptions in the UI code instead of the mode code (re: #7680) 2020-06-08 11:42:29 -04:00
Quincy Morgan fd41e5fd75 Add specific error feedback for disabled straighten operation for multiple selected features 2020-06-08 11:16:25 -04:00
Quincy Morgan c85fbf34f9 Underscore function scope variables in modeSelectNote 2020-06-08 10:30:04 -04:00
Quincy Morgan def3a373a7 Autofocus the comment field when adding a new OSM note (close #7680) 2020-06-08 10:26:16 -04:00
Quincy Morgan e8a227fc59 Allow straightening a selected line between two points if the two points are visible, regardless of how long the line is 2020-06-08 10:08:52 -04:00
Quincy Morgan cee4b0a4da Give several functions more descriptive names 2020-06-08 09:50:13 -04:00
Quincy Morgan 632849b509 Show the inspector instead of the preset list when selecting an untagged vertex with a parent relation 2020-06-07 20:42:42 -04:00
Quincy Morgan ab3717bbc8 Disable the Straighten operation when not enough of the selection is visible (close #7675)
Add specific straighten tooltip and annotation labels for multiple selected lines
2020-06-05 14:59:27 -04:00
Quincy Morgan f14577b2d0 Fix lint warning 2020-06-05 14:32:59 -04:00
Quincy Morgan 02f8849bd0 Properly disable more operations for single nodes that aren't visible 2020-06-05 14:22:50 -04:00
Quincy Morgan 251f9825f4 Fix extent logic change from 28bd985a31 2020-06-05 14:19:37 -04:00
Quincy Morgan 28bd985a31 Prevent disconnecting nodes that aren't mostly visible
Return 1 for geoExtent.percentContainedIn when caller is a zero-area extent contained within the argument extent
Prefix function-scope operationExtent variables with underscores
2020-06-05 13:54:41 -04:00
Quincy Morgan 790f90c11d Show "not visible" disabled reason over "connected to hidden" in the extract operation when both are applicable, in accordance with other operations 2020-06-05 13:12:51 -04:00
Quincy Morgan fac0eea761 Use eased zoom when selecting features from search results and zoom to their full extent 2020-06-05 12:12:37 -04:00
Quincy Morgan 3506389d83 Fix JS error when zooming to lat/lon values coded in search bar (close #7670) 2020-06-05 12:06:21 -04:00
Quincy Morgan d22d3bfc66 Update for string.fromcodepoint v1.0.0 API 2020-06-05 11:08:34 -04:00
Quincy Morgan fcc21ce856 Update node-diff3 API calls for v2.0.0 2020-06-04 19:16:49 -04:00
Quincy Morgan 6128c6514f Enable the Extract operation for multiple selected extractable features (close #7600)
Allow extracting vertices that are `via` or `location_hint` relation members
2020-06-04 16:35:25 -04:00
Quincy Morgan 572ce0a787 Make sure horizontal-only scroll events can be translated into map pans (close #7659) 2020-06-04 13:29:45 -04:00
Quincy Morgan 6c2b097eb7 Enable disconnection of multiple selected features from each other, if connected, and otherwise from everything (close #7652)
Add specific descriptions for a wider range of disconnection scenarios
2020-06-03 14:51:31 -04:00
Quincy Morgan 0cd1b40c57 Make sure clicking the first node finishes drawing when drawing any closed way 2020-06-02 16:57:14 -04:00
Quincy Morgan 5eb0fc3e0e Update comments 2020-06-02 15:58:35 -04:00
Quincy Morgan 1d377227d0 Enable dual-pointer multiselection even if neither feature is selected yet
Don't do dual-pointer multiselection if a pointer has moved too much since it went down
Properly switch the selection when right-clicking on an unselected feature during a multiselection
2020-06-02 15:44:58 -04:00
Quincy Morgan 49526a7a67 Fix JS error upon changing addablePresetIDs after initial load
Accept addablePresetIDs as an array
Add code tests for invalid preset IDs in addablePresetIDs
2020-06-02 11:19:30 -04:00
Quincy Morgan 7fe82444c2 Make map pointer targets larger for pen and touch input (close #7643) 2020-06-01 12:25:16 -04:00
Quincy Morgan 909690c87c Merge pull request #7642 from jgscherber/7640-use-correct-header-size
Header size didn't include padding above buttons
2020-06-01 09:33:41 -04:00
Jacob Scherber bfa1dbf8d4 remove trailing whitespace on line 2020-05-31 14:19:40 -07:00
Jacob Scherber 24ceda3d9c header size didn't include padding above buttons 2020-05-31 13:50:26 -07:00
Quincy Morgan 620d79bfc8 Reorganize the code for setting the mode class on the container 2020-05-29 17:18:10 -04:00
Quincy Morgan a78dc5a889 Simply default gesture cancelation and add additional safety check for IE 2020-05-29 13:08:13 -04:00
Quincy Morgan 87b4c34d1f Make sure the Wikipedia field reloads after the wiki language data is received 2020-05-29 11:37:22 -04:00
Quincy Morgan b3ece74807 Fix issue where the telephone field placeholders weren't localized 2020-05-29 10:57:17 -04:00
Quincy Morgan 2d02d452a9 Fix issue with the address field not displaying a localized format 2020-05-29 10:33:45 -04:00
Quincy Morgan 78a4b75e55 Fix regression where explicit addable presets were not populating the default preset list 2020-05-28 16:16:35 -04:00
Quincy Morgan 64096cbc67 Handle pointercancel events in behaviorDrag 2020-05-28 14:21:22 -04:00
Quincy Morgan 717f9ae5b7 Fix prior commit and add additional safety checks 2020-05-28 14:12:11 -04:00
Quincy Morgan 1214b2d5dd Preview the draw segment upon pointerdown on touchscreens unless it becomes invalid
Block creation of invalid geometries due to connecting to invalid sibling segments or nodes on the drawn way on touchscreens
2020-05-28 13:50:51 -04:00
Quincy Morgan 2264e4a6d7 Fix code tests 2020-05-28 11:45:49 -04:00
Quincy Morgan 79ceb96758 Fix several regressions to behaviorHover introduced in 38db23fab5 2020-05-28 11:33:47 -04:00
Quincy Morgan d8443d28d5 Detect and ignore erroneous mouse-type pointermove events sent after pointerup events on iOS when drawing 2020-05-28 11:13:09 -04:00
Quincy Morgan e2cd879c81 Account for canceled pointers in behaviorSelect 2020-05-27 16:55:04 -04:00
Quincy Morgan 0c8d237d17 Don't let down pointers trigger selection when raised after a long press 2020-05-27 15:54:39 -04:00
Quincy Morgan 38db23fab5 Extend behaviorHover to support multiple pointers 2020-05-27 15:07:23 -04:00
Quincy Morgan cb5365f743 Persist down pointer multiselection between browse/select mode transitions 2020-05-27 12:33:53 -04:00
Quincy Morgan 4646c11ff1 Continue multiselection while the triggering pointer is down even if the targeted feature is deselected 2020-05-27 11:33:32 -04:00