Commit Graph

4763 Commits

Author SHA1 Message Date
laigyu 2325de4662 update butotn logic 2024-04-12 18:37:26 +08:00
laigyu 6b8b41c2ff tooltip style change 2024-04-08 18:22:58 +08:00
laigyu d448b586ed revert error handler 2024-04-07 23:19:41 +08:00
laigyu 94e32a85b0 revert field button 2024-04-07 22:04:22 +08:00
laigyu 8bb1d0dfa9 Merge remote-tracking branch 'upstream/develop' into add-button-to-mapillary 2024-04-05 13:17:59 +08:00
Martin Raifer ee56b9c8ae render closed amenity=bicycle_parking ways as areas by default
fixes https://github.com/openstreetmap/id-tagging-schema/issues/1114#issuecomment-2018057194
2024-03-26 15:19:35 +01:00
Hirako 85278c35e4 Field: fix wikiURL by URL encoding it - and slight refactors (#10165)
* Field: fix wikiURL by URL encoding it - and slight refactors

* Field: fix wikiURL only encodeURIComponent instead of redundant full URL

* Field: refactors function to generate wikiURL, ensures anchor part is also URI encoded, ensures the anchor ref is not encoded, adds unit tests

* Field: refactors wikipedia URI encoding of the anchor logic, removes legacy anchorencode effort via try-catch that replaced percentage character with dots, adds unit further  tests, reduces exessive inlining
2024-03-21 00:42:08 -07:00
Martin Raifer 12b0528175 Upgrade closed ways with traffic_calming=island to area:highway=traffic_calming
addresses missing pieces for https://github.com/openstreetmap/id-tagging-schema/issues/1162
2024-03-15 21:12:31 +01:00
Asif Sheriff 1683313621 preserve rows with empty tag values in raw tag editor (#10151) 2024-03-15 01:13:07 +01:00
Martin Raifer 444c5835c9 hide forward/back button if there is no matching image
e.g. for the first/last photo in a sequence, or when there are gaps
2024-03-08 10:59:34 +01:00
Mattia Pezzotti a75eace135 Fix for Point Tutorial (#10129) 2024-03-07 23:38:51 +01:00
Martin Raifer 5d06d3b83e Merge pull request #10149 from openstreetmap/split-relation-members
Robust local splitting of ways which are part of (route) relations
2024-03-06 13:54:14 +01:00
Martin Raifer 20f53e5748 document algorithm inline, handle "junction=circular" like roundabouts 2024-03-06 13:46:22 +01:00
Martin Raifer d7aca27f41 minor code readibility refactoring 2024-03-05 17:20:04 +01:00
Martin Raifer d7111e20f5 add button to load a feature's relations fully (if incomplete), fixes #5420 2024-03-05 14:25:16 +01:00
Martin Raifer 296ce859cf allow splitting of closed roundabout for certain rel types 2024-03-05 14:23:02 +01:00
Martin Raifer 13d46b0578 typo 2024-03-04 23:37:29 +01:00
Tobias b72a089f35 Field: Fix html tag type of wikidata label (#10144)
The `span` need to be a `div` after https://github.com/openstreetmap/iD/pull/10127/files
2024-03-04 19:25:53 +01:00
Martin Raifer 82af60115d disalow splitting of closed roundabouts when they are part of a route
these cases are not covered by the splitting algorithm at the moment:
* typicall, only a part of the roundabout should be part of the resulting route
* when multiple routes meet at a roundabout coming from different angles, the roundabout must be split at any of those entry/exit point simutaneously, such that all routes remain correct

as a workaround, a mapper can remove the route relation(s) from the roundabout, split it accordingly and then re-add the respective parts to the relation(s) again.
2024-03-04 19:02:33 +01:00
Martin Raifer 7268a8538c handle closed roundabout ways like a single junction "point" 2024-03-04 19:02:32 +01:00
Martin Raifer 088db7ccc1 simplify boolean conditions 2024-03-04 19:02:32 +01:00
Martin Raifer 11dfbe804c fix splitting of (route) relation member ways
instead of fully re-sorting the whole relation every time a member is split, perform a local operation: This works under the assumption that the relation is already sorted properly. The new way is inserted into the relation before or after the existing member, depending on how the old/new way connect to their neighboring members.

for cases where two ways form a loop, a additional look-ahead is implemented to disambiguate the order
2024-03-04 19:02:31 +01:00
Martin Raifer cc920d3fba drop unused var 2024-03-02 15:43:56 +01:00
Martin Raifer 97442403cf drop validator which checks for old style multipolygons
these have long been [fixed](https://blog.jochentopf.com/2017-08-28-polygon-fixing-effort-concluded.html) in OSM

see wiki: https://wiki.openstreetmap.org/wiki/Old_style_multipolygons
2024-02-29 13:28:22 +01:00
Martin Raifer 8274384311 Fix validator suggesting to add empty *:wikipedia tags to NSI presets (fixes #10140) 2024-02-29 10:30:18 +01:00
Martin Raifer 075b881978 Merge remote-tracking branch 'mtmail/mutually-exclusive-tags-validator' into develop 2024-02-26 14:11:14 +01:00
Tobias ce51b33cf2 Improve combobox dropdown styling to give labels more room and readability (#10127)
* Fields: Break long lines in combo dropdown instead of ellipsis

Longer translations keys are not readable with ellipsis and the tooltip only shows the description (or fallback), not the title.

This change makes long use line breaks with small line height to make the whole text visible.

* Fields: Use table styles for rows to maximize available space

The flex box solution gave a lot of space to the label. This solution minimizes that space to give more space to the values dropdown.
2024-02-26 14:02:22 +01:00
marc tobias 277b5d4f45 new validator: mutually exclusive tags 2024-02-25 18:40:10 +01:00
Martin Raifer 85f4cc0316 don't reverse side tag of highway=cyclist_waiting_aid features, fixes #10128 2024-02-25 15:36:17 +01:00
Martin Raifer 96e6dc124f Show message about how to support OSM after a successful save, closes #10054
for example in form of a donation

this can be disabled by setting an env variable (`ID_SHOW_DONATION_MESSAGE=false`)

the icon is from https://uxwing.com/charity-donation-hand-love-icon/
2024-02-24 12:48:35 +01:00
Martin Raifer 17d1c27bec use https for Bing Maps API 2024-02-16 23:19:30 +01:00
Martin Raifer 83754e4a4a switch to Bing Maps API for Bing Streetside layer, fixes #10074
replaces the use of undocumented APIs for Microsoft's street level imagery service and gets rid of hardcoded values, e.g. for the `g` ("generation") parameter

see https://learn.microsoft.com/en-us/bingmaps/rest-services/imagery/get-imagery-metadata#get-streetside-metadata-centered-at-a-point for API docs

see also #10100
2024-02-16 18:29:23 +01:00
Martin Raifer 4829f8a1da drop *:wikipedia tags when selecting a NSI-based, fixes #9103 2024-02-16 14:32:58 +01:00
NaVis0mple 6b860b7da0 refactor the code
'_' change to '-'
2024-02-05 18:12:01 +08:00
NaVis0mple 01d650d450 Expand DMS format and fix sec rounding logic (#10066)
Most DMS format parsed by @mapbox/sexagesimal, 
add a expandable matcher and two new formats for coordinates in DMS format in search bar

example: `35 11 10.1 , 136 49 53.8` (D M SS format), or `35 11.168 , 136 49.896` (D MM format)
2024-02-02 15:26:47 +01:00
NaVis0mple 666bbbfbfc code style change 2024-02-02 17:07:26 +08:00
NaVis0mple b597cc1341 refactor the code 2024-02-02 16:30:52 +08:00
NaVis0mple cc10898a58 finish open the viewer button logic
button disable class reacts to photoviewer close
2024-01-29 17:38:29 +08:00
NaVis0mple 0ad46e0b72 Add error message in photoviewer when invalid id
and update input.js
2024-01-27 15:14:27 +08:00
Martin Raifer aaf89d7755 don't duplicate notes which have already been seen 2024-01-24 15:16:12 +01:00
NaVis0mple 437ecf956b update open the viewer button logic
1 problem remain: if entity select and close the photoviewer,
view button will not update class, still clickable though
2024-01-24 20:57:59 +08:00
Martin Raifer b00a7e31ec don't consider traffic_calming features as areas
prerequisite for https://github.com/openstreetmap/id-tagging-schema/pull/1076
2024-01-24 13:48:29 +01:00
NaVis0mple 59668638ac Search OSM notes by ID (#10062) 2024-01-24 13:32:35 +01:00
NaVis0mple 0ef947d425 Update set_photo_from_viewer button create/remove logic
refactor the code expandability for other photo_overlay

Not sure about context.features().on('change'), and hash part
2024-01-20 20:07:49 +08:00
NaVis0mple 2b0e0f6349 update core.yaml 2024-01-18 15:36:05 +08:00
NaVis0mple 6523ae6f94 Update icon to '#iD-operation-merge' 2024-01-18 15:20:33 +08:00
NaVis0mple 5890b79472 Add set mapillary id button in the mapillary photo viewer
It is the a. part in https://github.com/openstreetmap/iD/issues/6196#issuecomment-751460516

still need to add button disabled logic
2023-12-28 00:34:14 +08:00
NaVis0mple 33f4f8ee5c fix button title 2023-12-21 21:49:47 +08:00
NaVis0mple a2296cf03f fix setButton when imageChange disabled 2023-12-21 00:20:12 +08:00
NaVis0mple 87f001474f Add set button and view button at mapillary field (#9339)
more info see https://github.com/openstreetmap/iD/issues/6196#issuecomment-751460516
I do the b. (set button) and c. (view button)
order: click OSM object -> click mapillary layer will close the OSM input field. need to do in reverse order
2023-12-20 20:05:49 +08:00