Commit Graph

1414 Commits

Author SHA1 Message Date
Bryan Housel
cc4991d111 Don't draw until we've set zoom/lat/long 2019-05-17 11:19:38 -04:00
Bryan Housel
94c5164fe2 Add ability to show the square threshold in the rule name 2019-05-17 02:15:20 -04:00
Bryan Housel
bdb454e1b3 Remove utilCallWhenIdle, use requestIdleCallback/cancelIdleCallback
Places where a reset or connection switch would be problematic,
we can now cancel the callbacks.
2019-05-16 22:28:56 -04:00
Bryan Housel
aa7820b699 Don't treat new raw_tag_editor rows the same as deleted rows
(closes #6369)
2019-05-16 15:36:47 -04:00
Quincy Morgan
961a79e4f2 Add photo overlays used during editing to the "source" changeset tag (close #6279) 2019-05-16 14:52:41 -04:00
Bryan Housel
7be09db9ef Don't try to change a key/value that's already about to be deleted
(closes #6366)
2019-05-15 14:02:23 -04:00
Quincy Morgan
8bc634beac Make the raw member display limit a single variable 2019-05-14 15:31:50 -04:00
Quincy Morgan
49bef3d277 Fix issue where entries in the raw member editor wouldn't update after downloading the member manually (close #6358) 2019-05-14 15:31:07 -04:00
Quincy Morgan
a9c30e840c Revalidate immediately after running most fixes (close #6354)
Allow individual fixes to control revalidation
Don't allow fixes to run within a second of running any fix for that issue
2019-05-14 14:41:07 -04:00
Quincy Morgan
401c3a5005 Fix issue with the Label field by changing the class name of form-field-label (close #6344) 2019-05-13 10:36:21 -04:00
Quincy Morgan
ea1773f953 Fix error upon starting the walkthrough from the Help pane 2019-05-10 12:34:24 -04:00
Quincy Morgan
7a6949aa2e Account for the width of open panes when centering the map on issues 2019-05-10 11:33:59 -04:00
Quincy Morgan
1bbd496dfe When selecting an issue in the Issues pane, highlight the issue after selecting the feature
Use the same behavior when selecting an issue in the commit sidebar as in the issues pane
2019-05-10 10:18:46 -04:00
Quincy Morgan
f264cc47f0 Don't flag almost junctions when endpoint is building or parking entrance
Include issues for disabled rules in entity issues
2019-05-09 14:38:19 -04:00
Bryan Housel
289c75fee1 When showing tooltip, update disabled in case disabled states disagree
(closes #6296)
2019-05-07 17:53:22 -04:00
Bryan Housel
58cae43b9b Use parentNode instead of parentElement for IE 2019-05-07 17:48:56 -04:00
Quincy Morgan
3d9f7244f0 Update issue messages after merge instead of by invalidating issues 2019-05-07 16:38:08 -04:00
Quincy Morgan
97cb90b562 Make issue messages dynamic (close #6331) 2019-05-07 14:48:30 -04:00
Quincy Morgan
5160754dcc Display issues for disabled rules in the commit UI
Allow errors for disabled rules to block upload
Include warnings for disabled rules in the changeset tags (re: #6325)
2019-05-07 13:07:31 -04:00
Bryan Housel
966f5c3586 Add explicit validation calls to each operation
This is cleaner than adding hooks to transitionable actions, or performing validation
on every history change.  We want validation to run after each operation, but not
while the user is drawing lines or typing in fields.
2019-05-06 14:49:46 -04:00
Bryan Housel
659240d9fa Disclosure should unhide before rendering content
(closes #6312)

In case something in the content can't cope with `display: none`
2019-05-05 15:56:56 -04:00
Bryan Housel
ddc9d16b62 Merge pull request #6302 from openstreetmap/text-raw-tag-editor
Text raw tag editor / Copy-paste tags
2019-05-03 14:53:08 -04:00
Bryan Housel
16ec25753d Support escaping of tricky characters, support quoted strings
keys or values can be quoted or unquoted:
- leisure=park
- leisure="park"
- "leisure"=park
- "leisure"="park"
2019-05-03 14:42:35 -04:00
Quincy Morgan
cc85897348 Fix map pane animation on RTL layout (close #6290) 2019-05-03 11:05:10 -07:00
Bryan Housel
22b7e03d3b Disable spellcheck in the tag textarea 2019-05-03 10:39:38 -04:00
Bryan Housel
8a4e822fd7 If All Fields section is hidden, focus textarea and put cursor at end 2019-05-03 10:33:50 -04:00
Bryan Housel
fbe5389ecb Set textarea height to fit content 2019-05-03 10:14:53 -04:00
Bryan Housel
c95860f36d Convert changes in the textarea back to tag changes 2019-05-02 23:01:33 -04:00
Bryan Housel
61819058d3 Avoid frequent reflow from setting scrollTop
(possibly re: #6289)
2019-05-02 14:21:57 -04:00
Bryan Housel
b17e4e4f1d Add 'list'/'text' toggle buttons 2019-05-02 13:49:26 -04:00
Bryan Housel
cebe4ced8a Preserve user's preference for 'list'/'text' view for the raw tag editor 2019-05-02 11:17:06 -04:00
Bryan Housel
af97f09150 Remove "key=value" pasting into raw tag editor key
(Reverts: #6211, #5070, #5024)

The old code allows users to circumvent the readonly tag protection
see https://github.com/openstreetmap/iD/issues/6185#issuecomment-488692351

We'll offer a text-mode instead, with stricter checks on which keys can be modified.
2019-05-02 10:22:37 -04:00
Quincy Morgan
a180c794cb Merge branch 'master' into ignoring-issues 2019-05-01 20:13:49 -07:00
Quincy Morgan
712f8bcb03 Avoid having hidden issues strings for both singular and multiple variations 2019-05-01 20:13:09 -07:00
Bryan Housel
ea40634ac6 Add list<->text toggle for raw tag editor 2019-05-01 21:53:43 -04:00
Bryan Housel
087f252b18 When removing a tag, remove it from _indexedKeys too
(re: d026f2f / #5927)

So that if the user decides to put it back, it will be sorted to the
end and not inserted back at its original position in the middle
2019-05-01 19:17:59 -04:00
Quincy Morgan
eeaad79cb1 Display info about hidden issues in the "no issues" UI 2019-05-01 14:50:56 -07:00
Quincy Morgan
1c15338bd5 Make reset ignored button consistent with enable/disable all rules buttons 2019-05-01 12:13:10 -07:00
Quincy Morgan
56544303ca Merge branch 'master' into ignoring-issues 2019-05-01 11:58:39 -07:00
Quincy Morgan
52d92f125c Add button to reset ignored issues
Don't cache issue extent
2019-04-30 16:32:36 -07:00
Bryan Housel
d026f2f296 Add index property to tag rows, don't reorder on modifying key
(closes #5927)
2019-04-30 18:22:11 -04:00
Quincy Morgan
26f1e29072 Merge branch 'master' into ignoring-issues
# Conflicts:
#	data/core.yaml
#	dist/locales/en.json
2019-04-30 13:05:07 -07:00
Quincy Morgan
ddae6641b3 Fix issue where preset list would not appear when adding new features (close #6271) 2019-04-30 09:42:24 -07:00
Bryan Housel
dbb10bb155 Just update save count on all changes
(closes #6239)
2019-04-30 10:02:00 -04:00
Ming Gao
18dff285d0 add validation for very close node on road
addresses issue #6241

also made a change in inspector, so that when an untagged entity has issues,
show the entity editor so that the issues are visible when an item is clicked
in the issues pane.
2019-04-29 22:59:27 -04:00
Bryan Housel
a3605f9b74 Comment out "anchor encoding" for wiki links
(closes #6232)
2019-04-29 22:53:16 -04:00
Quincy Morgan
375779882d Add ability to ignore warnings
Replace issue's array of entities with array of entity IDs
Improve issue ID hashing
2019-04-29 17:52:32 -07:00
Bryan Housel
fceb1a86f7 Merge pull request #6245 from openstreetmap/d3-v5
d3 v5
2019-04-29 15:46:08 -04:00
Quincy Morgan
ea05d4e672 Unhighlight features when clicking issue quick fix (close #6219) 2019-04-26 16:26:19 -07:00
Quincy Morgan
3fad3513c1 Don't zoom to the feature and remove hover-highlighting upon clicking the issue fix button in the issues pane 2019-04-26 16:05:10 -07:00