Commit Graph

204 Commits

Author SHA1 Message Date
Bryan Housel
02713e48fb Move cache management out of tiler, it's responsibilty of service
Also remove some unused code and eslint warnings
2018-07-21 11:11:39 -04:00
Bryan Housel
d1fe81b905 rename utilTile -> utilTiler 2018-07-21 10:07:56 -04:00
Bryan Housel
e4d829ec06 Have the tiler return filtered results - re: skipNullIsland 2018-07-21 10:03:40 -04:00
Thomas Hervey
386d375b7a fix excessive note tiling and network request 2018-07-19 10:51:39 -04:00
Thomas Hervey
c563abaf7a pass dimensions to tile 2018-07-18 15:49:04 -04:00
Thomas Hervey
60f66b73e9 fixed missing declarations. TODO: fix tests 2018-07-18 15:16:52 -04:00
Thomas Hervey
5bf3f7ed3e Merge branch 'master' into refactor-loadTiles 2018-07-18 07:26:56 -04:00
Bryan Housel
e221dcae58 Dispatch new dimensions with photoview resize, resize all layers
-Adds ability to resize OpenStreetCam and Bing Streetside layers
-Also slightly increases the width of the resize handles
-Also limits max resize so it won't go larger than the map
2018-07-17 17:06:59 -04:00
Bryan Housel
b9a6996048 Merge branch 'feat-photoviewer-resize' of https://github.com/mapillary/iD into mapillary-feat-photoviewer-resize 2018-07-17 12:38:52 -04:00
Bryan Housel
73d0f30453 Merge branch 'notes' 2018-07-16 16:59:35 -04:00
Thomas Hervey
7ad765d408 added simple tests for loading and retrieving notes 2018-07-16 10:54:40 -04:00
Thomas Hervey
d4b1622667 moved getTiles and filtering to utils 2018-07-14 19:15:25 -04:00
Bryan Housel
1a106f5253 Make uiViewOnOSM work for notes too, add it to note_editor footer 2018-07-13 15:55:58 -04:00
Bryan Housel
33ef9a4357 Wrap callbacks with common checks for connection id and auth failure
This eliminates a lot of the copy-paste code in every callback.
2018-07-13 15:14:20 -04:00
Bryan Housel
f825845b79 Can't skip seen on the userDetails call
This call really does need for a result to be passed to the callback
2018-07-13 00:31:04 -04:00
Bryan Housel
775b47272d Remove from inflight cache before doing anything in done 2018-07-12 23:56:03 -04:00
Bryan Housel
645cc790a3 Add docs about OSM API, finish implementing postNoteUpdate
`postNoteUpdate` can hangle status changes and comment additions
(I named it that to be like `putChangeset`)

Also renamed `user` to `loadUser` to be consistent with other calls
2018-07-12 23:46:07 -04:00
Matias Volpe
b617695ad1 Remove OSM iD custom photo attribution to show MJS photo attribution 2018-07-12 17:59:56 -03:00
Bryan Housel
19560ebc90 Properly save and restore caches when entering/leaving the walkthrough 2018-07-12 15:39:04 -04:00
Matias Volpe
836517a9fe Add ability to resize to PhotoViewer 2018-07-12 09:41:10 -03:00
Bryan Housel
f52f24b517 Add noteOptions, default to 10k note limit and 7 days closed
Also bump note tile zoom to z12. There just aren't that many notes,
so this reduces API calls.
2018-07-10 23:28:37 -04:00
Bryan Housel
7423d192d4 Implement multi-fetch get for users from OSM API
Eagerly load user details after loading notes
(re: openstreetmap/openstreetmap-website#1921)
2018-07-10 23:02:37 -04:00
Bryan Housel
cd7cdd95e9 Add "View on Bing Maps" link, cleanup css
(closes #5125)
2018-07-10 02:04:39 -04:00
Bryan Housel
696895fb98 Add forward/backward controls to Streetside viewer
re: #5125

There is some cleverness here to search for the best nearby bubble
instead of just relying on the next and previous sequence keys.
2018-07-10 01:10:18 -04:00
Bryan Housel
1395e029d9 Add guard code for if Mapillary viewer could not be initialized 2018-07-09 16:17:09 -04:00
Thomas Hervey
14356cefe2 WIP: toggle note status 2018-07-08 12:50:02 -05:00
Tom Hughes
3819fd6498 Use XHR to access wikidata API instead of JSONP 2018-07-04 17:05:39 +01:00
Tom Hughes
1ab7cf790e Use XHR to access wikipedia API instead of JSONP 2018-07-04 17:05:26 +01:00
Bryan Housel
6f1dc12f99 Add user method to osm service, _userCache, user parser 2018-07-04 03:20:16 -04:00
Bryan Housel
bf499d9438 Restore modeSelect, and make a new modeSelectNote just for the notes 2018-07-03 18:11:59 -04:00
Bryan Housel
b14d1b5061 resolve conflicts, fix a few minor bugs prob caused by merging:
- don't insert multiple times into the rtree in `services/osm.js`
- use `d.id` instead of `d.key` as the key in `svg/notes.js`
2018-07-03 16:40:07 -04:00
Bryan Housel
e0cc6260f5 Switch innerHtml to textContent, which properly unescapes xml
This commit also fixes a linter error, and switches some
lodash _forEach to normal for loops.
2018-07-02 23:22:00 -04:00
Bryan Housel
2d2845e5d4 If notes are coincident, move them apart slightly 2018-07-02 16:56:05 -04:00
Bryan Housel
7999aca9e2 Add getNode and replaceNote methods, refactor caches 2018-07-02 16:02:53 -04:00
Bryan Housel
535208beb5 Move tests to spec/services/osm.js and remove old notes.js files 2018-07-01 23:35:10 -04:00
Bryan Housel
00c8ff4f69 Don't add notes to the _seenEntity cache
re: 229484a940 (commitcomment-29560519)
2018-07-01 22:50:28 -04:00
Bryan Housel
487ec9d837 Better spinner event management
re: https://github.com/openstreetmap/iD/pull/5107#issuecomment-401617938
2018-07-01 12:48:51 -04:00
Bryan Housel
229484a940 Cleanup osm service notes and caches, remove state variable
This seems like a lot but the main things here are:
- remove the _loadingTiles "global" variable.  It was causing problems because
it was being checked from the callbacks, which are async.
- cleanup the caches
- use DOM API getElementsByTagName('id') to get note id
- set a lower tilezoom z13 for notes (meaning: fetch larger bounding boxes)
2018-06-30 03:46:42 -04:00
Bryan Housel
d034691fb0 Merge remote-tracking branch 'origin/merge_notes_service' into notes 2018-06-29 22:11:39 -04:00
Bryan Housel
9517635d4d Merge branch 'master' into notes 2018-06-29 21:54:24 -04:00
Thomas Hervey
b3f7b06f66 merged: services/notes into /osm; todo: fix some caching & rendering 2018-06-29 20:01:30 -04:00
Thomas Hervey
737ccfcfba updated: siebar displays note details on hover (via svg) 2018-06-29 14:43:01 -04:00
Bryan Housel
39e170dd5f Add royal_cypher to the capital letter allowing whitelist
(closes #5109)
2018-06-24 12:15:53 -04:00
Bryan Housel
b1252d43ff Add booth field to telephone presets
(closes #5088)
2018-06-24 12:11:56 -04:00
Bryan Housel
917c6dd6fc Add hires checkbox to toggle 512 and 1024 resolutions
Also added code to calculate quadkey maps for:
- 2048 (works but is pretty slow and not that better than 1024)
- 4096 (doesn't work)
2018-06-22 23:07:07 -04:00
Bryan Housel
e2e3588b3c Add high resolution checkbox 2018-06-22 18:27:15 -04:00
Thomas Hervey
dab46d2778 updated: notes rendering 2018-06-22 17:43:07 -04:00
Bryan Housel
5975f0d902 Support resolution up to 2048, more zoom 2018-06-22 17:26:31 -04:00
Bryan Housel
b7df31b747 Update styles, reenter bubbles with new key when sequences connected 2018-06-22 15:32:28 -04:00
Bryan Housel
fb324dd865 Allow d3.geo.tile to fetch margin tiles (beyond viewport covering) 2018-06-22 12:24:40 -04:00