Commit Graph

44 Commits

Author SHA1 Message Date
Quincy Morgan 1564f73de6 Merge branch 'master' into validation 2019-02-07 20:51:21 -05:00
Bryan Housel d2735ab40c Fix misspelling 2019-02-07 13:41:06 -05:00
Quincy Morgan 77c4d41855 Restore many deletions warning with tooltip and nicer message
Add tooltips back to issues pane list
Fix crash when restoring without having loaded the edited area
2019-01-30 15:48:06 -05:00
Quincy Morgan 5b93ee0f7a Run validation upon data restore after page reload 2019-01-30 13:40:02 -05:00
Quincy Morgan 226c4f88e1 Re-run validation automatically upon merging fetched remote data into the history 2019-01-29 11:10:12 -05:00
Quincy Morgan ffe4aa09f4 Pass entity array into validators instead of changes object 2019-01-24 15:26:19 -05:00
Quincy Morgan e69f2a0389 Merge branch 'master' into validation 2019-01-23 13:15:33 -05:00
Quincy Morgan 0499a76443 Fixed an entity not found error when restoring new ways that reference unloaded nodes (closed #4108, closed #5194) 2019-01-22 12:56:37 -05:00
Quincy Morgan 536ee2e786 Validations now update instantly upon an annotated graph change 2019-01-14 15:19:00 -05:00
Quincy Morgan 11b2102761 Merge branch 'master' into validation
# Conflicts:
#	data/core.yaml
#	dist/locales/en.json
#	modules/ui/commit_warnings.js
#	modules/ui/entity_editor.js
#	modules/util/index.js
#	modules/util/util.js
#	modules/validations/index.js
#	modules/validations/many_deletions.js
#	modules/validations/missing_tag.js
2019-01-14 10:13:56 -05:00
Bryan Housel 528cbb29e1 Store the transform and selectedIDs with the rest of the history
(closes #5664)
2019-01-08 00:36:41 -05:00
Xiaoming Gao a4e1012c91 add crossing_way validation
Tests are also added and passed.

One thing to note: I had to add the tree() function to history so that I can
use the tree in the test; hope that's fine.
2018-12-19 19:23:35 -05:00
Xiaoming Gao c1e3a7396f filter validations early in history
Follow @wonga00's comment in https://github.com/openstreetmap/iD/pull/5627
2018-12-19 12:05:06 -05:00
Xiaoming Gao 07a53fe6ea Extend data model for validation issues
Add the Issues pane

1. Add a class to represent the validation issue
2. Extend the data model for an validation issue to
  (1) add a severity level field (useful for identify save-blocking issues later)
  (2) replace single entity with an array of entities (useful for issues involving multiple entities)
  (3) add a coordinates field for highlighting the location of the issue on the map
  (4) add a fixes field for possible automatic fixes

3. Update existing validation modules to use the new data model
2018-12-19 10:37:32 -05:00
Quincy Morgan 858a9606d5 Added entity display name or preset name to the disconnected highway message 2018-12-18 18:05:27 -05:00
Max Grossman 8f33a85a12 make collection.index function to handle failing tests 2018-12-17 17:16:10 -05:00
Max Grossman 96e44be69c merge 2.12.2 2018-12-13 11:22:32 -05:00
Bryan Housel 13b1a9a629 If imagery becomes invalid, remove it from imagery_used
(closes #4827)
2018-12-11 17:49:15 -05:00
Max Grossman 0a31137c78 move maprules/mapcss to a service class
ref #remote-presets
2018-09-23 18:38:01 -04:00
Max Grossman b93444de75 working on isArea-ish equivalent for mapcss selector objects
ref #remote-presets
2018-08-02 18:03:13 -04:00
Max Grossman 5b1dee3779 add tests for mapcss checks
ref #remote-presets
2018-08-02 12:47:47 -04:00
Max Grossman 2bf5eaf6e7 initial plumbing for iD validation errors
ref #remote-presets
2018-07-31 14:22:34 -04:00
Bryan Housel 6c3a02cebe Avoid lodash in hot code in coreDifference
(closes #2743, closes #4611)
2018-02-05 13:44:01 -05:00
Bryan Housel 78908bfaa1 Convert lodah-es and d3 to named imports for core 2017-09-24 22:52:12 -04:00
Bryan Housel 99a3741b0c Better isolation of services, to avoid hitting network during test runs
1. All services are disabled in testing now to prevent network accesses
2. Only services are enabled when needed to test something
3. Many changes throughout code to allow iD to run with services disabled
   (e.g. check for osm service instead of assuming context.connection() will work)
4. Actually export the services so we can disable and enable them
2017-08-09 22:04:09 -04:00
Bryan Housel ef95db8524 Add ability to history.pop n times
This is a little better than just calling pop a bunch of times because
it avoids dispatching extra history change events
2017-05-03 16:03:56 -04:00
Bryan Housel 2ebfcd174e Don't redo into un-annotated edit states
(closes #4006)
2017-05-03 00:21:37 -04:00
Bryan Housel 2e81e71859 Add history.toIntroGraph() for saving the edited introGraph to JSON 2017-04-04 02:00:01 -04:00
Bryan Housel 833a67f399 Allow history to set checkpoints and reset to them 2017-03-22 22:05:27 -04:00
Bryan Housel ddd1b7e43a Don't change history state while in transition 2017-01-04 17:37:29 -05:00
Bryan Housel eb0cdd5e8c History transition code cleanup 2016-12-23 17:18:28 -05:00
Bryan Housel d917424fc4 Support for performing transitionable actions 2016-12-23 00:57:05 -05:00
Bryan Housel 6ca4b13304 Store view transform and selectedIDs w/history, and undo/redo them
(closes #2204)
2016-12-10 23:25:58 -05:00
Bryan Housel 07fa5fcc34 Refactor Entity, Node, Relation, Tags, Way from core to osm 2016-10-11 22:41:24 -04:00
Bryan Housel 0d0e54fdff Fix more namespaces that were missed in the first pass 2016-10-04 21:15:30 -04:00
Bryan Housel 3102a4ae6a Rename all the things to include pseudonamespaces 2016-10-04 19:06:20 -04:00
Bryan Housel a86f34b4ef Pacify eslint, get build and tests running again 2016-08-26 01:15:07 -04:00
Tom MacWright cdb533fa84 Begin d3 v4 update 2016-08-21 15:19:27 -04:00
Tom MacWright 604d1e2719 import lodash (#3257) 2016-07-19 12:04:16 -04:00
Tom MacWright 3856b1ff2f Inter-require iD instead of relying on the global (#3256) 2016-07-19 10:30:50 -04:00
Kushan Joshi 39c82af158 Sort modules [eslint rule] 2016-07-06 12:12:08 +05:30
Kushan Joshi 780960c711 interim 2016-07-06 00:34:35 +05:30
Kushan Joshi 12df331d51 external modules for core 2016-06-18 02:08:14 +05:30
Kushan Joshi 59e6581aa5 Modularize iD.core 2016-06-16 18:41:37 +05:30