Quincy Morgan
a3d6097d40
Rename "Fix Me" Requests validation rule to more general Help Requests
...
Add subtypes to almost_junction and disconnected_way validation rules
Add additional validation documentation (re: #6100 )
2019-10-09 15:00:28 +02:00
Quincy Morgan
badde3d583
Add warning for features with names that equal values in their not:name tag ( close #6411 )
2019-10-04 11:06:27 +02:00
Quincy Morgan
525916da74
Recategorize tags_suggests_area validation rule into mismatched_geometry rule
...
Warn about points tagged as vertices and vertices tagged as points (close #6319 )
2019-09-26 10:56:30 +02:00
SilentSpike
770cffe7de
Add email and website format validation
...
Simple validation following the HTML5 standard for emails as we don't
expect POIs to have convoluted email addresses. Only checks the
`website` and `email` tags as these are what iD currently supports with
fields.
2019-06-06 13:55:53 -04:00
Quincy Morgan
942d55a4bf
Update strings for duplicate node validation
...
Use routable highway tags for duplicate node validation instead of any highway tag
2019-04-30 10:18:22 -07:00
Ming Gao
18dff285d0
add validation for very close node on road
...
addresses issue #6241
also made a change in inspector, so that when an untagged entity has issues,
show the entity editor so that the issues are visible when an item is clicked
in the issues pane.
2019-04-29 22:59:27 -04:00
Quincy Morgan
ecc217f5d8
Add validation rule to flag impossible oneway highways and waterways ( close #6216 )
2019-04-26 12:04:43 -07:00
Quincy Morgan
42de00e640
Add validation warning for "fixme" tags ( close #6214 )
2019-04-24 16:59:57 -07:00
Quincy Morgan
aa91c2d768
Move old multipolygon warning into Outdated Tags rule ( close #6218 )
2019-04-24 15:46:50 -07:00
Quincy Morgan
13f7e536dc
Move highway=road validation warning to the missing_tag validation rule (re: #6218 )
2019-04-24 15:19:57 -07:00
Quincy Morgan
34fcd01f98
Add validation warning for unsquare buildings
2019-04-23 15:50:52 -07:00
Bryan Housel
b5c5a00abc
Get rid of the many_deletions validation 🔪
...
It just doesn't fit in with all of the other validations that work on
entities, and it's not an actionable warning anyway.
https://github.com/openstreetmap/iD/pull/6140#issuecomment-483014618
2019-04-19 13:33:29 -04:00
Quincy Morgan
65e04acb2f
Flag features that mention Google in the "source" tag ( close #6135 )
2019-04-04 08:32:03 -07:00
Quincy Morgan
790d2e867e
Flag private contact information on houses and other residential buildings ( close #5850 )
2019-03-20 17:14:44 -04:00
Quincy Morgan
374cae5a7d
Add validation issue flagging ways with highway=road ( close #5998 )
2019-03-17 11:57:28 -04:00
Quincy Morgan
fb25a44017
Generalize deprecated_tags validation to outdated_tags validation
...
Add check for missing addTags go outdated_tags validation (close #6043 , close #6042 )
2019-03-12 17:08:20 -04:00
Quincy Morgan
6aa1f86dfb
Add warning for multipolygon members with no set role ( close #5851 )
2019-02-25 17:46:50 -05:00
Bryan Housel
9d58c4d0a2
Alphabetic
2019-02-11 14:11:35 -05:00
Quincy Morgan
46f3cea33a
Reorganize validation code
...
Rename IssueManager to coreValidator
Rename disconnected highway to disconnected way
Rename highway almost junction to almost junction
Rename mapcss checks to maprules
Rename deprecated tags to deprecated tag
2019-02-01 11:20:51 -05:00
Quincy Morgan
11b2102761
Merge branch 'master' into validation
...
# Conflicts:
# data/core.yaml
# dist/locales/en.json
# modules/ui/commit_warnings.js
# modules/ui/entity_editor.js
# modules/util/index.js
# modules/util/util.js
# modules/validations/index.js
# modules/validations/many_deletions.js
# modules/validations/missing_tag.js
2019-01-14 10:13:56 -05:00
Xiaoming Gao
ecacab3ffe
add validation for almost junction
...
but avoid connect when the edge goes in parallel to the other road.
also added tests for the validation.
2019-01-08 15:44:55 -05:00
Bryan Housel
5f20218f1f
Add validation warning for generic names
...
(closes #5590 )
2019-01-08 02:15:28 -05:00
Xiaoming Gao
a4e1012c91
add crossing_way validation
...
Tests are also added and passed.
One thing to note: I had to add the tree() function to history so that I can
use the tree in the test; hope that's fine.
2018-12-19 19:23:35 -05:00
Xiaoming Gao
07a53fe6ea
Extend data model for validation issues
...
Add the Issues pane
1. Add a class to represent the validation issue
2. Extend the data model for an validation issue to
(1) add a severity level field (useful for identify save-blocking issues later)
(2) replace single entity with an array of entities (useful for issues involving multiple entities)
(3) add a coordinates field for highlighting the location of the issue on the map
(4) add a fixes field for possible automatic fixes
3. Update existing validation modules to use the new data model
2018-12-19 10:37:32 -05:00
Max Grossman
2bf5eaf6e7
initial plumbing for iD validation errors
...
ref #remote-presets
2018-07-31 14:22:34 -04:00
Max Grossman
db78df55c8
get validaiton objects on context
...
ref #remote-presets
2018-07-31 13:41:24 -04:00
Bryan Housel
660511ec66
Add a validation warning about creating old-style multipolygons
...
(closes #3933 )
2017-05-04 12:30:58 -04:00
Bryan Housel
e9e442e998
Add a disconnected highway validation
...
(closes #3786 )
2017-01-23 16:50:31 -05:00
Bryan Housel
3102a4ae6a
Rename all the things to include pseudonamespaces
2016-10-04 19:06:20 -04:00
Martin Raifer
6f1744700a
refactor validations into ES6 modules #3118
2016-06-14 21:55:11 +02:00
