45ce4e4c57
Move turn restriction error position slightly
2019-02-01 22:51:02 +00:00
ee5f9f3bf2
Use consistent short service name
2019-02-01 22:51:02 +00:00
54e02ec28d
Introduce new container icon for errors
...
As per my last commit, this icon differentiates errors from points and
still allows us to specifiy icons for errors to differentiate them amongst
eachother.
I learned quite a bit about SVGs and using them in HTML while
implementing this 😝 Had some issues getting the icon to center in the
header so resorted to using a flexbox instead of absolute positioning
being used elsewhere.
2019-02-01 22:51:02 +00:00
5d907c1e16
Render errors like points with icons
...
This allows more diverse representation of the error subject at a glance
than relying on colour alone.
However, it would be good to have a generic error icon that can contain
icons which is differentiated from the point icon for clarity.
Sidebar header currently still uses the bolt icon until I figure out
how to deal with that. Also the font awesome icons don't seem to work,
perhaps there's additional code needed for those that I've missed.
2019-02-01 22:51:01 +00:00
4a166d7a5b
Use more descriptive key names
2019-02-01 22:51:01 +00:00
88a59cb15f
Stop hijacking the inflight cache
...
This could result in error updates getting aborted when new errors are
loaded as their individual ids are never going to match tile IDs (see
`abortUnwantedRequests` function).
2019-02-01 22:51:01 +00:00
fe73b3df5a
Improve error icon position and appearance
2019-02-01 22:51:00 +00:00
3334abf776
Remove some unnecessary code
2019-02-01 22:51:00 +00:00
31091f1159
Add direction of travel to oneway errors
2019-02-01 22:50:59 +00:00
6bdd0cfa89
Fix missing semicolons
2019-02-01 22:50:58 +00:00
3174db76b7
Fix north direction in some error descriptions
2019-02-01 22:50:58 +00:00
9d2792836f
Add ImproveOSM error resolution
2019-02-01 22:50:58 +00:00
ac4cec1429
Add sidebar preview for ImproveOSM errors
2019-02-01 22:50:57 +00:00
214cf41019
Use more generic classes for errors
2019-02-01 22:50:57 +00:00
39880e559b
Add direction of travel to turn restriction errors
2019-02-01 22:50:56 +00:00
9600d67fc6
Differentiate missing geometry errors by colour
2019-02-01 22:50:56 +00:00
bea6f4dcfd
Use point averages for locations
2019-02-01 22:50:56 +00:00
ca290b5101
Add details to error messages
2019-02-01 22:50:55 +00:00
23a4d71410
Handle turn restriction errors
2019-02-01 22:50:55 +00:00
4f2646d567
Add basic title + description UI
2019-02-01 22:50:54 +00:00
4d89810721
Add ImproveOSM service
...
Only processing one-way errors for now
2019-02-01 22:50:54 +00:00
58e31bc45a
initial update to draw modes and hover behavior
...
ref #5811
2019-02-01 17:34:40 -05:00
5a309fd57a
Merge branch 'master' into validation
2019-02-01 16:47:10 -05:00
9d8a0b7843
Merge pull request #5836 from openstreetmap/5829
...
do not close image viewer if street level imagery layers are still rendered
2019-02-01 16:42:31 -05:00
251d83f86c
Show warnings and errors in different lists in the issues pane
2019-02-01 16:38:48 -05:00
19cc6399fe
Merge branch 'master' into validation
2019-02-01 15:20:38 -05:00
9785021f44
Rename simpleMultipolygon functions to oldMultipolygon
...
Return old_multipolygon validation issues for the relations as well as the outer ways
Remove console logging
Don't run missing_tag validation for relations with old_multipolygon issues
2019-02-01 15:19:28 -05:00
7f837c7e0c
no need to generate service variable
...
ref #5929
2019-02-01 14:01:17 -05:00
ec1a42ad39
clean up & remove hideViewer for openstreetcam
...
ref #5829
2019-02-01 13:59:04 -05:00
d894521143
just don't close viewer...
...
ref #5829
2019-02-01 13:55:10 -05:00
973697b8ba
Run all validators in the validations folder if not manually run
...
Remove ValidationIssueType and ValidationIssueSeverity objects
2019-02-01 13:38:17 -05:00
ce8d16a220
initial commit...hide parts, not entire viewer
...
ref #5829
2019-02-01 11:49:30 -05:00
d1fca87d79
Replace Edit Documentation link with pencil icon
...
(closes #5753 )
2019-02-01 11:49:03 -05:00
46f3cea33a
Reorganize validation code
...
Rename IssueManager to coreValidator
Rename disconnected highway to disconnected way
Rename highway almost junction to almost junction
Rename mapcss checks to maprules
Rename deprecated tags to deprecated tag
2019-02-01 11:20:51 -05:00
e60dafa540
Fix crossing ways validation - geoChooseEdge takes projected loc
2019-01-30 23:40:17 -05:00
957eb28242
Don't run other validators if feature is missing tags
...
Don't run disconnected highway check if there is an almost junction issue already
Only run way validators on ways
2019-01-30 17:59:23 -05:00
09bc2a6e6c
Merge branch 'master' into validation
2019-01-30 16:44:14 -05:00
6aea578f92
Make validation functions take a single entity rather than an array of them
...
Pass context into validation functions directly rather than initializer
Don't initiate validation functions for every pass
2019-01-30 16:39:37 -05:00
49d62721d8
Fix background layer UI bugs
...
Add semicolon
2019-01-30 16:10:01 -05:00
77c4d41855
Restore many deletions warning with tooltip and nicer message
...
Add tooltips back to issues pane list
Fix crash when restoring without having loaded the edited area
2019-01-30 15:48:06 -05:00
7138acc652
Properly export areaKeys, fix preset and maprules tests
2019-01-30 15:29:37 -05:00
5b93ee0f7a
Run validation upon data restore after page reload
2019-01-30 13:40:02 -05:00
19a2a60bf4
Add tooltip to disabled upload button to specify what is blocking the upload
2019-01-30 13:20:56 -05:00
4048cdaf3b
Merge branch 'master' into validation
2019-01-30 10:30:14 -05:00
17bbc3d5a2
Slightly improve suggestion placement, preset search performance
...
- avoid lodash _filter when native filter is ok for arrays
- for suggestions use `originalName` instead of adding/removing the en-dash
- bump up importance of leading suggestions, but do a strict leading search
more on that last point:
For normal presets, we count a string as leading if it follows a space.
e.g. "office" will match "Law Office"
We don't really want this for suggestion presets though
e.g. "bell" should not match "Taco Bell"
2019-01-29 21:56:23 -05:00
6df2c24b14
Add Continue and Delete quick fixes for disconnected highway issue
2019-01-29 16:45:28 -05:00
0b19d5f93a
Merge branch master into validation
2019-01-29 14:51:59 -05:00
94c8f9f9f7
Update text for features to edit
2019-01-29 14:48:18 -05:00
fedad280b4
Use different messages for crossing tunnels and bridges if they are connectable
2019-01-29 14:30:42 -05:00
7aea67fcfe
Merge pull request #5745 from jguthrie100/stop_merge_overlapping_self
...
Add check to stop joining ways if resulting way intersects itself
2019-01-29 14:07:34 -05:00
SilentSpike