Commit Graph

4384 Commits

Author SHA1 Message Date
Yuri Astrakhan aa78cd10a3 Data items - remove hardcoded locale IDs
Locale IDs are now fetched together with the other data
when the language code is provided.
2018-12-22 14:58:15 -05:00
Tobias Jordans c97b659a34 Allow locale and language being set via URL param
With the hash-url `locale=en-US` or `locale=de-DE` one can force a locale and language regardless of the given language from the osm-website-settings.
2018-12-22 19:10:50 +01:00
Bryan Housel 3785ffb154 Simplify translation strings 2018-12-22 12:12:28 -05:00
Yuri Astrakhan b2810105a5 Implement support for multilingual descriptions from wiki data items
* Takes data directly from the Wikibase data items (OSM Wiki)
     https://wiki.openstreetmap.org/wiki/OpenStreetMap:Data_Items
* Understands the difference in regions - e.g. will show different
  images depending on the local settings
* Perf: Single request will get both the tag and key description
2018-12-22 00:23:31 -05:00
Bryan Housel 22e36be4f2 WIP on replacing documentation with direct calls to OSM wikibase 2018-12-22 00:23:31 -05:00
Quincy Morgan 70d5529a58 Added initial implementation of quick fix for connecting crossing features (still has some bugs) 2018-12-21 17:39:20 -05:00
Quincy Morgan 90bc7bf6a5 Changed crossing ways issue severity from error to warning 2018-12-21 17:21:29 -05:00
Andrew Wong 958d918bbe Merge pull request #5639 from wonga00/more_tests
Added more validation tests
2018-12-21 16:49:11 -05:00
Quincy Morgan 67e585e4c5 Crossing ways issues now use the relevant parent relation when the offending way itself does not have relevant tags 2018-12-21 16:10:48 -05:00
Quincy Morgan c593bb3475 The issue id now accounts for all entities 2018-12-21 14:51:18 -05:00
Quincy Morgan d9c6bd1f39 Added specialized issue messages for the common types of way crossing issues
Fixed several linting issues involving crossing way validations
2018-12-21 14:45:20 -05:00
Xiaoming Gao 5f333267f4 Merge pull request #5645 from gaoxm/improveCrossWayCheck
Improve cross way check
2018-12-21 14:16:47 -05:00
Quincy Morgan dc3a42f33d Fixed validation-related linting errors 2018-12-21 14:08:35 -05:00
Xiaoming Gao dee005e9aa Improve cross way check
1. Add more way types and relation types to check
2. Add more legit crossing cases
3. Add tests for 1 and 2
2018-12-21 14:00:31 -05:00
Quincy Morgan 627b4ee732 Fixed an bug where the wrong feature could be deleted from the untagged feature issue fix 2018-12-21 14:00:08 -05:00
Quincy Morgan c9350c632e Add issue fixes UI
Add two issue fixes for untagged feature
2018-12-21 12:31:33 -05:00
Bryan Housel f7150004c0 Refactor things out of util with limited use, move more to service 2018-12-21 11:56:55 -05:00
Andrew Wong 67bab7aecf don't import all of d3 2018-12-20 16:31:32 -05:00
Bryan Housel 4eb0e4b3a4 Remove more duplicate strings 2018-12-20 16:09:18 -05:00
Andrew Wong 5971bbebb7 Added more validation tests 2018-12-20 15:39:26 -05:00
Bryan Housel 177537f0ce Move coincident markers away from related geometry and from each other 2018-12-20 15:23:53 -05:00
Quincy Morgan 026597017a Update styling in the entity issues list 2018-12-20 14:49:35 -05:00
Bryan Housel 7f669d292f Simplify KeepRight tile fetching code 2018-12-20 14:40:14 -05:00
Quincy Morgan d58867df7c Add entity display label util function
Condense message and tooltip text for for the untagged feature issue
Use lighter border color for error issues
2018-12-20 14:04:15 -05:00
Quincy Morgan 373be68294 Merge branch 'master' into validation 2018-12-20 13:58:09 -05:00
Quincy Morgan 7c192a2e36 Fixed bug where the entity ID could not be found for the field 2018-12-20 12:25:35 -05:00
Quincy Morgan d7ef2de073 Re-organizes issue messages and tooltips 2018-12-20 12:16:54 -05:00
Quincy Morgan f0fa59874f Merge branch 'master' into validation 2018-12-20 10:31:25 -05:00
Quincy Morgan 97c2361f43 Changed initial sidebar screen for highway intersection vertices from preset list to editor 2018-12-20 10:17:16 -05:00
Bryan Housel 62547e3459 Merge pull request #5638 from openstreetmap/5612
remove highlight from relation member after it is deleted from relation
2018-12-20 10:10:46 -05:00
Bryan Housel e2c0f5edcd Merge pull request #5636 from openstreetmap/5596
open combobox if anywhere on box clicked...
2018-12-20 10:09:24 -05:00
Max Grossman 9a5a77f96c remove unneccessary space
ref #5612
2018-12-20 09:24:46 -05:00
Max Grossman 18c32511a2 remove member's highlight when removed from relation
ref #5612
2018-12-20 09:23:58 -05:00
Max Grossman e3407d4168 do not use mouseover, use mousedown!
ref #5596
2018-12-20 09:05:23 -05:00
Max Grossman 2dab19e9ae default to value() if neither d and choice are null in the accept function
ref #5618
2018-12-20 08:52:16 -05:00
Max Grossman 5a1dfeec72 open combobox if anywhere on box clicked...
ref #5596
2018-12-20 08:47:37 -05:00
Xiaoming Gao a4e1012c91 add crossing_way validation
Tests are also added and passed.

One thing to note: I had to add the tree() function to history so that I can
use the tree in the test; hope that's fine.
2018-12-19 19:23:35 -05:00
Quincy Morgan 2207a6c3a4 Added severity tooltip to issue icon 2018-12-19 18:35:17 -05:00
Quincy Morgan ac539dddaa Merge branch 'master' into validation 2018-12-19 18:13:44 -05:00
Quincy Morgan cfbb86f88c Change the initial view of the sidebar on selection 2018-12-19 17:44:41 -05:00
Andrew Wong 6e749c70ef listening to user generated history changes for validation 2018-12-19 17:28:34 -05:00
Bryan Housel 2deadd5d6c Fix merge issues 2018-12-19 17:12:06 -05:00
Quincy Morgan 490143d1a8 Added Issues section to the entity sidebar
Fixed bug where stale issues would stick around in the issues pane
2018-12-19 16:12:33 -05:00
Thomas Hervey f4e71812ca added: help documentation 2018-12-19 13:45:35 -05:00
Thomas Hervey cedf6955b5 added: notes and todos for keepRight 2018-12-19 13:45:34 -05:00
Thomas Hervey ee00635cc4 updated: some error colors; fixed: error 320, 220 2018-12-19 13:45:15 -05:00
SilentSpike 1f7455fdad Add missing error types 73, 74 and 75 2018-12-19 13:45:15 -05:00
SilentSpike 9bd772748a Convert warnings to regex
These aren't shown in the layer currently, but for future use this
should work
2018-12-19 13:45:15 -05:00
SilentSpike da23bf79a8 Fix parsing of error type 294 2018-12-19 13:45:15 -05:00
SilentSpike 005927dae3 Fix parsing of error type 211 2018-12-19 13:45:15 -05:00