9423f61adf
Improve some variable names in core/localizer
2021-02-23 11:50:42 -05:00
13ddeecfa7
Fix code tests for #8276 for real this time
...
Add utilFetchJson to get around some quirks of d3.json and use it for coreFileFetcher
Load real general English locale strings at the beginning of code tests
2021-02-23 11:50:00 -05:00
34e7be2796
Bump @rollup/plugin-node-resolve from 11.1.1 to 11.2.0
...
Bumps [@rollup/plugin-node-resolve](https://github.com/rollup/plugins ) from 11.1.1 to 11.2.0.
- [Release notes](https://github.com/rollup/plugins/releases )
- [Commits](https://github.com/rollup/plugins/compare/node-resolve-v11.1.1...node-resolve-v11.2.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-02-19 05:10:07 +00:00
997b453b98
Fix code tests for #8276
2021-02-15 12:56:46 -05:00
61d04104c1
Prefer latest phantomjs
2021-02-15 11:58:08 -05:00
9b667f5d9e
Fix running of tests in browser
2021-02-15 11:55:28 -05:00
d0754a9256
Trim whitespace from localized string ids
2021-02-15 11:09:26 -05:00
6f66032237
Fix issue with replacing number tokens in strings when toLocaleString is unavailable, such as when running tests (re: #8276 )
2021-02-15 10:59:44 -05:00
e09af9a575
Merge pull request #8322 from rbuffat/fix_wms_axis_ordering_detection
...
Fix wms detection to determine axis ordering
2021-02-15 10:26:56 -05:00
ef18d6ea34
Merge pull request #8354 from openstreetmap/dependabot/npm_and_yarn/rollup-2.39.0
...
Bump rollup from 2.38.5 to 2.39.0
2021-02-15 10:25:09 -05:00
5a12a5259d
Bump rollup from 2.38.5 to 2.39.0
...
Bumps [rollup](https://github.com/rollup/rollup ) from 2.38.5 to 2.39.0.
- [Release notes](https://github.com/rollup/rollup/releases )
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rollup/rollup/compare/v2.38.5...v2.39.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-02-15 05:42:51 +00:00
4d9336b1c7
Checkin en.min.json
2021-02-12 18:15:30 -05:00
76943351ca
Better handling of headGraph, separate head and base queues
...
This involves a few things to make the validator less weird
- _headGraph shouldn't be allowed to change while validation is happening..
- So we don't allow that to happen anymore, and keep track of _headPromise and _headIsCurrent
- If head graph falls behind, kick off another validation to catch it up
- Separate head and base work queues, so we aren't waiting for the base entities to validate
before providing feedback to the user about what they are editing
(the base queue can get quite large around metropolitan areas)
2021-02-12 18:07:36 -05:00
90bbe38fe8
Remove the brand combo from the name field
...
This has caused problems going back a long time, and now that we have a validator
and very visible brand presets with logos, it's not necessary anymore.
(re: #5558 , closes #8271 , closes #8304 )
2021-02-12 10:41:47 -05:00
9ed36281ba
Merge pull request #8348 from openstreetmap/dependabot/npm_and_yarn/osm-community-index-3.1.1
...
Bump osm-community-index from 3.1.0 to 3.1.1
2021-02-10 10:57:16 -05:00
a95d1c3e1b
Bump osm-community-index from 3.1.0 to 3.1.1
...
Bumps [osm-community-index](https://github.com/osmlab/osm-community-index ) from 3.1.0 to 3.1.1.
- [Release notes](https://github.com/osmlab/osm-community-index/releases )
- [Changelog](https://github.com/osmlab/osm-community-index/blob/main/CHANGELOG.md )
- [Commits](https://github.com/osmlab/osm-community-index/compare/v3.1.0...v3.1.1 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-02-10 05:28:46 +00:00
ca8a61cd36
Merge pull request #8318 from openstreetmap/dependabot/npm_and_yarn/d3-6.5.0
...
Bump d3 from 6.3.1 to 6.5.0
2021-02-05 11:46:43 -05:00
3fade479af
Merge pull request #8310 from openstreetmap/fix_notes
...
Fix a few errors in note processing
2021-02-05 11:46:06 -05:00
8245822e60
Merge pull request #8337 from openstreetmap/dependabot/npm_and_yarn/rollup-2.38.3
...
Bump rollup from 2.36.2 to 2.38.3
2021-02-01 10:05:43 -05:00
4bfa7dd157
Bump rollup from 2.36.2 to 2.38.3
...
Bumps [rollup](https://github.com/rollup/rollup ) from 2.36.2 to 2.38.3.
- [Release notes](https://github.com/rollup/rollup/releases )
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rollup/rollup/compare/v2.36.2...v2.38.3 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-02-01 15:03:22 +00:00
a55d99a2db
Merge pull request #8335 from openstreetmap/dependabot/npm_and_yarn/rollup/plugin-node-resolve-11.1.1
...
Bump @rollup/plugin-node-resolve from 11.0.1 to 11.1.1
2021-02-01 09:55:19 -05:00
a282ce3194
Bump @rollup/plugin-node-resolve from 11.0.1 to 11.1.1
...
Bumps [@rollup/plugin-node-resolve](https://github.com/rollup/plugins ) from 11.0.1 to 11.1.1.
- [Release notes](https://github.com/rollup/plugins/releases )
- [Commits](https://github.com/rollup/plugins/compare/commonjs-v11.0.1...node-resolve-v11.1.1 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-02-01 05:24:07 +00:00
3665f80d46
Also include operator:wikidata as a wikidata tag
...
osmEntity#hasWikipedia was only used by the suspicious_name validator
2021-01-29 11:11:59 -05:00
b032cd9f01
Adust NSI matching validation code:
...
- don't try matching semicolon-separated lists to NSI
- better matching for flagpoles with a `country` tag
- better lists of namelike keys (don't match flag operator)
see: https://github.com/openstreetmap/iD/pull/8305#issuecomment-769174070
2021-01-28 17:17:49 -05:00
6fa4bdf88a
Fix contributing document typo ( #8331 )
...
fix typo data/core/yaml -> data/core.yaml
2021-01-28 13:01:06 +00:00
4c1d51348d
Don't repurpose a node with interesting tags in crossing_ways fix
...
(closes #8326 )
2021-01-27 14:38:11 -05:00
3640e15fa2
Fix misspelling "coprorate" -> "corporate"
2021-01-27 11:54:39 -05:00
16f2f07300
Merge pull request #8319 from openstreetmap/promisify_validation
...
Promisify validation
2021-01-27 11:49:27 -05:00
f87c2d9357
Allow validators to return provisional results, revalidate after delay
...
Also add a ton of commments to validator.js
2021-01-27 10:38:48 -05:00
c721c1ebb5
fix wms detection
2021-01-26 20:30:36 +01:00
11201eb822
Rewrite the validator in ES6/Promises, several improvements here:
...
- implements a validation work queue, jobs are run during browser idle callbacks
- when merging base entities, don't run validations 2x on both base and head graphs (this was wasteful)
- keep track of resolved issues in a separate set (it's not a simple compare of base/head anymore)
this happens after validation queue is empty and avoids race conditions and inaccurate resolved counts
2021-01-25 12:50:11 -05:00
cb1e087126
Bump d3 from 6.3.1 to 6.5.0
...
Bumps [d3](https://github.com/d3/d3 ) from 6.3.1 to 6.5.0.
- [Release notes](https://github.com/d3/d3/releases )
- [Changelog](https://github.com/d3/d3/blob/master/CHANGES.md )
- [Commits](https://github.com/d3/d3/compare/v6.3.1...v6.5.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-25 05:22:33 +00:00
4f369a85a5
Match the prereleased nsi v5 (for now)
2021-01-22 11:59:14 -05:00
f195128968
Fix a few errors in note processing
...
- Notes still load over the xml api, so when the user is not authenticated,
we can't use d3_json to fetch them (instead use to d3_xml)
- Make sure to delete the deferred callback handles once the callbacks are
processed (probably unnecessary, but good housekeeping)
- Remove a stray `if (!json.elements)` block from the `parseUserJSON`
function. This was preventing the user profile from parsing, as the
user's JSON has no such property (was probably copied from `parseJSON`)
2021-01-21 14:29:17 -05:00
2803cd721e
Merge pull request #8309 from openstreetmap/polygon-clipping
...
Swap out w8r/martinez clipper for mfogel/polygon-clipping
2021-01-21 14:17:15 -05:00
2cd11040b3
Swap out w8r/martinez clipper for mfogel/polygon-clipping
...
This is a drop in replacement that performs better and yields more correct results
see also https://github.com/ideditor/location-conflation/pull/20
2021-01-21 11:31:29 -05:00
96298f2836
Preserve name value if this preset shows brand or operator field
...
This also fixes the logic for calculating whether the preset shows a
`brand` or `operator` field - it needs to use `fields()` to actually
resolve the fields, as these fields can be inherited from another preset.
This also includes a change to match "primary" names before
"alternate" names (aka the "Baby Gap" / "Gap" problem)
2021-01-19 13:15:16 -05:00
f61a3ef5e3
Don't replace flag:name tag - it's expected to be in local language
2021-01-18 21:44:27 -05:00
a32553595c
name:pronunciation is not namelike
2021-01-18 21:39:06 -05:00
74d28257c4
Fix teh misspellings
2021-01-18 19:48:35 -05:00
4228b65602
Support more *:wikidata tags for field locking and pin styling
2021-01-18 17:18:37 -05:00
f39f73e3ae
Make sure suggestion preset terms get used in the search
2021-01-18 15:02:07 -05:00
a38a93c073
Actually assign the locationSetID properties on the given objects
...
(should have been in 868db8819
2021-01-18 13:41:46 -05:00
0b3795cde3
NSI match returns an object now
2021-01-15 17:25:24 -05:00
d3fb8c60f9
Upgrade validations outdated_tags, suspicious_names to NSI v5
2021-01-13 13:46:00 -05:00
cb8e9e379a
Merge pull request #8297 from openstreetmap/dependabot/npm_and_yarn/rollup-2.36.1
...
Bump rollup from 2.35.1 to 2.36.1
2021-01-13 10:18:18 -05:00
d621ed03ab
Bump rollup from 2.35.1 to 2.36.1
...
Bumps [rollup](https://github.com/rollup/rollup ) from 2.35.1 to 2.36.1.
- [Release notes](https://github.com/rollup/rollup/releases )
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rollup/rollup/compare/v2.35.1...v2.36.1 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-13 05:13:08 +00:00
2d8c90786f
coreLocation tests, documentation
2021-01-11 13:01:30 -05:00
868db8819f
Have mergeLocationSets work on Objects, add locationSetID property
...
This means less work for the other parts of the code,
now they don't need to chain that extra step after the promise.
2021-01-09 10:34:58 -05:00
c4daf1b377
Use locationManager to resolve/query community index
2021-01-08 17:05:37 -05:00
Quincy Morgan