Commit Graph

436 Commits

Author SHA1 Message Date
Bryan Housel
2edc37b74e Leave out the changeset_id when downloading osmChange file
per https://github.com/openstreetmap/iD/pull/4350#discussion_r139261887
2017-09-15 20:04:42 -04:00
Bryan Housel
82494750ef Cleanup code, detect download support (alternate flow for IE, Edge) 2017-09-15 16:39:50 -04:00
Bryan Housel
a43b1e3c0a WIP: fix download changes on save conflicts screen 2017-09-14 22:25:17 -04:00
Bryan Housel
8c9aae1499 Add download changes link to uiCommitChanges summary
(WIP: still need to check IE11 and fix download on conflict screen)
2017-09-14 17:35:06 -04:00
Bryan Housel
1fcceeb0e8 Move string processing into background_source 2017-09-12 17:02:17 -04:00
Bryan Housel
75fcb892f8 Fix show/hide of list items 2017-09-12 15:32:23 -04:00
Bryan Housel
6addbba340 reorganize metadata object, change display of meters 2017-09-12 14:51:01 -04:00
Bryan Housel
6eb392f147 Merge branch 'esri-vintage' of https://github.com/jgravois/iD into jgravois-esri-vintage 2017-09-12 09:45:18 -04:00
Bryan Housel
59f1df902d When showing a field, set its default value if it has one
This allows universal fields or other standalone fields to have a default value.
This didn't work before becuase default values were only handled by
preset.applyTags() / preset.removeTags().
2017-09-11 15:16:02 -04:00
john gravois
5f341366e7 display additional metadata from Esri World Imagery
* getVintage() becomes getMetadata()
* ignore a couple unrelated lint nags
* add source description, resolution and accuracy info to debug panel
2017-09-11 09:51:07 -07:00
Bryan Housel
0f153d7d55 Ignore URLish fragments when detecting hashtags in changeset comment
(closes #4289)
2017-09-11 12:11:22 -04:00
Bryan Housel
ba8a1e6bc6 Several changes to avoid storing stale hashtags
(closes #4304)

- remove context.storage hashtags whenever hashtags are detected in comment.
- when changing the comment, override hashtags with any found in comment.
2017-09-11 11:50:59 -04:00
Bryan Housel
9719a31c79 Match less punctuation in hashtags
(closes #4303)
2017-09-11 09:55:29 -04:00
jgravois
7521369ece add support for displaying esri metadata 2017-09-09 21:59:07 -07:00
Bryan Housel
f034092b44 Write post-save count, not pre-save count to the changesets_count tag
(closes #4283)
2017-08-26 15:46:56 -04:00
Bryan Housel
bcfcfdea35 Merge branch 'master' into performance 2017-08-24 12:06:36 -04:00
Kushan Joshi
909b72a39e cleaning up 2017-08-24 17:03:04 +05:30
Bryan Housel
d667ee6e89 Clear history immediately when switching sources 2017-08-20 12:14:38 -04:00
Bryan Housel
121a1fa629 Avoid making an empty hashtags tag 2017-08-17 12:06:16 -04:00
Bryan Housel
2bf7a5e08b Write changeset tags for new mappers to indicate walkthrough progress
These tags all start with `ideditor:`
(closes #3968)

```
ideditor:walkthrough_completed=yes
ideditor:walkthrough_progress=welcome;navigation;point;area;line;building;startEditing
ideditor:walkthrough_started=yes
```
2017-08-16 20:10:01 -04:00
Bryan Housel
ea298b0b18 Change raw tag editor readOnlyTags to accept array of regex 2017-08-16 19:54:53 -04:00
Bryan Housel
25d8a8aa08 Store changesets_count in a changeset tag
(it will say "0" for someone making their first edit)
2017-08-16 16:31:21 -04:00
Bryan Housel
8cb04a087c Track walkthrough progress in localStorage 2017-08-16 14:30:21 -04:00
Bryan Housel
a42aa789e9 Add hashtags API parameter and localStorage
(closes #2834)
2017-08-16 10:47:17 -04:00
Bryan Housel
4cf357f61a Add code to extract hashtags from changeset comment 2017-08-16 00:30:34 -04:00
Bryan Housel
746b54f3d2 Make combo field work without an entity 2017-08-15 15:34:34 -04:00
Bryan Housel
e9909717c7 Change source field to semiCombo, let users pick common source types 2017-08-15 15:15:39 -04:00
Bryan Housel
09a661c718 Restore "good changeset comments" link in tag-reference section
Also includes a bunch of css cleanups for the tag-reference section
to fix style for readonly raw-tag-editor rows and adjust margin widths
2017-08-15 13:12:57 -04:00
Bryan Housel
7563f3ac16 Refactor duplicate form-field code to uiFormFields 2017-08-15 09:35:57 -04:00
Bryan Housel
ba3f823141 Split out commitWarnings and commitChanges sections into smaller modules 2017-08-15 01:50:52 -04:00
Bryan Housel
d7a07208e1 Restore saving comment to localstorage 2017-08-14 23:14:05 -04:00
Bryan Housel
194b56c0f0 Restore the comment google warning 2017-08-14 22:59:15 -04:00
Bryan Housel
e6eff907a2 Restore the previous changeset dropdown 2017-08-14 12:46:10 -04:00
Bryan Housel
4971a20409 Pacify eslint 2017-08-13 23:42:06 -04:00
Bryan Housel
9b37ac7b6c Fix errors with changeset fields and warnings, improve styles 2017-08-13 23:25:37 -04:00
Bryan Housel
78e874d6c4 Allow fields to work w/o entity, add options to disable buttons 2017-08-13 23:24:09 -04:00
Bryan Housel
fba6871e5c WIP: persist uiRawTagEditor, uiChangesetEditor between renders 2017-08-13 12:08:49 -04:00
Bryan Housel
e0266da083 WIP: add changeset fields and refactor 2017-08-12 14:26:34 -04:00
Bryan Housel
439eed4b39 WIP: refactor uiCommit into sections, introduce uiChangesetEditor
uiCommit is getting kind of big as we add more to the commit pane.

I'm going to split it up and put the field rendering code into a separate
module, similar to how uiEntityEditor embeds uiPresetEditor for the fields.

This allows us to add a few more fields that users can set on their changesets
(like hashtags, source), and even hide them under a "Add field" dropdown.
2017-08-11 17:17:46 -04:00
Bryan Housel
59e6642796 Pacify eslint 2017-08-11 15:07:42 -04:00
Bryan Housel
b172b4602b Move review_requested back to the buttons.. Make it work on tag changes 2017-08-11 01:12:42 -04:00
Bryan Housel
1a9614bb9d Adjust styles 2017-08-10 22:59:39 -04:00
Bryan Housel
9bba0ed57e Move request review up next to comment 2017-08-10 22:04:44 -04:00
Bryan Housel
03c8e07cb1 Remove the link to the osm wiki changeset page
(doesn't really add anything and not written for newbies)
2017-08-10 15:13:27 -04:00
Bryan Housel
e22c379094 Merge branch 'master' into request_review 2017-08-10 11:40:19 -04:00
Bryan Housel
99a3741b0c Better isolation of services, to avoid hitting network during test runs
1. All services are disabled in testing now to prevent network accesses
2. Only services are enabled when needed to test something
3. Many changes throughout code to allow iD to run with services disabled
   (e.g. check for osm service instead of assuming context.connection() will work)
4. Actually export the services so we can disable and enable them
2017-08-09 22:04:09 -04:00
Bryan Housel
d0fcae1b15 When drawing, ignore accidental clicks on mode buttons
(closes #4042)
2017-08-07 00:24:16 -04:00
Bryan Housel
3e168935d1 Swap increment/decrement spin buttons when RTL 2017-08-06 22:00:30 -04:00
Bryan Housel
077ee6d4b5 refactor structure type field to use uiField 2017-08-05 23:30:34 -04:00
Bryan Housel
8a399096b2 Add options for fields, allow unwrapped fields (no label, buttons, etc) 2017-08-05 00:33:20 -04:00